From michael.bentley at ge.com Thu Aug 2 22:08:05 2012 From: michael.bentley at ge.com (Bentley, Michael (GE Healthcare)) Date: Thu, 2 Aug 2012 18:08:05 -0400 Subject: [Ctk-developers] CMake Install bug found Message-ID: Hi everyone, In trying to install CTK on my linux box, I found that two files try to install themselves in the /designer/ directory. I figured it was put there by mistake, so I tracked down the location where this mistake occurs. In /CMake/ctkMacroBuildQtPlugin.cmake, on line 130, you set the variable CTK_INSTALL_QTPLUGIN_DIR to the same as CTK_INSTALL_LIB_DIR unless it has been manually defined by the user. Unfortunately, even when it isn't defined by the user, it never enters this if statement to perform that assignment, and hence CTK_INSTALL_QTPLUGIN_DIR has no value when setting the install paths a few lines later. The reason is because it IS defined, but has no value. In the SuperBuild.cmake file in the source directory, the CTK_INSTALL_QTPLUGIN_DIR value is being passed into the next invocation of CMake which will set up this install setup when we build the project for the first time. This means that even if CTK_INSTALL_QTPLUGIN_DIR is not defined for the first call to CMake by the user, it will have been defined for the internal CMake call made by the Makefile during the build step. This is why CTK_INSTALL_QTPLUGIN_DIR never is set to the default value inside of the ctkMacroBuildQtPlugin.cmake file, because it is defined through the command-line interface through the Makefile. (At least this is what I gather is going on). A simple fix would be to replace line 130 in /CMake/ctkMacroBuildQtPlugin.cmake and change it from if (NOT DEFINED CTK_INSTALL_QTPLUGIN_DIR) to if (CTK_INSTALL_QTPLUGIN_DIR STREQUAL "") This completely fixes the problem and the Qt Designer plugins are installed into the intended directory. Thanks, Michael From s.zelzer at dkfz-heidelberg.de Thu Aug 9 20:06:22 2012 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Thu, 09 Aug 2012 22:06:22 +0200 Subject: [Ctk-developers] CMake Install bug found In-Reply-To: References: Message-ID: <5024183E.2000609@dkfz-heidelberg.de> Hi Michael, Thanks a lot for your detailed analysis. I just pushed the fix to the CTK repository. Thanks, Sascha On 08/03/2012 12:08 AM, Bentley, Michael (GE Healthcare) wrote: > Hi everyone, > > In trying to install CTK on my linux box, I found that two files try to install themselves in the /designer/ directory. I figured it was put there by mistake, so I tracked down the location where this mistake occurs. > > In /CMake/ctkMacroBuildQtPlugin.cmake, on line 130, you set the variable CTK_INSTALL_QTPLUGIN_DIR to the same as CTK_INSTALL_LIB_DIR unless it has been manually defined by the user. Unfortunately, even when it isn't defined by the user, it never enters this if statement to perform that assignment, and hence CTK_INSTALL_QTPLUGIN_DIR has no value when setting the install paths a few lines later. The reason is because it IS defined, but has no value. > > In the SuperBuild.cmake file in the source directory, the CTK_INSTALL_QTPLUGIN_DIR value is being passed into the next invocation of CMake which will set up this install setup when we build the project for the first time. This means that even if CTK_INSTALL_QTPLUGIN_DIR is not defined for the first call to CMake by the user, it will have been defined for the internal CMake call made by the Makefile during the build step. This is why CTK_INSTALL_QTPLUGIN_DIR never is set to the default value inside of the ctkMacroBuildQtPlugin.cmake file, because it is defined through the command-line interface through the Makefile. (At least this is what I gather is going on). > > A simple fix would be to replace line 130 in /CMake/ctkMacroBuildQtPlugin.cmake and change it from > if (NOT DEFINED CTK_INSTALL_QTPLUGIN_DIR) > to > if (CTK_INSTALL_QTPLUGIN_DIR STREQUAL "") > This completely fixes the problem and the Qt Designer plugins are installed into the intended directory. > > Thanks, > Michael > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers From pmercea at bwh.harvard.edu Thu Aug 23 14:46:55 2012 From: pmercea at bwh.harvard.edu (Paul Mercea) Date: Thu, 23 Aug 2012 10:46:55 -0400 Subject: [Ctk-developers] No vertical ctkSliderWidget Message-ID: <5036425F.8090506@bwh.harvard.edu> Hi everybody, I'm working on a module for Slicer and I'm using some CTK widgets. I would like to insert a ctkSliderWidget into one of my widgets but for layouting purposes it would be great if it could have vertical orientation which it doesn't support yet. The ctkDoubleSlider in the ctkSliderWidget has a method for setting orientation so I wondered if there is a reason the ctkSliderWidget should only be horizontal !? If you think that a setOrientation(Qt::Orientation) method would be nice I could contribute that. Just let me know. I would change the main layout to QGridLayout and in setOrientation( ) I would set the given orientation to the ctkDoubleSlider and change it's position in the grid respectively. Or do you think there is a better approach ? Because changing the main layout from horizontal to vertical seems more complicated to me. Thanks. Paul From julien.finet at kitware.com Thu Aug 23 17:46:38 2012 From: julien.finet at kitware.com (Julien Finet) Date: Thu, 23 Aug 2012 13:46:38 -0400 Subject: [Ctk-developers] No vertical ctkSliderWidget In-Reply-To: <5036425F.8090506@bwh.harvard.edu> References: <5036425F.8090506@bwh.harvard.edu> Message-ID: It sounds like a great addition. Feel free to submit a patch ! You might want to investigate to see if ctkFlowLayout could help changing the orientation dynamically. j. On Thu, Aug 23, 2012 at 10:46 AM, Paul Mercea wrote: > Hi everybody, > > I'm working on a module for Slicer and I'm using some CTK widgets. > I would like to insert a ctkSliderWidget into one of my widgets but for > layouting purposes it would be great if it could have vertical orientation > which it doesn't support yet. > The ctkDoubleSlider in the ctkSliderWidget has a method for setting > orientation so I wondered if there is a reason the ctkSliderWidget should > only be horizontal !? > > If you think that a setOrientation(Qt::**Orientation) method would be > nice I could contribute that. Just let me know. I would change the main > layout to QGridLayout and in setOrientation( ) I would set the given > orientation to the ctkDoubleSlider and change it's position in the grid > respectively. Or do you think there is a better approach ? Because changing > the main layout from horizontal to vertical seems more complicated to me. > > Thanks. > Paul > ______________________________**_________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-**bin/mailman/listinfo/ctk-**developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: