From curzio at camelotbio.com  Thu Apr  5 08:55:12 2012
From: curzio at camelotbio.com (Curzio Basso)
Date: Thu, 5 Apr 2012 10:55:12 +0200
Subject: [Ctk-developers] status of ctkDICOMImportWidget
Message-ID: <FA55FF39-7FBD-4518-9810-C68E104A96E1@camelotbio.com>


Hi,

I have a quick question for the guys developing the DICOM lib: is ctkDICOMImportWidget
going to replace ctkFileDialog as import dialog used in the ctkDICOM application
for importing file from a directory? Or is it meant for another use other than importing
DICOM from the filesystem?

thanks (for any answer and for the great work you're doing)

best

--
Curzio Basso, Ph.D
CAMELOT Biomedical Systems Srl
Via Greto di Cornigliano 6R
16152 Genova, Italy

+39-010-8695741 (office)
+39-010-8695742 (fax)
+39-349-5972038 (mobile)



From pieper at ibility.net  Thu Apr  5 12:38:03 2012
From: pieper at ibility.net (Steve Pieper)
Date: Thu, 5 Apr 2012 08:38:03 -0400
Subject: [Ctk-developers] status of ctkDICOMImportWidget
In-Reply-To: <FA55FF39-7FBD-4518-9810-C68E104A96E1@camelotbio.com>
References: <FA55FF39-7FBD-4518-9810-C68E104A96E1@camelotbio.com>
Message-ID: <CA+OFd4wj7y+FVLqq1fWsTLhdTXSL2SgcS6dRMNXeTbs=ZskfgA@mail.gmail.com>

Hi Curzio -

I believe you are correct that the ctkDICOMImportWidget was intended to be
hooked to the Import button of the ctkDICOMAppWidget.  But for now we've
been using the ctkFileDialog with a custom checkbox added and that
generally works well and has the advantage that it supports the directory
shortcut panel on the left column.

Nicholas might want to comment on this -- he may have had additional plans
for the widget.

Best,
Steve

On Thu, Apr 5, 2012 at 4:55 AM, Curzio Basso <curzio at camelotbio.com> wrote:

>
> Hi,
>
> I have a quick question for the guys developing the DICOM lib: is
> ctkDICOMImportWidget
> going to replace ctkFileDialog as import dialog used in the ctkDICOM
> application
> for importing file from a directory? Or is it meant for another use other
> than importing
> DICOM from the filesystem?
>
> thanks (for any answer and for the great work you're doing)
>
> best
>
> --
> Curzio Basso, Ph.D
> CAMELOT Biomedical Systems Srl
> Via Greto di Cornigliano 6R
> 16152 Genova, Italy
>
> +39-010-8695741 (office)
> +39-010-8695742 (fax)
> +39-349-5972038 (mobile)
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120405/caf37134/attachment.htm>

From julien.finet at kitware.com  Thu Apr  5 13:02:48 2012
From: julien.finet at kitware.com (Julien Finet)
Date: Thu, 5 Apr 2012 09:02:48 -0400
Subject: [Ctk-developers] status of ctkDICOMImportWidget
In-Reply-To: <CA+OFd4wj7y+FVLqq1fWsTLhdTXSL2SgcS6dRMNXeTbs=ZskfgA@mail.gmail.com>
References: <FA55FF39-7FBD-4518-9810-C68E104A96E1@camelotbio.com>
	<CA+OFd4wj7y+FVLqq1fWsTLhdTXSL2SgcS6dRMNXeTbs=ZskfgA@mail.gmail.com>
Message-ID: <CAKoWPPG==F360dvZONaKrjSA7s6Jsd41OVpTfY8Ebe4iiLC9OA@mail.gmail.com>

Hi Curzio,

I just added a screenshot in the CTK gallery.
http://www.commontk.org/index.php/Documentation/ImageGallery#DICOM

As Steve said, ctkDICOMImportWidget is not used for the moment.
To be useable, it  requires more work (e.g. internally use DICOMDatabase,
internally use CopyToLibrary...). Feel free to contribute :-)

Nicholas/Steve, shall we make ctkDICOMImportWidget derive from
ctkFileDialog instead ?
Does it make sense to have a standalone widget to "import DICOM from a
local file system" ? Or maybe it can't be standalone ?

Maybe if the widget has no use we should remove it from the library...

My 2 cents,
Julien.

On Thu, Apr 5, 2012 at 8:38 AM, Steve Pieper <pieper at ibility.net> wrote:

> Hi Curzio -
>
> I believe you are correct that the ctkDICOMImportWidget was intended to be
> hooked to the Import button of the ctkDICOMAppWidget.  But for now we've
> been using the ctkFileDialog with a custom checkbox added and that
> generally works well and has the advantage that it supports the directory
> shortcut panel on the left column.
>
> Nicholas might want to comment on this -- he may have had additional plans
> for the widget.
>
> Best,
> Steve
>
>
> On Thu, Apr 5, 2012 at 4:55 AM, Curzio Basso <curzio at camelotbio.com>wrote:
>
>>
>> Hi,
>>
>> I have a quick question for the guys developing the DICOM lib: is
>> ctkDICOMImportWidget
>> going to replace ctkFileDialog as import dialog used in the ctkDICOM
>> application
>> for importing file from a directory? Or is it meant for another use other
>> than importing
>> DICOM from the filesystem?
>>
>> thanks (for any answer and for the great work you're doing)
>>
>> best
>>
>> --
>> Curzio Basso, Ph.D
>> CAMELOT Biomedical Systems Srl
>> Via Greto di Cornigliano 6R
>> 16152 Genova, Italy
>>
>> +39-010-8695741 (office)
>> +39-010-8695742 (fax)
>> +39-349-5972038 (mobile)
>>
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at commontk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120405/ec1664da/attachment.htm>

From curzio at camelotbio.com  Thu Apr  5 13:55:50 2012
From: curzio at camelotbio.com (Curzio Basso)
Date: Thu, 5 Apr 2012 15:55:50 +0200
Subject: [Ctk-developers] status of ctkDICOMImportWidget
In-Reply-To: <CAKoWPPG==F360dvZONaKrjSA7s6Jsd41OVpTfY8Ebe4iiLC9OA@mail.gmail.com>
References: <FA55FF39-7FBD-4518-9810-C68E104A96E1@camelotbio.com>
	<CA+OFd4wj7y+FVLqq1fWsTLhdTXSL2SgcS6dRMNXeTbs=ZskfgA@mail.gmail.com>
	<CAKoWPPG==F360dvZONaKrjSA7s6Jsd41OVpTfY8Ebe4iiLC9OA@mail.gmail.com>
Message-ID: <5B0C44BC-CBAC-4ABF-8C61-D8A18107A796@camelotbio.com>


thanks for the info, I will stick to ctkFileDialog for now. 

>  Feel free to contribute :-)

I will need some more time to feel confortable enough with CTK in order to 
contribute :-)

cheers

--
Curzio Basso, Ph.D
CAMELOT Biomedical Systems Srl
Via Greto di Cornigliano 6R
16152 Genova, Italy

+39-010-8695741 (office)
+39-010-8695742 (fax)
+39-349-5972038 (mobile)



From kikinis at bwh.harvard.edu  Thu Apr  5 14:07:01 2012
From: kikinis at bwh.harvard.edu (Ron Kikinis)
Date: Thu, 05 Apr 2012 10:07:01 -0400
Subject: [Ctk-developers] status of ctkDICOMImportWidget
In-Reply-To: <5B0C44BC-CBAC-4ABF-8C61-D8A18107A796@camelotbio.com>
References: <FA55FF39-7FBD-4518-9810-C68E104A96E1@camelotbio.com>
	<CA+OFd4wj7y+FVLqq1fWsTLhdTXSL2SgcS6dRMNXeTbs=ZskfgA@mail.gmail.com>
	<CAKoWPPG==F360dvZONaKrjSA7s6Jsd41OVpTfY8Ebe4iiLC9OA@mail.gmail.com>
	<5B0C44BC-CBAC-4ABF-8C61-D8A18107A796@camelotbio.com>
Message-ID: <4F7DA705.7030507@bwh.harvard.edu>

Also, its an invitation, not a requirement.
Ron

On 4/5/12 9:55 AM, Curzio Basso wrote:
>
> thanks for the info, I will stick to ctkFileDialog for now.
>
>>   Feel free to contribute :-)
>
> I will need some more time to feel confortable enough with CTK in order to
> contribute :-)
>
> cheers
>
> --
> Curzio Basso, Ph.D
> CAMELOT Biomedical Systems Srl
> Via Greto di Cornigliano 6R
> 16152 Genova, Italy
>
> +39-010-8695741 (office)
> +39-010-8695742 (fax)
> +39-349-5972038 (mobile)
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers

-- 
Ron Kikinis, M.D.,
Robert Greenes Distinguished Director of Biomedical Informatics
Professor of Radiology, Harvard Medical School
Director, Surgical Planning Laboratory
http://www.spl.harvard.edu/~kikinis


From s.zelzer at dkfz-heidelberg.de  Sun Apr 29 09:28:16 2012
From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer)
Date: Sun, 29 Apr 2012 11:28:16 +0200
Subject: [Ctk-developers] Clang and DCMTK
Message-ID: <4F9D09B0.2090603@dkfz-heidelberg.de>

Hi Folks,

I would look to see proper Clang support in CTK (and hence MITK) such 
that the native build tools on MacOS can be used (Clang is the default 
compiler for XCode).

It looks like the only show-stopper is the DCMTK version we are using. 
This problem has already been identified on the the Slicer mailing list 
[1] and I suggest to move forward with Jc's option b)

Update the sha1 ofgit.dcmtk.org/dcmtk.git  <http://git.dcmtk.org/dcmtk.git>    required to build CTK


Using the DCMTK 3.6.1 snapshot [2] would fix the DCMTK Clang issues and 
would also fix a few other issues we had in CTK (J2's static 
initialization problems and the duplicated DICOM SCU class). You can 
have a look at the necessary changes in CTK here:

https://github.com/saschazelzer/CTK/compare/master...dcmtk-3.6.1-snapshot-compatibility

Does anybody have any objections to merging the above branch into CTK 
master?

Thanks,

Sascha


[1]: 
http://slicer-devel.65872.n3.nabble.com/DCMTK-clang-compiler-errors-td3811531.html
[2]: http://support.dcmtk.org/wiki/dcmtk/news/start
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120429/3495f59b/attachment.htm>

From julien.finet at kitware.com  Mon Apr 30 15:53:56 2012
From: julien.finet at kitware.com (Julien Finet)
Date: Mon, 30 Apr 2012 11:53:56 -0400
Subject: [Ctk-developers] Clang and DCMTK
In-Reply-To: <4F9D09B0.2090603@dkfz-heidelberg.de>
References: <4F9D09B0.2090603@dkfz-heidelberg.de>
Message-ID: <CAKoWPPGrs29owbh=WAQuVEotDTxFns6B92gz03t5XFUQ+3zk+w@mail.gmail.com>

Hi Sashcha,

Thanks for taking care of it. I've not tried the "install" rules of
DCMTK. Do you confirm it works as expected.
For Slicer, before we can use DCMTK as shared we need to make sure the
Slicer packaging works fine with DCMTK, especially with the Mac fixup :-/

J.

On Sun, Apr 29, 2012 at 5:28 AM, Sascha Zelzer
<s.zelzer at dkfz-heidelberg.de>wrote:

>  Hi Folks,
>
> I would look to see proper Clang support in CTK (and hence MITK) such that
> the native build tools on MacOS can be used (Clang is the default compiler
> for XCode).
>
> It looks like the only show-stopper is the DCMTK version we are using.
> This problem has already been identified on the the Slicer mailing list [1]
> and I suggest to move forward with Jc's option b)
>
> Update the sha1 of git.dcmtk.org/dcmtk.git  required to build CTK
>
>
> Using the DCMTK 3.6.1 snapshot [2] would fix the DCMTK Clang issues and
> would also fix a few other issues we had in CTK (J2's static initialization
> problems and the duplicated DICOM SCU class). You can have a look at the
> necessary changes in CTK here:
>
>
> https://github.com/saschazelzer/CTK/compare/master...dcmtk-3.6.1-snapshot-compatibility
>
> Does anybody have any objections to merging the above branch into CTK
> master?
>
> Thanks,
>
> Sascha
>
>
> [1]:
> http://slicer-devel.65872.n3.nabble.com/DCMTK-clang-compiler-errors-td3811531.html
> [2]: http://support.dcmtk.org/wiki/dcmtk/news/start
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120430/20b3ad98/attachment.htm>

From s.zelzer at dkfz-heidelberg.de  Mon Apr 30 16:47:47 2012
From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer)
Date: Mon, 30 Apr 2012 18:47:47 +0200
Subject: [Ctk-developers] Clang and DCMTK
In-Reply-To: <CAKoWPPGrs29owbh=WAQuVEotDTxFns6B92gz03t5XFUQ+3zk+w@mail.gmail.com>
References: <4F9D09B0.2090603@dkfz-heidelberg.de>
	<CAKoWPPGrs29owbh=WAQuVEotDTxFns6B92gz03t5XFUQ+3zk+w@mail.gmail.com>
Message-ID: <4F9EC233.9070409@dkfz-heidelberg.de>

Hi J2,

I'm not sure I fully understand your question. I did not change the 
build type, DCMTK is still build as a static library (I tried building 
in shared mode but then some CTK DICOM tests did not run on Linux 
because the DCMTK command line tools do not contain rpath entries and 
hence the shared libs were not found).

I didn't touch anything "install" related either, everything is as it 
was before concerning the DCMTK build options (except an added 
DCMTK_WITH_DOXYGEN:BOOL=OFF and an explicit line for 
BUILD_SHARED_LIBS:BOOL=OFF which is the default).

Thanks for having a look,

Sascha

On 04/30/2012 05:53 PM, Julien Finet wrote:
> Hi Sashcha,
>
> Thanks for taking care of it. I've not tried the "install" rules of 
> DCMTK. Do you confirm it works as expected.
> For Slicer, before we can use DCMTK as shared we need to make sure the 
> Slicer packaging works fine with DCMTK, especially with the Mac fixup :-/
>
> J.
>
> On Sun, Apr 29, 2012 at 5:28 AM, Sascha Zelzer 
> <s.zelzer at dkfz-heidelberg.de <mailto:s.zelzer at dkfz-heidelberg.de>> wrote:
>
>     Hi Folks,
>
>     I would look to see proper Clang support in CTK (and hence MITK)
>     such that the native build tools on MacOS can be used (Clang is
>     the default compiler for XCode).
>
>     It looks like the only show-stopper is the DCMTK version we are
>     using. This problem has already been identified on the the Slicer
>     mailing list [1] and I suggest to move forward with Jc's option b)
>
>     Update the sha1 ofgit.dcmtk.org/dcmtk.git  <http://git.dcmtk.org/dcmtk.git>    required to build CTK
>
>
>     Using the DCMTK 3.6.1 snapshot [2] would fix the DCMTK Clang
>     issues and would also fix a few other issues we had in CTK (J2's
>     static initialization problems and the duplicated DICOM SCU
>     class). You can have a look at the necessary changes in CTK here:
>
>     https://github.com/saschazelzer/CTK/compare/master...dcmtk-3.6.1-snapshot-compatibility
>
>     Does anybody have any objections to merging the above branch into
>     CTK master?
>
>     Thanks,
>
>     Sascha
>
>
>     [1]:
>     http://slicer-devel.65872.n3.nabble.com/DCMTK-clang-compiler-errors-td3811531.html
>     [2]: http://support.dcmtk.org/wiki/dcmtk/news/start
>
>     _______________________________________________
>     Ctk-developers mailing list
>     Ctk-developers at commontk.org <mailto:Ctk-developers at commontk.org>
>     http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120430/57f52683/attachment.htm>

From julien.finet at kitware.com  Mon Apr 30 17:05:10 2012
From: julien.finet at kitware.com (Julien Finet)
Date: Mon, 30 Apr 2012 13:05:10 -0400
Subject: [Ctk-developers] Clang and DCMTK
In-Reply-To: <4F9EC233.9070409@dkfz-heidelberg.de>
References: <4F9D09B0.2090603@dkfz-heidelberg.de>
	<CAKoWPPGrs29owbh=WAQuVEotDTxFns6B92gz03t5XFUQ+3zk+w@mail.gmail.com>
	<4F9EC233.9070409@dkfz-heidelberg.de>
Message-ID: <CAKoWPPGj1T5X9NnGOUyWJc+02y1wDq2FiDYjnodkc1tb1+YKEQ@mail.gmail.com>

If you didn't change from Static to Shared, then no worries, it should be
fine with Slicer.
Thanks,
j.

On Mon, Apr 30, 2012 at 12:47 PM, Sascha Zelzer <s.zelzer at dkfz-heidelberg.de
> wrote:

>  Hi J2,
>
> I'm not sure I fully understand your question. I did not change the build
> type, DCMTK is still build as a static library (I tried building in shared
> mode but then some CTK DICOM tests did not run on Linux because the DCMTK
> command line tools do not contain rpath entries and hence the shared libs
> were not found).
>
> I didn't touch anything "install" related either, everything is as it was
> before concerning the DCMTK build options (except an added
> DCMTK_WITH_DOXYGEN:BOOL=OFF and an explicit line for
> BUILD_SHARED_LIBS:BOOL=OFF which is the default).
>
> Thanks for having a look,
>
> Sascha
>
>
> On 04/30/2012 05:53 PM, Julien Finet wrote:
>
> Hi Sashcha,
>
>  Thanks for taking care of it. I've not tried the "install" rules of
> DCMTK. Do you confirm it works as expected.
> For Slicer, before we can use DCMTK as shared we need to make sure the
> Slicer packaging works fine with DCMTK, especially with the Mac fixup :-/
>
>  J.
>
> On Sun, Apr 29, 2012 at 5:28 AM, Sascha Zelzer <
> s.zelzer at dkfz-heidelberg.de> wrote:
>
>>  Hi Folks,
>>
>> I would look to see proper Clang support in CTK (and hence MITK) such
>> that the native build tools on MacOS can be used (Clang is the default
>> compiler for XCode).
>>
>> It looks like the only show-stopper is the DCMTK version we are using.
>> This problem has already been identified on the the Slicer mailing list [1]
>> and I suggest to move forward with Jc's option b)
>>
>> Update the sha1 of git.dcmtk.org/dcmtk.git  required to build CTK
>>
>>
>> Using the DCMTK 3.6.1 snapshot [2] would fix the DCMTK Clang issues and
>> would also fix a few other issues we had in CTK (J2's static initialization
>> problems and the duplicated DICOM SCU class). You can have a look at the
>> necessary changes in CTK here:
>>
>>
>> https://github.com/saschazelzer/CTK/compare/master...dcmtk-3.6.1-snapshot-compatibility
>>
>> Does anybody have any objections to merging the above branch into CTK
>> master?
>>
>> Thanks,
>>
>> Sascha
>>
>>
>> [1]:
>> http://slicer-devel.65872.n3.nabble.com/DCMTK-clang-compiler-errors-td3811531.html
>> [2]: http://support.dcmtk.org/wiki/dcmtk/news/start
>>
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at commontk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120430/533dd76f/attachment.htm>