[Ctk-developers] Remarks about Applications/ctkDICOM/Testing/Cpp

[Jean-Christophe Fillion-Robin]

Folks,

In most of the test associated with the ctkDICOM applications, I noticed
that target_libraries.cmake is used.

Few remarks:

  - Using the macro ctkFunctionGetTargetLibraries in CMakeLists.txt
associated with tests hasn't been tested -- But I guess nothing prevent
would prevent from using it

  - Even if possible, using this macro and the associated *
target_libraries.cmake* file won't be useful. Indeed, the initial idea
behind *target_libraries.cmake* is to know the dependency of library from
the Superbuild level. The system doesn't handle the dependency associated
with tests. (It could be extended to do so ...)

   - Since the file is *target_libraries.cmake *parsed using a regular
expression, conditional definition won't work within the file.

It means the following files should be fixed:
  -
https://github.com/commontk/CTK/blob/master/Applications/ctkDICOM/Testing/Cpp/CMakeLists.txt
  -
https://github.com/commontk/CTK/blob/master/Applications/ctkDICOM/Testing/Cpp/target_libraries.cmake
  - The same remarks applies for all tests associated with ctkDICOM
applications

What shout be done:
  - If testing a command line application: Invoke that application
  - If designing some unit testing for some widget of that application:
       - May be these widgets should belong to CTK libraries .. ?
       - If not, create a statit or shared librarie that both the
application and the test could link against

Any questions, let me know
Thanks
Jc

-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110914/8865c7c2/attachment.htm>