[Ctk-developers] ctkUtils::rmdir - Delete recursively a directory
Jean-Christophe Fillion-Robin
jchris.fillionr at kitware.com
Thu Sep 1 16:55:51 UTC 2011
Hi Sasha,
Since the Qt equivalent was named QDir::rmdir, I adopted the same name.
Changing the name wouldn't be a problem.
What about "removeDirRecusively" instead ?
Jc
On Thu, Sep 1, 2011 at 12:43 PM, Sascha Zelzer
<s.zelzer at dkfz-heidelberg.de>wrote:
> Hi Jc,
>
> Looks good. I guess the CTKCore dependency of the ctkPluginFramework was
> just a matter of time, so I am good with it.
>
> Just a little "style" comment: The "rmdir" function name looks a little out
> of place when compared with the others. What about "removeDir"? Just my two
> cents.
>
> Thanks for pushing code reuse,
>
> Sascha
>
>
> On 09/01/2011 06:26 PM, Jean-Christophe Fillion-Robin wrote:
>
> Hi Folks,
>
> I was looking for a function to delete recursively a function and I found
> out that such code has present in multiple location:
> - ctkPluginFrameworkUtil_p.h<https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a#diff-4>
> - ctkPluginGenerator.cpp<https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a#diff-0>
>
> Topic "ctkutils-rmdir" has been integrated to master. It includes:
> - addition of "rmdir" function to ctkUtils
> - implementation of the corresponding test in ctkUtilsTest4.cpp
> - See
> https://github.com/commontk/CTK/commit/fd8cfead27c56ae607e379d764d2eb790d16af3e
>
> Topic "reuse-ctkutil-rmdir-in-toolkit" has NOT been integrated to master,
> indeed it implies that ctkPluginFramework will depend on CTKCore. Does that
> sounds reasonable ?
> See https://github.com/jcfr/CTK/tree/reuse-ctkutil-rmdir-in-toolkit
> and
> https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a
>
> Thanks
> Jc
>
>
>
> --
> +1 919 869 8849
>
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
--
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110901/55307497/attachment.htm>
More information about the Ctk-developers
mailing list