[Ctk-developers] Fwd: Contribution to PythonQt
Dominique Belhachemi
domibel at debian.org
Wed Oct 19 02:02:08 UTC 2011
Hi Jc,
Personally I like projects with only one license and one copyright
holder. It keeps the license maintenance low.
Your commit changes the License to LGPL which is very helpful.
Otherwise upstream would probably not accept your contribution.
But unfortunately it adds the Kitware Copyright and some contact
information to the license header. For my patches I always use
upstream's original header to keep things simple.
Here is an example of the PythonQt header:
https://github.com/commontk/PythonQt/blob/patched/src/PythonQtClassInfo.h
Thanks
Dominique
On Tue, Oct 18, 2011 at 9:37 PM, Jean-Christophe Fillion-Robin
<jchris.fillionr at kitware.com> wrote:
> Hi Dominique,
>
> Could you review the commit I pushed earlier today:
> https://github.com/commontk/PythonQt/commit/83dbbc27afddd3ff7d5b3616e205b0cf1a465921
>
> Thanks
> Jc
>
> On Tue, Oct 18, 2011 at 9:26 PM, Dominique Belhachemi <domibel at debian.org>
> wrote:
>>
>> On Tue, Oct 18, 2011 at 11:24 AM, Jean-Christophe Fillion-Robin
>> <jchris.fillionr at kitware.com> wrote:
>> > Hi Folks,
>> >
>> > Florian Link, from MeVisLab, has been very responsive and, less than
>> > 24hours
>> > following my initial email, already provided me with feedback regarding
>> > the
>> > possible integration of our CTK specific changes. See below.
>> >
>> > Its only concern regards the license associated with two of the file I
>> > added
>> > to PythonQt. I added them using CTK license.
>> >
>> > Being the author of the files, I have no problem switching the license
>> > to
>> > LGPL so that our contribution can be merged upstream.
>> >
>> > 1) I would like to make sure we all agree.
>> >
>> > 2) Discuss the licensing of contribution associated with our
>> > contribution to
>> > LGPL libraries.
>> >
>> This is excellent news. It will speedup the CTK/Slicer integration into
>> Debian.
>> Is it possible to go a step further and assign the copyright of JC's to
>> MeVis?
>>
>> Dominique
>
>
>
> --
> +1 919 869 8849
>
>
More information about the Ctk-developers
mailing list