[Ctk-developers] Fwd: Contribution to PythonQt
Jean-Christophe Fillion-Robin
jchris.fillionr at kitware.com
Tue Oct 18 15:24:35 UTC 2011
Hi Folks,
Florian Link, from MeVisLab, has been very responsive and, less than 24hours
following my initial email, already provided me with feedback regarding the
possible integration of our CTK specific changes. See below.
Its only concern regards the license associated with two of the file I added
to PythonQt. I added them using CTK license.
Being the author of the files, I have no problem switching the license to
LGPL so that our contribution can be merged upstream.
1) I would like to make sure we all agree.
2) Discuss the licensing of contribution associated with our contribution to
LGPL libraries.
Thanks for your feedback,
Jc
---------- Forwarded message ----------
From: Florian Link <florian.link at mevis.de>
Date: Tue, Oct 18, 2011 at 3:02 AM
Subject: Re: Contribution to PythonQt
To: Jean-Christophe Fillion-Robin <jchris.fillionr at kitware.com>
Cc: info at mevislab.de, Dominique Belhachemi <domibel at debian.org>
**
Dear Jean-Christophe,
I had a look at your changes. I suggest the following:
- the warnings/small unicode fixes are not a problem and can be merged
easily
- the VTK wrapping should be done by supporting class wrapping callbacks in
PythonQt,
so that the VTK wrapping code can be located outside of PythonQt
(I can add those callbacks). You will then have to register your VTK
wrapping callbacks where you initialize PythonQt.
- the std in redirection makes sense and can be merged
- the generator fixes/warnings are ok and can be merged
- the dPython.h file seems to be a special fix that you did, this should be
switchable, since some people want a debug Python with using debug PythonQt.
This leaves us with the licensing issue. I can only accept code that you
submit under the LGPL 2.1, so the Apache 2 license is
not an option (I don't want PythonQt to get multi-license). Since this only
regards dPython.h and PythonQtStdIn*,
I guess you do not have a problem with submitting those under LGPL 2.1?
regards,
Florian
Am 17.10.2011 16:49, schrieb Jean-Christophe Fillion-Robin:
Dear MevisLab / PythonQt developers,
My name is Jean-Christophe, R&D engineer at Kitware
Inc.<http://www.kitware.com>,
and I am actively involved in the development of Slicer
4.0<http://www.slicer.org>,
a medical multi-platform, free open source software for visualization and
image computing.
While working on Slicer, a lot of code has been contributed to the open
source toolkit named CTK <http://www.commontk.org>. The Common ToolKit (CTK)
provides a unified set of basic programming constructs that are useful for
medical imaging applications development. More information are available
here: http://www.commontk.org
PythonQt being the python scripting "backend" of CTK, we added some code and
we would like to contribute back.
Dominique Belhachemi, a volunteer Debian packager, is helping us to package
both CTK and Slicer. He suggested that we contribute back our code so that
the currently existing PythonQt libraries/packages include our changes.
The list of changes is available here:
https://github.com/commontk/PythonQt/compare/svn-mirror...patched
It includes:
- CMake'ification of the project
- Support for VTK python
Would be great if you could let us know if that sounds like a reasonable
idea or if we should improve anything.
Thanks
Jc
Cc: Dominique Belhachemi
--
+1 919 869 8849
--
------------------------------------------------------------------------
Florian Link
Chief Software Architect MeVisLab
Tel.: +49-421-22495 52
Fax: +49-421-22495 11www.mevis.de
MeVis Medical Solutions AG
Universitaetsallee 29
28359 Bremen
Germany
Trade Registry: Bremen HRB 23791
VAT ID: DE250659412
Executive Board: Carl J.G. Evertsz, Ph.D. (Chairman & CEO), Robert
Hannemann Ph.D., Thomas E. Tynes
Chairman of the Supervisory Board: Heinz-Otto Peitgen, Ph.D.
--
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20111018/86861f8b/attachment.htm>
More information about the Ctk-developers
mailing list