[Ctk-developers] Filenames alphabetically sorted in CMakeLists.txt

Steve Pieper pieper at ibility.net
Mon Jun 27 10:57:01 EDT 2011


Sounds very good to me -- in fact, it looks like you added this to the
coding style back in February, Julien :D

http://www.commontk.org/index.php?title=Contributing_to_CTK&diff=669&oldid=668

On Sun, Jun 26, 2011 at 4:14 PM, Jean-Christophe Fillion-Robin <
jchris.fillionr at kitware.com> wrote:

> +1
>
> On Sun, Jun 26, 2011 at 2:40 PM, Julien Finet <julien.finet at kitware.com>wrote:
>
>> Hi CTK developers,
>>
>> I'm not sure we ever discussed it before (I think I remember Marco talking
>> about it sometime) but I'd like to make sure we all agree that "files
>> inclusions must be alphabetically ordered in CMakeLists.txt" (except if
>> there is an obvious different category ordering).
>> This is helpful for 2 reasons:
>>  - It is less prone to generate conflicts when rebasing. If two commits
>> add a file, they are less unlikely to conflict if they are alphabetically
>> ordered than if they both are added at the bottom of the list.
>>  - (Faster to lookup a file in the cmakelists)
>>
>> Of course, the discussion is open, so please share your thoughts !
>>
>> Regards,
>> Julien.
>>
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at commontk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>
>>
>
>
> --
> +1 919 869 8849
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110627/c8e675c4/attachment.html>


More information about the Ctk-developers mailing list