[Ctk-developers] CTK license and copyright

Jean-Christophe Fillion-Robin jchris.fillionr at kitware.com
Thu Jul 14 12:17:01 EDT 2011 

Excellent !

For reference, I just found the following links:
 - http://manpages.ubuntu.com/manpages/natty/man1/licensecheck.1.html
 - https://wiki.ubuntu.com/LicenseReviewProcessImprovementSpec

Would you like to create a CMake module named for example
LicenseCheckTest.cmake ?  :)

That module could for example contain a macro named:
add_licensecheck_test(NAME <name> FILES <files> ....)

The test would fail with the list of files not having a license.

We could also think about an option allowing to specify keywords
representative of the incompatible license ...

That way we would have a systematic way of making sure that source files
have the proper license header ...

Using githook to prevent the problem of happening upstream could also be a
solution ...

What do you think?

Thanks
Jc


On Thu, Jul 14, 2011 at 10:18 AM, Dominique Belhachemi
<domibel at debian.org>wrote:

> Yes, this is a wonderful tool for a basic check. As usually I am using
> licensecheck and grep for the checks. Later, before uploading, I go
> manually through the files to check If I catched everything.
>
> Cheers
> Dominique
>
> On Thu, Jul 14, 2011 at 3:49 AM, Mathieu Malaterre
> <mathieu.malaterre at gmail.com> wrote:
> > This is a tool available at least on debian, called licensecheck (usr
> > -r for recursive checking)
> >
> > HTH
> >
> > On Thu, Jul 14, 2011 at 2:12 AM, Jean-Christophe Fillion-Robin
> > <jchris.fillionr at kitware.com> wrote:
> >> Dominique,
> >>
> >> I integrated the topic " fix-license-header".
> >>
> >> Out of curiosity, which method/script did you use to find out which file
> >> where missing a license ?
> >>
> >> See
> >>
> https://github.com/commontk/CTK/commit/6fe14129c4318c47df771969818fbbe12000c465
> >>
> >> Thanks
> >> Jc
> >>
> >> On Wed, Jul 13, 2011 at 8:07 PM, Jean-Christophe Fillion-Robin
> >> <jchris.fillionr at kitware.com> wrote:
> >>>
> >>> Steve,
> >>>
> >>>  I noticed that you updated some files with the proper copyright
> (Isomics,
> >>> Inc).
> >>> See
> >>>
> https://github.com/commontk/CTK/commit/16404dfd91721a638ffed1f9ec9fadcbe591335e
> >>>
> >>> Note: Having already started and published a topic named
> >>> fix-license-header, it would have been "better" to checkout that topic,
> add
> >>> your commit and publish your commit back on your fork ...  :p
> >>> See
> >>>
> https://github.com/commontk/CTK/commit/16404dfd91721a638ffed1f9ec9fadcbe591335e
> >>>
> >>> I will go ahead and integrate that topic.
> >>>
> >>> Thanks
> >>> Jc
> >>>
> >>> On Sat, Jul 9, 2011 at 7:14 PM, Jean-Christophe Fillion-Robin
> >>> <jchris.fillionr at kitware.com> wrote:
> >>>>
> >>>> Hi Folks,
> >>>>
> >>>> I added a license on all *.h and *.cpp files.
> >>>>
> >>>> See https://github.com/jcfr/CTK/compare/master...fix-license-header
> >>>>
> >>>> //-----------------------------------
> >>>> Note: I added the appropriate license using the following script to
> >>>> determine the first author.
> >>>>
> >>>>  for i in `cat headers.txt`; \
> >>>>   do a=`git log --follow --format="%an" $i  | tail -n 1`;\
> >>>>   echo "$a --- $i"; \
> >>>> done
> >>>>
> >>>> //-----------------------------------
> >>>> Few questions:
> >>>>
> >>>> * What is the best practice regarding python script ? How should we
> >>>> integrate the license ? docstring, ... ?
> >>>>
> >>>> * The files authored by Steve Pieper mention "Kitware, Inc." in the
> >>>> copyright.
> >>>>
> >>>> Steve> I believe the license in these files is a byproduct of
> copy/paste.
> >>>> Do you want to keep it like that of should we change it ? Would you
> prefer
> >>>> "Isomics, Inc." instead ?
> >>>>
> >>>> To get the list of files authored by Steve Pieper, the following could
> be
> >>>> done:
> >>>>
> >>>> for i in `find . -type f -path '.git' -prune -o -print`; \
> >>>>   do a=`git log --follow --format="%an" $i  | tail -n 1`; echo "$a ---
> >>>> $i"; \
> >>>> done | ack Pieper
> >>>>
> >>>> Thanks
> >>>> Jc
> >>>>
> >>>> On Sat, Jul 9, 2011 at 2:39 PM, Dominique Belhachemi <
> domibel at debian.org>
> >>>> wrote:
> >>>>>
> >>>>> Hi Jc,
> >>>>>
> >>>>> The license/copyright information for the files below is missing. Do
> >>>>> you want to add those information?
> >>>>>
> >>>>> Thanks
> >>>>> Dominique
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> ./Plugins/org.commontk.dah.core/Testing/Cpp/ctkDicomObjectLocatorCacheTest1.cpp
> >>>>>
> >>>>>
> ./Plugins/org.commontk.dah.core/Testing/Cpp/ctkDicomAppHostingTypesTest1.cpp
> >>>>>
> >>>>>
> ./Plugins/org.commontk.qtmobility.service/ctkQtMobilityServiceActivator_p.h
> >>>>>
> >>>>>
> ./Plugins/org.commontk.qtmobility.service/ctkQtMobilityServiceActivator.cpp
> >>>>> ./Plugins/org.commontk.eventbus/ctkEventBusImpl_p.h
> >>>>> ./Plugins/org.commontk.eventbus/ctkEventBusImpl.cpp
> >>>>> ./Plugins/org.commontk.eventbus/ctkEventBusPlugin_p.h
> >>>>> ./Plugins/org.commontk.eventbus/ctkEventHandlerWrapper_p.h
> >>>>> ./Plugins/org.commontk.eventbus/ctkEventBusPlugin.cpp
> >>>>
> >>>> => Done
> >>>>
> >>>>>
> >>>>> ./Libs/Visualization/VTK/Core/vtkLightBoxRendererManager.h
> >>>>>
> >>>>>
> >>>>>
> ./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectEventsObserverTest1.cpp
> >>>>>
> >>>>>
> ./Libs/Visualization/VTK/Core/Testing/Cpp/vtkLightBoxRendererManagerTest1.cpp
> >>>>> ./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectTestHelper.cpp
> >>>>> ./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKConnectionTest1.cpp
> >>>>> ./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectTestHelper.h
> >>>>> ./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectTest1.cpp
> >>>>> ./Libs/Visualization/VTK/Core/vtkLightBoxRendererManager.cpp
> >>>>
> >>>> => Done
> >>>>
> >>>>
> >>>>>
> >>>>> ./Libs/Scripting/Python/Core/Python/qt/__init__.py
> >>>>
> >>>> => No license added ... not sure it if make sens to add one ...
> >>>>
> >>>>>
> >>>>> ./Libs/Core/CMake/TestBFD/TestBFD.cpp
> >>>>>
> >>>>> ./Libs/Core/ctkCommandLineParser.cpp
> >>>>>
> >>>>> ./Libs/Core/Testing/Cpp/ctkBinaryFileDescriptorTestHelper.cpp
> >>>>> ./Libs/Core/Testing/Cpp/ctkCommandLineParserTest1.cpp
> >>>>> ./Libs/Core/ctkPimpl.h
> >>>>> ./Libs/Core/ctkCommandLineParser.h
> >>>>
> >>>> => Done
> >>>>
> >>>>>
> >>>>> ./Libs/DICOM/Widgets/ctkDICOMQueryWidget.cpp
> >>>>> ./Libs/DICOM/Widgets/Testing/Cpp/ctkDICOMImageTest1.cpp
> >>>>> ./Libs/DICOM/Core/ctkDICOMPersonName.h
> >>>>> ./Libs/DICOM/Core/ctkDICOMDataset.cpp
> >>>>> ./Libs/DICOM/Core/Testing/Cpp/ctkDICOMTest1.cpp
> >>>>> ./Libs/DICOM/Core/Testing/Cpp/ctkDICOMTesterTest2.cpp
> >>>>> ./Libs/DICOM/Core/Testing/Cpp/ctkDICOMTesterTest1.cpp
> >>>>> ./Libs/DICOM/Core/ctkDICOMPersonName.cpp
> >>>>
> >>>> => Done
> >>>>
> >>>>>
> >>>>> ./Applications/Testing/Cpp/ctkDICOMApplicationTest1.cpp
> >>>>>
> >>>>> ./Applications/ctkSimplePythonShell/ctkSimplePythonShellMain.cpp
> >>>>> ./Applications/ctkSimplePythonShell/ctkSimplePythonQtDecorators.h
> >>>>> ./Applications/ctkSimplePythonShell/ctkTestWrappedQInvokable.h
> >>>>> ./Applications/ctkSimplePythonShell/ctkSimplePythonManager.h
> >>>>> ./Applications/ctkSimplePythonShell/ctkTestWrappedQListOfVTKObject.h
> >>>>
> >>>> => Done
> >>>>
> >>>>>
> >>>>>
> ./Applications/ctkSimplePythonShell/Testing/Python/derivedQWidgetTest.py
> >>>>>
> ./Applications/ctkSimplePythonShell/Testing/Python/wrappedVTKSlotTest.py
> >>>>>
> >>>>>
> ./Applications/ctkSimplePythonShell/Testing/Python/wrappedQPropertyTest.py
> >>>>> ./Applications/ctkSimplePythonShell/Testing/Python/vtkPythonSmoke.py
> >>>>>
> >>>>>
> ./Applications/ctkSimplePythonShell/Testing/Python/wrappedQInvokableTest.py
> >>>>> ./Applications/ctkSimplePythonShell/Testing/Python/wrappedSlotTest.py
> >>>>> ./Applications/ctkSimplePythonShell/Testing/Python/ctkWidgetsTest.py
> >>>>>
> >>>>>
> ./Applications/ctkSimplePythonShell/Testing/Python/wrappedVTKQInvokableTest.py
> >>>>
> >>>> => No license added ... not sure it if make sens to add one ...
> >>>>
> >>>>>
> >>>>> ./Applications/ctkSimplePythonShell/ctkTestWrappedSlot.h
> >>>>> ./Applications/ctkSimplePythonShell/ctkTestWrappedVTKSlot.h
> >>>>> ./Applications/ctkSimplePythonShell/ctkTestWrappedQProperty.h
> >>>>> ./Applications/ctkSimplePythonShell/Python/ctkSimplePythonShell.py
> >>>>> ./Applications/ctkSimplePythonShell/ctkTestWrappedVTKQInvokable.h
> >>>>
> >>>> => Done
> >>>>>
> >>>>>
> >>>>> On Sat, Jul 9, 2011 at 11:52 AM, Jean-Christophe Fillion-Robin
> >>>>> <jchris.fillionr at kitware.com> wrote:
> >>>>> > Hi Dominique,
> >>>>> >
> >>>>> > Please review the following topic:
> >>>>> >   https://github.com/jcfr/CTK/compare/master...fix-license-header
> >>>>> >
> >>>>> > 788f261 Use URL to refer to ParaView license version 1.2
> >>>>> > d4b55ab Fix indent in "Module" attribute associated with Paraview
> >>>>> > license
> >>>>> > header
> >>>>> > 681c958 ctkBinaryFileDescriptor - Remove BWH Copyright year and fix
> >>>>> > indent
> >>>>> > 20cc5c8 Update license header associated with
> ctkVTKThumbnailViewTest1
> >>>>> > 56041fa Update license header associated with PythonQtDecorators
> >>>>> >
> >>>>> > Thanks
> >>>>> > Jc
> >>>>> >
> >>>>> >
> >>>>> >
> >>>>> > On Sat, Jul 9, 2011 at 11:35 AM, Stephen Aylward
> >>>>> > <stephen.aylward at kitware.com> wrote:
> >>>>> >>
> >>>>> >> Hi Dominique,
> >>>>> >>
> >>>>> >> Thanks for asking and checking the files.
> >>>>> >>
> >>>>> >> All of CTK is suppose to be under the Apache 2.0 license.   If you
> >>>>> >> find files with any other licence, please let us know.   We will
> fix
> >>>>> >> them immediately.
> >>>>> >>
> >>>>> >> Regarding the holder of the copyright - I believe we decided that
> >>>>> >> there would be no single copyright holder for CTK.  The files are
> >>>>> >> held
> >>>>> >> by the individual contributors and/or their institutions.   This
> is
> >>>>> >> not how I would prefer things, because it creates an impression of
> >>>>> >> complex ownership (whereas the Apache license assures the code
> will
> >>>>> >> always be free for commercial and non-commercial use, and without
> >>>>> >> patent restrictions to the best of our knowledge).
> >>>>> >>
> >>>>> >> The CTK members should probably re-address copyright assignments.
>   I
> >>>>> >> suggest we have the assignment go to the Insight Software
> Consortium
> >>>>> >> (ISC) or some other independent entity.   Hans Johnson at U of
> Iowa
> >>>>> >> is
> >>>>> >> the current president of the ISC, and he could ask the ISC board
> to
> >>>>> >> accept CTK as an ISC-sponsored toolkit.   More info on the ISC is
> at:
> >>>>> >> http://insightsoftwareconsortium.org/
> >>>>> >>
> >>>>> >> Stephen
> >>>>> >>
> >>>>> >>
> >>>>> >>
> >>>>> >> On Sat, Jul 9, 2011 at 11:14 AM, Dominique Belhachemi
> >>>>> >> <domibel at debian.org> wrote:
> >>>>> >> > Hi,
> >>>>> >> >
> >>>>> >> > I try to figure out whether or not the CTK source code can be
> >>>>> >> > distributed. Now I am having a couple of questions.
> >>>>> >> >
> >>>>> >> > - Some files in the CTK repository are covered by the ParaView
> >>>>> >> > license
> >>>>> >> > version 1.2. Is it possible to add the referenced file
> >>>>> >> > 'License_v1.2.txt' to the repository?
> >>>>> >> >
> >>>>> >> > - The Slicer license is missing as well. I found some statements
> >>>>> >> > which
> >>>>> >> > points to dead links:
> >>>>> >> >  "See Doc/copyright/copyright.txt
> >>>>> >> >  or http://www.slicer.org/copyright/copyright.txt for details."
> >>>>> >> >
> >>>>> >> > - Who is the main copyright holder of CTK?
> >>>>> >> >
> >>>>> >> > Thanks
> >>>>> >> > Dominique
> >>>>> >> > _______________________________________________
> >>>>> >> > Ctk-developers mailing list
> >>>>> >> > Ctk-developers at commontk.org
> >>>>> >> >
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
> >>>>> >> >
> >>>>> >>
> >>>>> >>
> >>>>> >>
> >>>>> >> --
> >>>>> >>
> >>>>> >> ==============================
> >>>>> >> Stephen R. Aylward, Ph.D.
> >>>>> >> Director of Medical Imaging Research
> >>>>> >> Kitware, Inc. - North Carolina Office
> >>>>> >> http://www.kitware.com
> >>>>> >> stephen.aylward (Skype)
> >>>>> >> (919) 969-6990 x300
> >>>>> >> _______________________________________________
> >>>>> >> Ctk-developers mailing list
> >>>>> >> Ctk-developers at commontk.org
> >>>>> >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
> >>>>> >
> >>>>> >
> >>>>> >
> >>>>> > --
> >>>>> > +1 919 869 8849
> >>>>> >
> >>>>> >
> >>>>> _______________________________________________
> >>>>> Ctk-developers mailing list
> >>>>> Ctk-developers at commontk.org
> >>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> +1 919 869 8849
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> +1 919 869 8849
> >>>
> >>
> >>
> >>
> >> --
> >> +1 919 869 8849
> >>
> >>
> >> _______________________________________________
> >> Ctk-developers mailing list
> >> Ctk-developers at commontk.org
> >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
> >>
> >>
> >
> >
> >
> > --
> > Mathieu
> >
>



-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110714/0d999fad/attachment.html>

More information about the Ctk-developers mailing list