[Ctk-developers] CTK Update to latest DCMTK

[Marco Nolden]

Hi Michael,

On 07/29/2011 10:54 AM, OFFIS DICOM Team wrote:
> Dear all,
> 
> the last two days I merged my changes regarding the adaptation of CTK to the
> latest DCMTK back in to the CTK master branch. I commited this stuff a few
> minutes ago.
> 
> I also included some fixes where I stumbled over things that seemed wrong to
> me. Further, I added minor features at some positions, e.g. color support
> for the DICOM thumbnail/image rendering. Overall, I only worked on the DICOM
> parts, 99% on /Libs/DICOM, mostly the Core part.
> 
great work, thank you.

> I also changed the repository location in the superbuild to fetch DCMTK from
> the official OFFIS repository at http://git.dcmtk.org/dcmtk.git . That works
> for me here.

It works, but it is rather slow, takes about 10 minutes to clone from
DKFZ. I would also prefer to have an option to use an official release
of DCMTK, since we do that in MITK and also use CTK there. I already
commented on github, overlapping with this email, so I post the link
here, maybe the others could also comment on that topic:

https://github.com/commontk/CTK/commit/1414293aec6c76bc5788e3ade9979150974bc568#commitcomment-502670

> 
> Nevertheless, since these are my first actual commits to CTK, I expect that
> I have done some mistakes, hopefully not too many serious ones ;) Please
> tell me and I will correct that as soon as possible.
> 
> Best regards,
> Michael
> 
Everything looks fine to me. There is just one "Merge remote-tracking
branch 'origin/master'" commit we try to avoid in CTK by rebasing, but
that was probably just an accident.

Best regards, thanks again

Marco


-- 
----------------------------------------------------------------------
Dipl.-Inform. Med. Marco Nolden
Deutsches Krebsforschungszentrum       (German Cancer Research Center)
Div. Medical & Biological Informatics          Tel: (+49) 6221-42 2325
Im Neuenheimer Feld 280                        Fax: (+49) 6221-42 2345
D-69120 Heidelberg                             eMail: M.Nolden at dkfz.de