[Ctk-developers] experiments with the official dcmtk 3.6.0

[Mathieu Malaterre]

Hi Dominique,

  This issue is only visible for people not using SuperBuild. When
using SuperBuild all kinds of include directories are added which are
not added in 'system' include of dcmtk.
  Whoever merge the final dcmtk 3.6.0 patch upstream should give also
a try without superbuild, that would be really neat !

2cts

On Mon, Jul 25, 2011 at 4:31 PM, Dominique Belhachemi
<domibel at debian.org> wrote:
> Hi Mathieu,
>
> this looks good. I also noticed your header patches like
>
> -#include "dcmimage.h"
> +#include <dcmtk/dcmimgle/dcmimage.h>
>
> This could be applied upstream too. Right now they include all kind of
> dcmtk subdirectories via CMake.
>
> Dominique
>
>
> On Mon, Jul 25, 2011 at 3:29 AM, Mathieu Malaterre
> <mathieu.malaterre at gmail.com> wrote:
>> Dominique,
>>
>>  I did gave it a try back in March:
>>
>> https://github.com/malaterre/CTK/tree/dcmtk_compilation
>>
>>  From the top of my head the transition pre/post 2009 keywords went
>> fine. However I failed to realize the transition for the new API of
>> DcmSCU.
>>
>> HTH
>>
>> On Sat, Jul 23, 2011 at 10:58 PM, Dominique Belhachemi
>> <domibel at debian.org> wrote:
>>> Hi,
>>>
>>> I was trying to use CTK together with DCMTK 3.6.0. But I am running
>>> into some issues here. It seems that dcmtk/dcmdata/dcdeftag.h has
>>> changed a lot.
>>>
>>> [ 94%] Building CXX object
>>> Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMIndexer.cpp.o
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp: In member
>>> function 'void ctkDICOMIndexer::addDirectory(ctkDICOMDatabase&, const
>>> QString&, const QString&, bool, bool)':
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp:181:38:
>>> error: 'DCM_PatientsName' was not declared in this scope
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp:213:33:
>>> error: 'DCM_PatientsBirthDate' was not declared in this scope
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp:214:33:
>>> error: 'DCM_PatientsBirthTime' was not declared in this scope
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp:215:33:
>>> error: 'DCM_PatientsSex' was not declared in this scope
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp:216:33:
>>> error: 'DCM_PatientsAge' was not declared in this scope
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp:224:33:
>>> error: 'DCM_PerformingPhysiciansName' was not declared in this scope
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMIndexer.cpp:225:33:
>>> error: 'DCM_ReferringPhysiciansName' was not declared in this scope
>>>
>>> There are also things like that:
>>> /tmp/buildd/ctk-0.1.0/Libs/DICOM/Core/ctkDICOMQuery.cpp:407:54: error:
>>> no matching function for call to 'DcmSCU::closeAssociation(const
>>> OFCondition&)'
>>>
>>> Are there any plans to use an official version of DCMTK 3.6.0 in the future?
>>>
>>> Thanks
>>> Dominique
>>> _______________________________________________
>>> Ctk-developers mailing list
>>> Ctk-developers at commontk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>>
>>
>>
>>
>> --
>> Mathieu
>>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>



-- 
Mathieu