[Ctk-developers] ShowStatusTextUponGoToStepSuccess workflow feature, please review

[Jean-Christophe Fillion-Robin]

Hi Daniel,

Just looked at it.

Please consider the following remarks:
 - Regarding the git commit msg. See
http://www.commontk.org/index.php/Contributing_to_CTK#Git_Commit_Style

 - Regarding the patch:
     - May be you could just add a property named ErrorTextDisabled to
ctkWorkflowGroupBox ?
    - See line 110 of ctkWorkflowGroupBox.cpp

Danielle> What do you think ?

Thanks
Jc

On Tue, Aug 16, 2011 at 12:35 PM, Daniel Haehn <haehn at bwh.harvard.edu>wrote:

> Hi,
>
> did anybody have a chance to look at it yet?
>
> Thanks,
> Daniel
>
> On Thu, Aug 11, 2011 at 1:15 PM, Daniel Haehn <haehn at bwh.harvard.edu>
> wrote:
> > Hi Devels,
> >
> > could anybody please review the following topic:
> >
> >
> https://github.com/haehn/CTK/commits/add-ShowStatusTextUponGoToStepSuccess-workflow-feature
> >
> > I added a property to be able to disable the Status Text update on the
> > origin step when a GoToStep(..)-call of a ctkWorkflow succeeds.
> >
> > Looking forward to your feedback..
> >
> > Daniel
> >
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>



-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110816/f7365e1f/attachment.htm>