[Ctk-developers] Coming changes in External project organization

[Sascha Zelzer]

Ah, all right. Option 1) then sounds good to me.

Thanks,
Sascha

On 04/11/2011 06:59 PM, Jean-Christophe Fillion-Robin wrote:
> Hi Sasha,
>
> To clarify, when I wrote:
>
> <CTK-SUPERBUILD>/VTK-build
> <CTK-SUPERBUILD>/VTK-cmake/src
> <CTK-SUPERBUILD>/VTK-cmake/tmp
> <CTK-SUPERBUILD>/VTK
>
> It means:
>
> <CTK-SUPERBUILD>/VTK-build         # Build directory
> <CTK-SUPERBUILD>/VTK-cmake         # Directory where CMake store 
> timestamps, source ...
> <CTK-SUPERBUILD>/VTK               # Source directory
>
>
>
> Or should we use structure like this one instead:
>
> <CTK-SUPERBUILD>/VTK-build         # Build directory
> <CTK-SUPERBUILD>/VTK-cmake        # Directory where CMake store 
> timestamps, source ...
> <CTK-SUPERBUILD>/VTK-src                    # Source directory
>
>
> What do you think ?
>
> I would prefer option 1) since I am more use to it ... where the 
> source directory match the project name.
>
> Thanks
> Jc
>
> On Mon, Apr 11, 2011 at 12:29 PM, Sascha Zelzer 
> <s.zelzer at dkfz-heidelberg.de <mailto:s.zelzer at dkfz-heidelberg.de>> wrote:
>
>     Hi Jc,
>
>     we use a similar structure for external projects in MITK, so +1
>     from me. I would only suggest a slight modification:
>
>     Can we use
>
>     <CTK-SUPERBUILD>/VTK-src
>     <CTK-SUPERBUILD>/VTK-tmp
>
>     instead of
>
>
>     <CTK-SUPERBUILD>/VTK-cmake/src
>     <CTK-SUPERBUILD>/VTK-cmake/tmp
>
>     ?
>
>     Thanks for taking care of this,
>
>     Sascha
>
>
>     On 04/11/2011 06:21 PM, Jean-Christophe Fillion-Robin wrote:
>>     Hi Folks,
>>
>>     Using CTK as an external project in more and more project, the
>>     path length could be an issue on windows platform.
>>     Indeed, the path length on windows is limited to 260 characters. [1]
>>
>>     *What motivates this change:*
>>
>>     Such problem could arise, if, for example, your project is build
>>     in folder like:
>>
>>     "c:/Dashboards/Nightly/YourProject-Superbuild-Qt-PythonQt-With-Tcl-NoCLI-nightly"
>>
>>
>>     "YourProject" relying also on Superbuild and using CTK as an
>>     external project .. will fail to build for some obscure reason.
>>
>>
>>     *Current CTK organization:*
>>
>>     Currently the project are organized as described below:
>>
>>     <CTK-SUPERBUILD>/CMakeExternals/Build/VTK
>>     <CTK-SUPERBUILD>/CMakeExternals/Build/DCMTK
>>     ...
>>     <CTK-SUPERBUILD>/CMakeExternals/Source/VTK
>>     <CTK-SUPERBUILD>/CMakeExternals/Source/DCMTK
>>     ...
>>     <CTK-SUPERBUILD>/CMakeExternals/Download/VTK
>>     <CTK-SUPERBUILD>/CMakeExternals/Download/DCMTK
>>     ...
>>     <CTK-SUPERBUILD>/CMakeExternals/Stamp/VTK
>>     <CTK-SUPERBUILD>/CMakeExternals/Stamp/DCMTK
>>     ...
>>     <CTK-SUPERBUILD>/CTK-build
>>
>>
>>     *Solution proposed:*
>>
>>     With some minor changes, the structure would like:
>>
>>     <CTK-SUPERBUILD>/CTK-build
>>     <CTK-SUPERBUILD>/VTK
>>     <CTK-SUPERBUILD>/VTK-build
>>     <CTK-SUPERBUILD>/VTK-cmake/src
>>     <CTK-SUPERBUILD>/VTK-cmake/tmp
>>     <CTK-SUPERBUILD>/VTK
>>     <CTK-SUPERBUILD>/DCMTK-build
>>     <CTK-SUPERBUILD>/DCMTK-cmake/src
>>     <CTK-SUPERBUILD>/DCMTK-cmake/tmp
>>
>>     Pros:
>>       - Doing so will decrease the average length of external project
>>     path associated with CTK.
>>       - If needed, make the "cleaning" of external project easier "rm
>>     VTK*" instead of "cd" in each CMakeExternals sub folders ..
>>
>>     *Action plan:*
>>
>>     I plan to implement and test this change this coming week.
>>
>>     That improvment shouldn't cause any issue, but If it happens to
>>     be a problem within your project and you require some time to
>>     figure out a fix or would like to contact me. Please, do it
>>     before the end of the week :)
>>
>>     Next week, following your comments I will then integrate the
>>     change to CTK master.
>>
>>     Thanks
>>     Jc
>>
>>     [1]
>>     http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29.aspx#maxpath
>>
>>     -- 
>>     +1 919 869 8849 <tel:%2B1%20919%20869%208849>
>>
>
>
>     _______________________________________________
>     Ctk-developers mailing list
>     Ctk-developers at commontk.org <mailto:Ctk-developers at commontk.org>
>     http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
>
>
> -- 
> +1 919 869 8849
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110411/78d4bafe/attachment.html>