[Ctk-developers] Proposes changes - Directory renaming, removing, etc ...
Sascha Zelzer
s.zelzer at dkfz-heidelberg.de
Mon Apr 25 09:39:26 UTC 2011
Hi,
On 04/22/2011 11:51 PM, Jean-Christophe Fillion-Robin wrote:
> Hi Folks,
>
> Hope everything is going well :)
>
> I will perform the following change:
>
> A) Comment the line adding CTK/Libs/ModuleDescription to CTK build
> system. This later one doesn't compile
>
> .. and I would like to perform the following changes:
>
> 1) Delete CTK/Plugins/org.commontk.cli ("Interface that allows to
> discover and manage CLI modules")
> => description is "Interface that allows to discover and manage
> CLI modules" (see servicedescriptor.xml)
> => Is that used ? Seems all classes are empty
Let's remove it. I never had time to finish it and would do it slightly
different now anyway.
>
> 2) Rename CTK/Libs/PluginFramework into CTK/Libs/Plugin/Framework
>
> 3) Move CTK/Libs/ModuleDescription into more specialized subfolder
> CTK/Libs/Plugin/Description
> => Classes would be rename into:
> ctkPluginDescription[ExecutionInterface, Parameter, ParameterGroup... ]
>
> Note also that:
> Enabling CTK_LIB_PluginDescription and CTK_LIB_PluginFramework
> could be enabled independently
>
I think I understand what you are aiming for, but I am not really happy
with the generic names. And if the two libraries are called
"CTKPluginFramework" and "CTKPluginDescription", the names suggest a
relationship where actually no relationship exists between the two
(except that they both provide some kine of "extension mechanism").
What about:
CTK/Libs/ExtensionMechanisms/PluginFramework ( will be called
libCTKPluginFramework.so )
CTK/Libs/ExtensionMechanisms/CommandLineModule ( will be called
libCTKCommandLineModule.so )
and rename the files to ctkCommandLineModule[ExecutionInterface,
Parameter, ParameterGroup... ] ?
Let's also see what J2 and Xavier think.
>
> 4) Move plugin "CTK/Plugins/org_commontk_slicermodule" into for
> example github.com/slicer/org_slicer_module
> <http://github.com/slicer/org_slicer_module> or some other project
> hosted on github.com/slicer <http://github.com/slicer> that could host
> all plugin and library specific to slicer.
>
I think for the CTK "Core Team", it would make things easier if
org_commontk_slicermodule would stay where it is, for the time being
(what would be your motivation for moving it?). I am thinking about
possible refactorings and test and integration scenarios (other toolkits
like MITK trying to use the org_commontk_slicermodule plugin). Until the
code is "stable" the current form allows us to modify and test it more
easily.
Thanks for cleaning up, and Happy Easter (to all who celebrate it) :-)
Sascha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110425/b89f3583/attachment.htm>
More information about the Ctk-developers
mailing list