From wsales at gmail.com Wed Oct 6 14:47:46 2010 From: wsales at gmail.com (Wagner Sales) Date: Wed, 6 Oct 2010 11:47:46 -0300 Subject: [Ctk-developers] ctkRangeSlider, ctkDoubleRangeSlider and others inherited QAbstractSlider with a negative minimum value Message-ID: Hi all, After taking a look for a couple of minutes in range sliders which inherits from QAbstractSlider I see a ( i think ) problem: you cannot start setting the minimum value as a negative value. Instead, you'll needs to set minimum by QAbstractSlider::setMinimum(negative value) and after ctkRangeSlider::setMinimumValue(negative value). Only to point: this occurs in QxtSpanSlider too ( of course not the topic here )!. What can be done about this? Change the behavior? Document in the class? A warning in the method? Well, since I spent some time to found this, I think others don't need to spent too. ;) Best Regards, Wagner Sales From kikinis at bwh.harvard.edu Wed Oct 6 16:32:28 2010 From: kikinis at bwh.harvard.edu (Ron Kikinis) Date: Wed, 06 Oct 2010 12:32:28 -0400 Subject: [Ctk-developers] ctkRangeSlider, ctkDoubleRangeSlider and others inherited QAbstractSlider with a negative minimum value In-Reply-To: References: Message-ID: <4CACA49C.1070208@bwh.harvard.edu> good catch relative to Hounsfield units. On 10/6/2010 10:47 AM, Wagner Sales wrote: > Hi all, > > After taking a look for a couple of minutes in range sliders which > inherits from QAbstractSlider I see a ( i think ) problem: you cannot > start setting the minimum value as a negative value. Instead, you'll > needs to set minimum by QAbstractSlider::setMinimum(negative value) > and after ctkRangeSlider::setMinimumValue(negative value). Only to > point: this occurs in QxtSpanSlider too ( of course not the topic here > )!. What can be done about this? Change the behavior? Document in the > class? A warning in the method? Well, since I spent some time to found > this, I think others don't need to spent too. ;) > > Best Regards, > > Wagner Sales > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- Ron Kikinis, M.D., Robert Greenes Distinguished Director of Biomedical Informatics Professor of Radiology, Harvard Medical School Director, Surgical Planning Laboratory http://www.spl.harvard.edu/~kikinis From julien.finet at kitware.com Thu Oct 7 02:11:45 2010 From: julien.finet at kitware.com (Julien Finet) Date: Thu, 7 Oct 2010 04:11:45 +0200 Subject: [Ctk-developers] ctkRangeSlider, ctkDoubleRangeSlider and others inherited QAbstractSlider with a negative minimum value In-Reply-To: <4CACA49C.1070208@bwh.harvard.edu> References: <4CACA49C.1070208@bwh.harvard.edu> Message-ID: Hi Wagner, Thanks for your feedback. The behavior you encounter with ctkRangeSlider is normal, it is the exact same behavior than QSlider (or QxtSpanSlider): you can't set the value of an handle before making sure that it will be inside the slider bounds (setMinimum/setMaximum). Qt Designer solves the issue by following the order of the properties in the header of a C++ class. To have a correct behavior when using Qt Designer, the "Minimum" and "Maximum" properties (Q_PROPERTY) are defined before the "MinimumValue"/"MaximumValue" properties. I wouldn't change anything in the code. The behavior seems fine to me. I would prefer adding a warning in the comments. Feel free to submit a patch with more documentation. Otherwise, I'll do it. Thanks, Julien. On Wed, Oct 6, 2010 at 6:32 PM, Ron Kikinis wrote: > good catch relative to Hounsfield units. > > > On 10/6/2010 10:47 AM, Wagner Sales wrote: > >> Hi all, >> >> After taking a look for a couple of minutes in range sliders which >> inherits from QAbstractSlider I see a ( i think ) problem: you cannot >> start setting the minimum value as a negative value. Instead, you'll >> needs to set minimum by QAbstractSlider::setMinimum(negative value) >> and after ctkRangeSlider::setMinimumValue(negative value). Only to >> point: this occurs in QxtSpanSlider too ( of course not the topic here >> )!. What can be done about this? Change the behavior? Document in the >> class? A warning in the method? Well, since I spent some time to found >> this, I think others don't need to spent too. ;) >> >> Best Regards, >> >> Wagner Sales >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> > > > -- > Ron Kikinis, M.D., > Robert Greenes Distinguished Director of Biomedical Informatics > Professor of Radiology, Harvard Medical School > Director, Surgical Planning Laboratory > http://www.spl.harvard.edu/~kikinis > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From wsales at gmail.com Thu Oct 14 23:02:37 2010 From: wsales at gmail.com (Wagner Sales) Date: Thu, 14 Oct 2010 20:02:37 -0300 Subject: [Ctk-developers] ctkRangeSlider, ctkDoubleRangeSlider and others inherited QAbstractSlider with a negative minimum value In-Reply-To: References: <4CACA49C.1070208@bwh.harvard.edu> Message-ID: Hi Julien, I think the behavior are fine too. But a comment will save time from newbies ( or may be not a newbie too ;) ). Thanks, Wagner Sales 2010/10/6 Julien Finet : > Hi Wagner, > Thanks for your feedback. The behavior you encounter with ctkRangeSlider is > normal, it is the exact same behavior than QSlider (or?QxtSpanSlider): you > can't set the value of an handle before making sure that it will be inside > the slider bounds (setMinimum/setMaximum). > Qt Designer solves the issue by following the order of the properties in the > header of a C++ class. > To have a correct behavior when using Qt Designer, the "Minimum" and > "Maximum" properties (Q_PROPERTY) are defined before the > "MinimumValue"/"MaximumValue" properties. > I wouldn't change anything in the code. The behavior seems fine to me. I > would prefer adding a warning in the comments. > Feel free to submit a patch with more documentation. Otherwise, I'll do it. > Thanks, > Julien. > On Wed, Oct 6, 2010 at 6:32 PM, Ron Kikinis wrote: >> >> good catch relative to Hounsfield units. >> >> On 10/6/2010 10:47 AM, Wagner Sales wrote: >>> >>> Hi all, >>> >>> After taking a look for a couple of minutes in range sliders which >>> inherits from QAbstractSlider I see a ( i think ) problem: you cannot >>> start setting the minimum value as a negative value. Instead, you'll >>> needs to set minimum by QAbstractSlider::setMinimum(negative value) >>> and after ctkRangeSlider::setMinimumValue(negative value). Only to >>> point: this occurs in QxtSpanSlider too ( of course not the topic here >>> )!. What can be done about this? Change the behavior? Document in the >>> class? A warning in the method? Well, since I spent some time to found >>> this, I think others don't need to spent too. ;) >>> >>> Best Regards, >>> >>> Wagner Sales >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> >> -- >> Ron Kikinis, M.D., >> Robert Greenes Distinguished Director of Biomedical Informatics >> Professor of Radiology, Harvard Medical School >> Director, Surgical Planning Laboratory >> http://www.spl.harvard.edu/~kikinis >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > From s.zelzer at dkfz-heidelberg.de Fri Oct 15 14:31:01 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Fri, 15 Oct 2010 16:31:01 +0200 Subject: [Ctk-developers] Build system changes concerning include path handling Message-ID: <4CB865A5.8030202@dkfz-heidelberg.de> Hi Folks, I plan to push the build-system changes I worked on during the Barcelona hackfest to CTK/master later on this day. As a reminder, the changes improve the handling of include path dependencies such that every Lib/App/Plugin sees only the include dirs from its dependencies, instead of the "everybody sees everything" approach. Also inheriting the include dirs from external dependencies (on which a lib could depend through another dependency transitively) is now handled properly. Although I hope that the transition will be smooth and transparent, please send me an email if you are running into include path or linking errors after updating your repository (please try a clean rebuild first). Thanks, Sascha From jchris.fillionr at kitware.com Fri Oct 15 17:53:59 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 15 Oct 2010 13:53:59 -0400 Subject: [Ctk-developers] Build system changes concerning include path handling In-Reply-To: <4CB865A5.8030202@dkfz-heidelberg.de> References: <4CB865A5.8030202@dkfz-heidelberg.de> Message-ID: Hi Sasha, Sounds great ! Could you publish your changes to a branch on your fork: http://github.com/saschazelzer/CTK ? Would be great to have a look :) Thks Jc On Fri, Oct 15, 2010 at 10:31 AM, Sascha Zelzer wrote: > Hi Folks, > > I plan to push the build-system changes I worked on during the Barcelona > hackfest to CTK/master later on this day. As a reminder, the changes improve > the handling of include path dependencies such that every Lib/App/Plugin > sees only the include dirs from its dependencies, instead of the "everybody > sees everything" approach. Also inheriting the include dirs from external > dependencies (on which a lib could depend through another dependency > transitively) is now handled properly. > > Although I hope that the transition will be smooth and transparent, please > send me an email if you are running into include path or linking errors > after updating your repository (please try a clean rebuild first). > > Thanks, > Sascha > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From s.zelzer at dkfz-heidelberg.de Fri Oct 15 20:30:07 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Fri, 15 Oct 2010 22:30:07 +0200 Subject: [Ctk-developers] Build system changes concerning include path handling In-Reply-To: References: <4CB865A5.8030202@dkfz-heidelberg.de> Message-ID: <4CB8B9CF.9090503@dkfz-heidelberg.de> Hi Jc, sorry, I already pushed the commits to master. The changes are essentially what we discussed during the hackfest. I just now branched of from the last commit before the relevant changes and cherry-picked them into the branch, so you can have a better look: http://github.com/saschazelzer/CTK/tree/include_deps - Basically, I create a third input file for the "DGraph" Utility called "DGraphInput-alldep-withext.txt" containing the whole dependency information including external projects. - In ctkMacroValidateBuildOptions, for each CTK sub-project (App, Lib, Plugin) a variable named ${project_name}_DEPENDENCIES is set to contain a list of project names on which ${project_name} depends on (including external projects). - The CMake files in the folder "CMakeExternals" have been modified such that they set two variables, containing a list of include directories (or variable names pointing to include directories, which are set by a find_package call) and the argument to the find_package command - The toplevel CMakeLists.txt file now calls "find_package" for all enabled external projects (if the corresponding variable containing the find_package argument is set), instead of the libraries/plugins themselves. This way, all the variables pointing to specific include directories of external projects are set before the invocation of the ctkMacroCreate* macros. - The ctkMacroCreate* macros loop over the ${project_name}_DEPENDENCIES list and add only those to the current projects include paths. If you find that something is broken, I will try to fix it ASAP. Best, Sascha On 10/15/2010 07:53 PM, Jean-Christophe Fillion-Robin wrote: > Hi Sasha, > > Sounds great ! > > Could you publish your changes to a branch on your fork: > http://github.com/saschazelzer/CTK ? > > Would be great to have a look :) > > Thks > Jc > > On Fri, Oct 15, 2010 at 10:31 AM, Sascha Zelzer > > wrote: > > Hi Folks, > > I plan to push the build-system changes I worked on during the > Barcelona hackfest to CTK/master later on this day. As a reminder, > the changes improve the handling of include path dependencies such > that every Lib/App/Plugin sees only the include dirs from its > dependencies, instead of the "everybody sees everything" approach. > Also inheriting the include dirs from external dependencies (on > which a lib could depend through another dependency transitively) > is now handled properly. > > Although I hope that the transition will be smooth and > transparent, please send me an email if you are running into > include path or linking errors after updating your repository > (please try a clean rebuild first). > > Thanks, > Sascha > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > > > > -- > Phone: 1-518-836-2174 > Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From haehn at bwh.harvard.edu Mon Oct 18 14:22:21 2010 From: haehn at bwh.harvard.edu (Daniel Haehn) Date: Mon, 18 Oct 2010 10:22:21 -0400 Subject: [Ctk-developers] [slicer-devel] Slicer4 Dashboard - CTK build error In-Reply-To: <02c8380b0d2bcd0f9aaeaa9ce5e58d80@bwh.harvard.edu> References: <02c8380b0d2bcd0f9aaeaa9ce5e58d80@bwh.harvard.edu> Message-ID: The same happens on my local machine. In file included from /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.cxx:21: /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.h:25:33: error: ctkIconEnginePlugin.h: No such file or directory Is this connected to recent changes in CTK? Thanks, Daniel On Oct 17, 2010, at 5:03 PM, Daniel Haehn wrote: > Hi guys, > > there seems to be a build error from CTK. > > http://cdash.org/CDash/index.php?project=Slicer4 > > Thanks, > Daniel > > _______________________________________________ > slicer-devel mailing list > slicer-devel at bwh.harvard.edu > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > To unsubscribe: send email to slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the subject From julien.finet at kitware.com Mon Oct 18 14:26:34 2010 From: julien.finet at kitware.com (Julien Finet) Date: Mon, 18 Oct 2010 10:26:34 -0400 Subject: [Ctk-developers] [slicer-devel] Slicer4 Dashboard - CTK build error In-Reply-To: References: <02c8380b0d2bcd0f9aaeaa9ce5e58d80@bwh.harvard.edu> Message-ID: Hi Daniel, Thanks for the report, a lot of changes happened last Friday that broke the superbuild with Slicer. We are on it and will let everyone know when it will be fixed (soon hopefully :-) ). Sorry for the inconvenience and thanks for your patience, Julien. On Mon, Oct 18, 2010 at 10:22 AM, Daniel Haehn wrote: > The same happens on my local machine. > > In file included from > /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.cxx:21: > /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.h:25:33: > error: ctkIconEnginePlugin.h: No such file or directory > > Is this connected to recent changes in CTK? > > Thanks, > Daniel > > On Oct 17, 2010, at 5:03 PM, Daniel Haehn wrote: > > > Hi guys, > > > > there seems to be a build error from CTK. > > > > http://cdash.org/CDash/index.php?project=Slicer4 > > > > Thanks, > > Daniel > > > > _______________________________________________ > > slicer-devel mailing list > > slicer-devel at bwh.harvard.edu > > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > > To unsubscribe: send email to > slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the > subject > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Mon Oct 18 15:06:04 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Mon, 18 Oct 2010 11:06:04 -0400 Subject: [Ctk-developers] Remarks related to "include_deps" topic Message-ID: Hi Folks, Last week, Sasha pushed a set of change related to "include_deps" topic. See: - http://public.kitware.com/pipermail/ctk-developers/2010-October/000356.html - http://github.com/saschazelzer/CTK/commits/include_deps A small glitch has been introduced, the include directories associated with both CTK libraries and external projects weren't passed when configuring CTKConfig.cmake This was causing problem when project (i.e Slicer4) were built. The following commit: http://github.com/commontk/CTK/commit/2de135a0f8510b92a014f6a10049b380c4d93598 fixed the problem. As mentionned in the associated commit message, the solution is suboptimal but will allow project relying on CTK to successfully built. Thks Jc -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Mon Oct 18 15:11:19 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Mon, 18 Oct 2010 11:11:19 -0400 Subject: [Ctk-developers] [slicer-devel] Slicer4 Dashboard - CTK build error In-Reply-To: References: <02c8380b0d2bcd0f9aaeaa9ce5e58d80@bwh.harvard.edu> Message-ID: Hi Daniel, As mentioned here: http://public.kitware.com/pipermail/ctk-developers/2010-October/000359.html The issue has been resolved and Slicer4 should build smoothly. Thks for your patience Jc On Mon, Oct 18, 2010 at 10:22 AM, Daniel Haehn wrote: > The same happens on my local machine. > > In file included from > /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.cxx:21: > /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.h:25:33: > error: ctkIconEnginePlugin.h: No such file or directory > > Is this connected to recent changes in CTK? > > Thanks, > Daniel > > On Oct 17, 2010, at 5:03 PM, Daniel Haehn wrote: > > > Hi guys, > > > > there seems to be a build error from CTK. > > > > http://cdash.org/CDash/index.php?project=Slicer4 > > > > Thanks, > > Daniel > > > > _______________________________________________ > > slicer-devel mailing list > > slicer-devel at bwh.harvard.edu > > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > > To unsubscribe: send email to > slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the > subject > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From haehn at bwh.harvard.edu Mon Oct 18 15:29:27 2010 From: haehn at bwh.harvard.edu (Daniel Haehn) Date: Mon, 18 Oct 2010 11:29:27 -0400 Subject: [Ctk-developers] [slicer-devel] Slicer4 Dashboard - CTK build error In-Reply-To: References: <02c8380b0d2bcd0f9aaeaa9ce5e58d80@bwh.harvard.edu> Message-ID: <7DA5ED02-050E-41AA-877F-C80941D22D80@bwh.harvard.edu> Great job, guys! Slicer4 compiles again! Thank you, Daniel On Oct 18, 2010, at 11:11 AM, Jean-Christophe Fillion-Robin wrote: > Hi Daniel, > > As mentioned here: http://public.kitware.com/pipermail/ctk-developers/2010-October/000359.html > > The issue has been resolved and Slicer4 should build smoothly. > > Thks for your patience > Jc > > On Mon, Oct 18, 2010 at 10:22 AM, Daniel Haehn wrote: > The same happens on my local machine. > > In file included from /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.cxx:21: > /Users/daniel/SLICER/QT_TRUNK/Slicer4/Base/QTGUI/qSlicerIconEnginePlugin.h:25:33: error: ctkIconEnginePlugin.h: No such file or directory > > Is this connected to recent changes in CTK? > > Thanks, > Daniel > > On Oct 17, 2010, at 5:03 PM, Daniel Haehn wrote: > > > Hi guys, > > > > there seems to be a build error from CTK. > > > > http://cdash.org/CDash/index.php?project=Slicer4 > > > > Thanks, > > Daniel > > > > _______________________________________________ > > slicer-devel mailing list > > slicer-devel at bwh.harvard.edu > > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > > To unsubscribe: send email to slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the subject > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > > > -- > Phone: 1-518-836-2174 > Ext: 304 From s.zelzer at dkfz-heidelberg.de Mon Oct 18 15:59:22 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 18 Oct 2010 17:59:22 +0200 Subject: [Ctk-developers] Remarks related to "include_deps" topic In-Reply-To: References: Message-ID: <4CBC6EDA.9050009@dkfz-heidelberg.de> Jc, thanks for taking care of this issue! - Sascha On 10/18/2010 05:06 PM, Jean-Christophe Fillion-Robin wrote: > Hi Folks, > > Last week, Sasha pushed a set of change related to "include_deps" topic. > See: > - > http://public.kitware.com/pipermail/ctk-developers/2010-October/000356.html > - http://github.com/saschazelzer/CTK/commits/include_deps > > A small glitch has been introduced, the include directories associated > with both CTK libraries and external projects weren't passed > when configuring CTKConfig.cmake > This was causing problem when project (i.e Slicer4) were built. > > The following commit: > http://github.com/commontk/CTK/commit/2de135a0f8510b92a014f6a10049b380c4d93598 > fixed the problem. > As mentionned in the associated commit message, the solution is > suboptimal but will allow project relying on CTK to successfully built. > > Thks > Jc > > > -- > Phone: 1-518-836-2174 > Ext: 304 From pieper at bwh.harvard.edu Wed Oct 20 17:27:32 2010 From: pieper at bwh.harvard.edu (Steve Pieper) Date: Wed, 20 Oct 2010 13:27:32 -0400 Subject: [Ctk-developers] gimias 1.2 and command line modules Message-ID: <4CBF2684.70908@bwh.harvard.edu> Congrats to Xavi and the team at UPF on the release of Gimias 1.2! This is a great CTK interoperability success story as it now ships with modules developed for slicer :) http://www.commontk.org/index.php/News#2010 From jchris.fillionr at kitware.com Thu Oct 21 17:56:21 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Thu, 21 Oct 2010 13:56:21 -0400 Subject: [Ctk-developers] Export header file now starts with "ctk" lower case Message-ID: Hi Folks, Following commit c8fd5a716e24, export header file now start with "ctk" lower case. It means code looking like: ... // CTK includes #include "ctkTransferFunction.h" #include "*CTKWidgetsExport*.h" ... has been changed into: ... // CTK includes #include "ctkTransferFunction.h" #include "*ctkWidgetsExport*.h" ... The impact on your current work could potentially be: - If you write new classes, make sure to include the lower case version. - If you merge a topic branch started prior to commit c8fd5a716e24, you may have to resolve conflicts If you don't already know it, note that the file "ctkExport.h is automatically configured for you using CTK/Libs/ctkExport.h.in Thks Jc -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From s.zelzer at Dkfz-Heidelberg.de Fri Oct 22 13:27:42 2010 From: s.zelzer at Dkfz-Heidelberg.de (Zelzer Sascha) Date: Fri, 22 Oct 2010 15:27:42 +0200 Subject: [Ctk-developers] Merging branch "dah" into master Message-ID: Hi Folks, CTK has seen many improvements since the Barcelona hackfest and I would like to merge the dah branch "dicom application hosting" into master to take advantage of the new features. The advantages would be - The dah code would benefit from future refactorings taking place in the master branch - Make use of proper include path inheritance between plugins and libraries - Take advantage of improvements inside ctkPluginFramework - Improve the visibility of the dah plugins to the community After the merge, developers could still hack on new features in their own branches inside their CTK forks. I would take care of adapting the dah code and cleaning up some memory management issues. Do you have any concerns / remarks? Thanks, Sascha -------------- next part -------------- An HTML attachment was scrubbed... URL: From julien.finet at kitware.com Fri Oct 22 13:43:27 2010 From: julien.finet at kitware.com (Julien Finet) Date: Fri, 22 Oct 2010 09:43:27 -0400 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: References: Message-ID: Hi Sascha, It seems like a good idea to "publish" the dah branch ! I've a little request though (as you asked for it :-) ). Last time I checked, there was not many unit tests (2?) for all the DICOM classes. I think that DAH would greatly benefit from some more testing. I believe it's a good timing to add tests (if you want to merge it means the design is quite stable meaning tests can be written :-) ). My 2 cents, Julien. On Fri, Oct 22, 2010 at 9:27 AM, Zelzer Sascha wrote: > Hi Folks, > > > > CTK has seen many improvements since the Barcelona hackfest and I would > like to merge the dah branch ?dicom application hosting? into master to take > advantage of the new features. The advantages would be > > > > - The dah code would benefit from future refactorings taking > place in the master branch > > - Make use of proper include path inheritance between plugins and > libraries > > - Take advantage of improvements inside ctkPluginFramework > > - Improve the visibility of the dah plugins to the community > > > > After the merge, developers could still hack on new features in their own > branches inside their CTK forks. > > > > I would take care of adapting the dah code and cleaning up some memory > management issues. > > > > Do you have any concerns / remarks? > > > > Thanks, > > > > Sascha > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Oct 22 13:46:16 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 22 Oct 2010 09:46:16 -0400 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: References: Message-ID: Sounds great to me :) Would it possible to: - add a little bit more documentation - create a simple wiki page on commontk.org. (Or move this oneto a more obvious location) May be in the Tools section ? We could also create a plugin section ? - increase testing On my side, I will make sure the documentation is regenerated on a daily basis. Thks Jc On Fri, Oct 22, 2010 at 9:27 AM, Zelzer Sascha wrote: > Hi Folks, > > > > CTK has seen many improvements since the Barcelona hackfest and I would > like to merge the dah branch ?dicom application hosting? into master to take > advantage of the new features. The advantages would be > > > > - The dah code would benefit from future refactorings taking > place in the master branch > > - Make use of proper include path inheritance between plugins and > libraries > > - Take advantage of improvements inside ctkPluginFramework > > - Improve the visibility of the dah plugins to the community > > > > After the merge, developers could still hack on new features in their own > branches inside their CTK forks. > > > > I would take care of adapting the dah code and cleaning up some memory > management issues. > > > > Do you have any concerns / remarks? > > > > Thanks, > > > > Sascha > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From s.zelzer at Dkfz-Heidelberg.de Fri Oct 22 14:30:12 2010 From: s.zelzer at Dkfz-Heidelberg.de (Zelzer Sascha) Date: Fri, 22 Oct 2010 16:30:12 +0200 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: References: Message-ID: Hi Julien, testing is of course an important topic :) The dah branch is not related to "classic DICOM features" , could you explain to which DICOM classes you are referring to? Currently (if I am not wrong), the dah code does not have any unit tests. The could should still be seen as a proof of concept. Sascha Von: Julien Finet [mailto:julien.finet at kitware.com] Gesendet: Freitag, 22. Oktober 2010 15:43 An: Zelzer Sascha Cc: ctk-developers at commontk.org Betreff: Re: [Ctk-developers] Merging branch "dah" into master Hi Sascha, It seems like a good idea to "publish" the dah branch ! I've a little request though (as you asked for it :-) ). Last time I checked, there was not many unit tests (2?) for all the DICOM classes. I think that DAH would greatly benefit from some more testing. I believe it's a good timing to add tests (if you want to merge it means the design is quite stable meaning tests can be written :-) ). My 2 cents, Julien. On Fri, Oct 22, 2010 at 9:27 AM, Zelzer Sascha > wrote: Hi Folks, CTK has seen many improvements since the Barcelona hackfest and I would like to merge the dah branch "dicom application hosting" into master to take advantage of the new features. The advantages would be - The dah code would benefit from future refactorings taking place in the master branch - Make use of proper include path inheritance between plugins and libraries - Take advantage of improvements inside ctkPluginFramework - Improve the visibility of the dah plugins to the community After the merge, developers could still hack on new features in their own branches inside their CTK forks. I would take care of adapting the dah code and cleaning up some memory management issues. Do you have any concerns / remarks? Thanks, Sascha _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -------------- next part -------------- An HTML attachment was scrubbed... URL: From s.zelzer at Dkfz-Heidelberg.de Fri Oct 22 14:33:03 2010 From: s.zelzer at Dkfz-Heidelberg.de (Zelzer Sascha) Date: Fri, 22 Oct 2010 16:33:03 +0200 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: References: Message-ID: Hi Jc, I thought about the documentation too, good point. The plugin stuff also needs better / more accessible documentation. Testing is important, but I won't have time to implement unit tests for it in the near future. Thanks, Sascha Von: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Gesendet: Freitag, 22. Oktober 2010 15:46 An: Zelzer Sascha Cc: ctk-developers at commontk.org Betreff: Re: [Ctk-developers] Merging branch "dah" into master Sounds great to me :) Would it possible to: - add a little bit more documentation - create a simple wiki page on commontk.org. (Or move this one to a more obvious location) May be in the Tools section ? We could also create a plugin section ? - increase testing On my side, I will make sure the documentation is regenerated on a daily basis. Thks Jc On Fri, Oct 22, 2010 at 9:27 AM, Zelzer Sascha > wrote: Hi Folks, CTK has seen many improvements since the Barcelona hackfest and I would like to merge the dah branch "dicom application hosting" into master to take advantage of the new features. The advantages would be - The dah code would benefit from future refactorings taking place in the master branch - Make use of proper include path inheritance between plugins and libraries - Take advantage of improvements inside ctkPluginFramework - Improve the visibility of the dah plugins to the community After the merge, developers could still hack on new features in their own branches inside their CTK forks. I would take care of adapting the dah code and cleaning up some memory management issues. Do you have any concerns / remarks? Thanks, Sascha _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From dean.inglis at camris.ca Fri Oct 22 16:01:25 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Fri, 22 Oct 2010 12:01:25 -0400 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: References: Message-ID: <34F6F7B907C44634BE973075C61C7BA4@Hyoid> any chance I could get some help compiling dcmtk on MinGW? regards, Dean [ 43%] Performing update step (git fetch) for 'DCMTK' Already on 'patched' Already up-to-date. [ 43%] Performing configure step for 'DCMTK' -- Configuring done -- Generating done -- Build files have been written to: D:/Developer/Releases/MinGW/SHARED/ctk/CMak eExternals/Build/DCMTK [ 43%] No build step for 'DCMTK' [ 43%] Performing install step for 'DCMTK' [ 0%] Building CXX object ofstd/libsrc/CMakeFiles/ofstd.dir/ofcmdln.cc.obj In file included from D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour ce\DCMTK\ofstd\libsrc\ofcmdln.cc:34: D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Build\DCMTK\include/dcmtk/ config/osconfig.h:793:1: warning: "NO_IOS_BASE_ASSIGN" redefined D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Build\DCMTK\include/dcmtk/ config/osconfig.h:42:1: warning: this is the location of the previous definition In file included from D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour ce\DCMTK\ofstd\include/dcmtk/ofstd/oflist.h:99, from D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour ce\DCMTK\ofstd\include/dcmtk/ofstd/ofcmdln.h:39, from D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour ce\DCMTK\ofstd\libsrc\ofcmdln.cc:36: c:\qt\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/sys/types.h:75: err or: multiple types in one declaration c:\qt\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/sys/types.h:75: err or: declaration does not declare anything c:\qt\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/sys/types.h:104: er ror: declaration does not declare anything mingw32-make[5]: *** [ofstd/libsrc/CMakeFiles/ofstd.dir/ofcmdln.cc.obj] Error 1 mingw32-make[4]: *** [ofstd/libsrc/CMakeFiles/ofstd.dir/all] Error 2 mingw32-make[3]: *** [all] Error 2 mingw32-make[2]: *** [CMakeExternals/Stamp/DCMTK/DCMTK-install] Error 2 mingw32-make[1]: *** [CMakeFiles/DCMTK.dir/all] Error 2 mingw32-make: *** [all] Error 2 ----- Original Message ----- From: "Jean-Christophe Fillion-Robin" To: "Zelzer Sascha" Cc: Sent: Friday, October 22, 2010 9:46 AM Subject: Re: [Ctk-developers] Merging branch "dah" into master Sounds great to me :) Would it possible to: - add a little bit more documentation - create a simple wiki page on commontk.org. (Or move this oneto a more obvious location) May be in the Tools section ? We could also create a plugin section ? - increase testing On my side, I will make sure the documentation is regenerated on a daily basis. Thks Jc On Fri, Oct 22, 2010 at 9:27 AM, Zelzer Sascha wrote: > Hi Folks, > > > > CTK has seen many improvements since the Barcelona hackfest and I would > like to merge the dah branch ?dicom application hosting? into master to > take > advantage of the new features. The advantages would be > > > > - The dah code would benefit from future refactorings taking > place in the master branch > > - Make use of proper include path inheritance between plugins and > libraries > > - Take advantage of improvements inside ctkPluginFramework > > - Improve the visibility of the dah plugins to the community > > > > After the merge, developers could still hack on new features in their own > branches inside their CTK forks. > > > > I would take care of adapting the dah code and cleaning up some memory > management issues. > > > > Do you have any concerns / remarks? > > > > Thanks, > > > > Sascha > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- Phone: 1-518-836-2174 Ext: 304 -------------------------------------------------------------------------------- > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > From s.zelzer at Dkfz-Heidelberg.de Fri Oct 22 16:21:56 2010 From: s.zelzer at Dkfz-Heidelberg.de (Zelzer Sascha) Date: Fri, 22 Oct 2010 18:21:56 +0200 Subject: [Ctk-developers] MediaWiki Cite Extension Message-ID: Hi, I am working on some Wiki pages for CTK and would like to use the "Cite" extension for MediaWiki: http://www.mediawiki.org/wiki/Extension:Cite/Cite.php Is there any change to get it installed on the www.comontk.org Wiki? Thanks, Sascha -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Oct 22 16:36:02 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 22 Oct 2010 12:36:02 -0400 Subject: [Ctk-developers] Feedback - CTK_BUILD_ALL option Message-ID: Hi Folks, I propose to add the advanced CMake option named CTK_BUILD_ALL. By turning this option ON, a dashboard script could optionnally build all libraries, plugins and applications. I would like your comments regarding the following points: 1) Does the option name seems appropriate. Would CTK_ENABLE_ALL be better ? Or ... 2) Would it make sens to have that option showing up as a regular option ? (not an advanced one) 3) Would it be interesting to have also CTK_BUILD_ALL_LIBRARIES, CTK_BUILD_ALL_PLUGINS, CTK_BUILD_ALL_APPS ? 4) Do you think of any other use case beside of the Dashboard script one ? I published the following topic branch: http://github.com/jcfr/CTK/tree/add-build-all-cmake-option Thks Jc -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Oct 22 16:38:36 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 22 Oct 2010 12:38:36 -0400 Subject: [Ctk-developers] MediaWiki Cite Extension In-Reply-To: References: Message-ID: Just forwarded the request to our sys admin. Will keep you posted asap. Thks Jc On Fri, Oct 22, 2010 at 12:21 PM, Zelzer Sascha wrote: > Hi, > > > > I am working on some Wiki pages for CTK and would like to use the ?Cite? > extension for MediaWiki: > > > > http://www.mediawiki.org/wiki/Extension:Cite/Cite.php > > > > Is there any change to get it installed on the www.comontk.org Wiki? > > > > Thanks, > > > > Sascha > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From m.nolden at dkfz-heidelberg.de Fri Oct 22 16:42:55 2010 From: m.nolden at dkfz-heidelberg.de (Marco Nolden) Date: Fri, 22 Oct 2010 18:42:55 +0200 Subject: [Ctk-developers] Feedback - CTK_BUILD_ALL option In-Reply-To: References: Message-ID: <4CC1BF0F.2070207@dkfz.de> I like the idea. We have something similar in the MITK build system and we do not "force" all options to ON when enabling BUILD_ALL but we always check IF(BUILD_Something OR BUILD_ALL) This keeps the old configuration of libs. One use-case we have for that is the local pre-commit check. You change some interface in a class, turn on BUILD_ALL, check that everything builds and tests and after your commit you can turn it off again and have your old config. Marco On 10/22/2010 06:36 PM, Jean-Christophe Fillion-Robin wrote: > Hi Folks, > > I propose to add the advanced CMake option named CTK_BUILD_ALL. > > By turning this option ON, a dashboard script could optionnally build > all libraries, plugins and applications. > > I would like your comments regarding the following points: > 1) Does the option name seems appropriate. Would CTK_ENABLE_ALL be > better ? Or ... > 2) Would it make sens to have that option showing up as a regular > option ? (not an advanced one) > 3) Would it be interesting to have also CTK_BUILD_ALL_LIBRARIES, > CTK_BUILD_ALL_PLUGINS, CTK_BUILD_ALL_APPS ? > 4) Do you think of any other use case beside of the Dashboard script > one ? > > I published the following topic branch: > http://github.com/jcfr/CTK/tree/add-build-all-cmake-option > > Thks > Jc > > -- > Phone: 1-518-836-2174 > Ext: 304 -- ---------------------------------------------------------------------- Dipl.-Inform. Med. Marco Nolden Deutsches Krebsforschungszentrum (German Cancer Research Center) Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325 Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345 D-69120 Heidelberg eMail: M.Nolden at dkfz.de From dicom at offis.de Fri Oct 22 18:38:49 2010 From: dicom at offis.de (OFFIS DICOM Team) Date: Fri, 22 Oct 2010 20:38:49 +0200 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: <34F6F7B907C44634BE973075C61C7BA4@Hyoid> References: <34F6F7B907C44634BE973075C61C7BA4@Hyoid> Message-ID: <201010222038.50278.dicom@offis.de> Dear Dean, > any chance I could get some help compiling dcmtk on MinGW? Unfortunately, I have no MinGW ready to hand but according to some recent postings to our discussion forum at http://forum.dcmtk.org/, the latest version from http://git.dcmtk.org/ should work with MinGW - at least when using "./configure" (GNU autoconf). In August, there were also some some commits regarding the CMake projects files for MinGW. Maybe, you should first check the latest version from DCMTK's git repository ... Regards, J?rg Riesmeier -- OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany E-Mail: dicom at offis.de, URL: http://dicom.offis.de From dean.inglis at camris.ca Fri Oct 22 20:22:47 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Fri, 22 Oct 2010 16:22:47 -0400 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: <201010222038.50278.dicom@offis.de> References: <34F6F7B907C44634BE973075C61C7BA4@Hyoid> <201010222038.50278.dicom@offis.de> Message-ID: <22F7ECC89CE94D679B63335498288F51@Hyoid> Hi J?rg, I see on the git page; Please use the following git command to clone the repository of a particular project: git clone http://git.dcmtk.org/ + project if i try git clone http://git.dcmtk.org/dcmtk $ git clone http://git.dcmtk.org/dcmtk Initialized empty Git repository in /cygdrive/d/Developer/Sources/dcmtk/.git/ fatal: http://git.dcmtk.org/dcmtk/info/refs not found: did you run git update-se rver-info on the server? which doesnt work. Not knowing a whole lot about git yet, what is the exact command I need to use to access dcmtk version? thanks Dean ----- Original Message ----- From: "OFFIS DICOM Team" To: Sent: Friday, October 22, 2010 2:38 PM Subject: Re: [Ctk-developers] Merging branch "dah" into master Dear Dean, > any chance I could get some help compiling dcmtk on MinGW? Unfortunately, I have no MinGW ready to hand but according to some recent postings to our discussion forum at http://forum.dcmtk.org/, the latest version from http://git.dcmtk.org/ should work with MinGW - at least when using "./configure" (GNU autoconf). In August, there were also some some commits regarding the CMake projects files for MinGW. Maybe, you should first check the latest version from DCMTK's git repository ... Regards, J?rg Riesmeier -- OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany E-Mail: dicom at offis.de, URL: http://dicom.offis.de _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers From s.zelzer at dkfz-heidelberg.de Sat Oct 23 09:29:06 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Sat, 23 Oct 2010 11:29:06 +0200 Subject: [Ctk-developers] Feedback - CTK_BUILD_ALL option In-Reply-To: References: Message-ID: <4CC2AAE2.9040307@dkfz-heidelberg.de> Hi Jc, as Marco I also like it. I think CTK_BUILD_ALL is fine, it is consistent with the other CTK_BUILD_* variables. Advanced or regular is both fine for me. CTK_BUILD_ALL_LIBRARIES, CTK_BUILD_ALL_PLUGINS, CTK_BUILD_ALL_APPS could also be handy (as advanced variables). If I am changing something in CTKPluginFramework, I could just enable CTK_BUILD_ALL_PLUGINS to check that every plugin still compiles and than switch it OFF again. - Sascha On 10/22/2010 06:36 PM, Jean-Christophe Fillion-Robin wrote: > Hi Folks, > > I propose to add the advanced CMake option named CTK_BUILD_ALL. > > By turning this option ON, a dashboard script could optionnally build > all libraries, plugins and applications. > > I would like your comments regarding the following points: > 1) Does the option name seems appropriate. Would CTK_ENABLE_ALL be > better ? Or ... > 2) Would it make sens to have that option showing up as a regular > option ? (not an advanced one) > 3) Would it be interesting to have also CTK_BUILD_ALL_LIBRARIES, > CTK_BUILD_ALL_PLUGINS, CTK_BUILD_ALL_APPS ? > 4) Do you think of any other use case beside of the Dashboard script > one ? > > I published the following topic branch: > http://github.com/jcfr/CTK/tree/add-build-all-cmake-option > > Thks > Jc > > -- > Phone: 1-518-836-2174 > Ext: 304 From dicom at offis.de Sat Oct 23 12:01:14 2010 From: dicom at offis.de (=?windows-1252?q?J=F6rg_Riesmeier?=) Date: Sat, 23 Oct 2010 14:01:14 +0200 Subject: [Ctk-developers] Merging branch "dah" into master In-Reply-To: <22F7ECC89CE94D679B63335498288F51@Hyoid> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> Message-ID: <201010231401.14600.dicom@offis.de> Hi Dean, > if i try > git clone http://git.dcmtk.org/dcmtk [...] > which doesnt work. Not knowing a whole lot about git yet, > what is the exact command I need to use to access dcmtk version? the project name is "dcmtk.git", so "git clone http://git.dcmtk.org/dcmtk.git" should work. Regards, J?rg From dean.inglis at camris.ca Sun Oct 24 16:08:38 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Sun, 24 Oct 2010 12:08:38 -0400 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <201010231401.14600.dicom@offis.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> Message-ID: <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> Hi J?rg, Other than the following redefinition warning in osconfig.h, dcmtk compiles with mingw that comes with the Qt SDK 4.6.3 for windows. D:\Developer\Releases\MinGW\SHARED\dcmtk\include/dcmtk/config/osconfig.h:841:1: warning: "NO_IOS_BASE_ASSIGN" redefined D:\Developer\Releases\MinGW\SHARED\dcmtk\include/dcmtk/config/osconfig.h:32:1: w arning: this is the location of the previous definition Dean ----- Original Message ----- From: "J?rg Riesmeier" To: "Dean Inglis" Cc: Sent: Saturday, October 23, 2010 8:01 AM Subject: Re: [Ctk-developers] Merging branch "dah" into master Hi Dean, > if i try > git clone http://git.dcmtk.org/dcmtk [...] > which doesnt work. Not knowing a whole lot about git yet, > what is the exact command I need to use to access dcmtk version? the project name is "dcmtk.git", so "git clone http://git.dcmtk.org/dcmtk.git" should work. Regards, J?rg From s.zelzer at dkfz-heidelberg.de Sun Oct 24 19:14:51 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Sun, 24 Oct 2010 21:14:51 +0200 Subject: [Ctk-developers] Merged branch "dah" into master Message-ID: <4CC485AB.1050409@dkfz-heidelberg.de> Hi Folks, I merged the "dah" branch now into master and cleaned up the code to be consistent with the current code base. If you are starting some coding related do DAH, please branch off from master now, instead of the CTK/dah branch. I will delete the CTK/dah branch in the near future. Thanks, Sascha From dicom at offis.de Mon Oct 25 11:02:00 2010 From: dicom at offis.de (OFFIS DICOM Team) Date: Mon, 25 Oct 2010 13:02:00 +0200 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> Message-ID: <4CC563A8.2000507@offis.de> Dean, > Other than the following redefinition warning in osconfig.h, dcmtk compiles > with mingw that comes with the Qt SDK 4.6.3 for windows. thank you for the feedback. The warning should be fixed now: http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=0257b1c922293f5ac6c473d438613f50d94154d9 Regards, J?rg Riesmeier -- OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany E-Mail: dicom at offis.de, URL: http://dicom.offis.de From dean.inglis at camris.ca Mon Oct 25 12:43:18 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Mon, 25 Oct 2010 08:43:18 -0400 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <4CC563A8.2000507@offis.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de> Message-ID: <587FCAA169584742B84BCD71AC15EC9E@Hyoid> can the latest OFFIS DCMTK git repository be adopted for CTK? Dean ----- Original Message ----- From: "OFFIS DICOM Team" To: "Dean Inglis" Cc: Sent: Monday, October 25, 2010 7:02 AM Subject: Re: mingw compiles dcmtk.git Dean, > Other than the following redefinition warning in osconfig.h, dcmtk > compiles > with mingw that comes with the Qt SDK 4.6.3 for windows. thank you for the feedback. The warning should be fixed now: http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=0257b1c922293f5ac6c473d438613f50d94154d9 Regards, J?rg Riesmeier -- OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany E-Mail: dicom at offis.de, URL: http://dicom.offis.de From dicom at offis.de Mon Oct 25 12:49:29 2010 From: dicom at offis.de (OFFIS DICOM Team) Date: Mon, 25 Oct 2010 14:49:29 +0200 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <587FCAA169584742B84BCD71AC15EC9E@Hyoid> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de> <587FCAA169584742B84BCD71AC15EC9E@Hyoid> Message-ID: <4CC57CD9.8090404@offis.de> Hi Dean, Am 25.10.2010 14:43, schrieb Dean Inglis: > can the latest OFFIS DCMTK git repository be adopted for CTK? No, vice versa: The goal is to finally align CTK's DCMTK repository with the official DCMTK repository from OFFIS so CTK is always based on the latest official DCMTK code available from OFFIS. Both are already very similar, however, that goal is not reached (yet! :-). Best regards, Michael Onken -- OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany E-Mail: dicom at offis.de, URL: http://dicom.offis.de From dean.inglis at camris.ca Mon Oct 25 13:15:25 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Mon, 25 Oct 2010 09:15:25 -0400 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <4CC57CD9.8090404@offis.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> Message-ID: <1762848550A84FF4935A843C34E27F78@Hyoid> Ive been submitting an experimental mingw dashboard for a few weeks now, and Id like to have it testing the dcmtk options, however, there is no cmake cache option for using an external dcmtk (yet there is for vtk). Can there either be an intermediate "re-alignment" or a cmake option to use an external dcmtk with an appropriate "do so at your own risk!" warning message? ----- Original Message ----- From: "OFFIS DICOM Team" To: Sent: Monday, October 25, 2010 8:49 AM Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > Hi Dean, > > Am 25.10.2010 14:43, schrieb Dean Inglis: >> can the latest OFFIS DCMTK git repository be adopted for CTK? > > No, vice versa: The goal is to finally align CTK's DCMTK repository with > the > official DCMTK repository from OFFIS so CTK is always based on the latest > official DCMTK code available from OFFIS. Both are already very similar, > however, that goal is not reached (yet! :-). > > Best regards, > Michael Onken > > -- > OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany > E-Mail: dicom at offis.de, URL: http://dicom.offis.de > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers From s.zelzer at dkfz-heidelberg.de Mon Oct 25 13:43:29 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 25 Oct 2010 15:43:29 +0200 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <1762848550A84FF4935A843C34E27F78@Hyoid> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> Message-ID: <4CC58981.8030900@dkfz-heidelberg.de> Hi Dean, you can set DCMTK_DIR to an external DCMTK build tree. Either add the variable manually in the CMake GUI or start cmake in an empty build directory like: cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree That should work... - Sascha On 10/25/2010 03:15 PM, Dean Inglis wrote: > Ive been submitting an experimental mingw dashboard for a few weeks > now, and Id like to have it testing the dcmtk options, however, there is no > cmake cache option for using an external dcmtk (yet there is for vtk). > Can there either be an intermediate "re-alignment" or a cmake option > to use an external dcmtk with an appropriate "do so at your own risk!" > warning message? > > ----- Original Message ----- > From: "OFFIS DICOM Team" > To: > Sent: Monday, October 25, 2010 8:49 AM > Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > > > >> Hi Dean, >> >> Am 25.10.2010 14:43, schrieb Dean Inglis: >> >>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>> >> No, vice versa: The goal is to finally align CTK's DCMTK repository with >> the >> official DCMTK repository from OFFIS so CTK is always based on the latest >> official DCMTK code available from OFFIS. Both are already very similar, >> however, that goal is not reached (yet! :-). >> >> Best regards, >> Michael Onken >> >> -- >> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > From s.zelzer at dkfz-heidelberg.de Mon Oct 25 14:00:36 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 25 Oct 2010 16:00:36 +0200 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <4CC58981.8030900@dkfz-heidelberg.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> <4CC58981.8030900@dkfz-heidelberg.de> Message-ID: <4CC58D84.7090302@dkfz-heidelberg.de> By the way, this should work for any external project in CTK. Just set _DIR to the appropriate directory. However, if there is no Find.cmake script, the external project must provide a Config.cmake file in the _DIR directory. If this does not work (CMake configure errors or include/linker errors when building CTK), it should be considered a build-system bug. - Sascha On 10/25/2010 03:43 PM, Sascha Zelzer wrote: > Hi Dean, > > you can set DCMTK_DIR to an external DCMTK build tree. Either add the > variable manually in the CMake GUI or start cmake in an empty build > directory like: > > cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree > > That should work... > > - Sascha > > On 10/25/2010 03:15 PM, Dean Inglis wrote: > >> Ive been submitting an experimental mingw dashboard for a few weeks >> now, and Id like to have it testing the dcmtk options, however, there is no >> cmake cache option for using an external dcmtk (yet there is for vtk). >> Can there either be an intermediate "re-alignment" or a cmake option >> to use an external dcmtk with an appropriate "do so at your own risk!" >> warning message? >> >> ----- Original Message ----- >> From: "OFFIS DICOM Team" >> To: >> Sent: Monday, October 25, 2010 8:49 AM >> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >> >> >> >> >>> Hi Dean, >>> >>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>> >>> >>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>> >>>> >>> No, vice versa: The goal is to finally align CTK's DCMTK repository with >>> the >>> official DCMTK repository from OFFIS so CTK is always based on the latest >>> official DCMTK code available from OFFIS. Both are already very similar, >>> however, that goal is not reached (yet! :-). >>> >>> Best regards, >>> Michael Onken >>> >>> -- >>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>> >>> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > From dean.inglis at camris.ca Mon Oct 25 14:08:34 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Mon, 25 Oct 2010 10:08:34 -0400 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <4CC58D84.7090302@dkfz-heidelberg.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid><4CC58981.8030900@dkfz-heidelberg.de> <4CC58D84.7090302@dkfz-heidelberg.de> Message-ID: <2B0FAC5638334724ACA6E6D2549EFB76@Hyoid> Hi Sascha, thanks, Ill try that out in my ctest dashboard script. Im still having a dashboard build problem with QtMobility (it doesnt build) which does not occur when I do a non-test build with cmake, so there might be a build-system bug with ctkDashboardDriverScript.cmake and/or my version of ctkDashboardScript.TEMPLATE.cmake (attached). Dean ----- Original Message ----- From: "Sascha Zelzer" To: Sent: Monday, October 25, 2010 10:00 AM Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > By the way, this should work for any external project in CTK. Just set > _DIR to the appropriate directory. However, if there is no > Find.cmake script, the external project must provide a > Config.cmake file in the _DIR directory. > > If this does not work (CMake configure errors or include/linker errors > when building CTK), it should be considered a build-system bug. > > - Sascha > > On 10/25/2010 03:43 PM, Sascha Zelzer wrote: >> Hi Dean, >> >> you can set DCMTK_DIR to an external DCMTK build tree. Either add the >> variable manually in the CMake GUI or start cmake in an empty build >> directory like: >> >> cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree >> >> That should work... >> >> - Sascha >> >> On 10/25/2010 03:15 PM, Dean Inglis wrote: >> >>> Ive been submitting an experimental mingw dashboard for a few weeks >>> now, and Id like to have it testing the dcmtk options, however, there is >>> no >>> cmake cache option for using an external dcmtk (yet there is for vtk). >>> Can there either be an intermediate "re-alignment" or a cmake option >>> to use an external dcmtk with an appropriate "do so at your own risk!" >>> warning message? >>> >>> ----- Original Message ----- >>> From: "OFFIS DICOM Team" >>> To: >>> Sent: Monday, October 25, 2010 8:49 AM >>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>> >>> >>> >>> >>>> Hi Dean, >>>> >>>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>>> >>>> >>>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>>> >>>>> >>>> No, vice versa: The goal is to finally align CTK's DCMTK repository >>>> with >>>> the >>>> official DCMTK repository from OFFIS so CTK is always based on the >>>> latest >>>> official DCMTK code available from OFFIS. Both are already very >>>> similar, >>>> however, that goal is not reached (yet! :-). >>>> >>>> Best regards, >>>> Michael Onken >>>> >>>> -- >>>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>>> _______________________________________________ >>>> Ctk-developers mailing list >>>> Ctk-developers at commontk.org >>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>> >>>> >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>> >>> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -------------- next part -------------- A non-text attachment was scrubbed... Name: ctk.cmake Type: application/octet-stream Size: 4537 bytes Desc: not available URL: From dean.inglis at camris.ca Mon Oct 25 15:21:16 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Mon, 25 Oct 2010 11:21:16 -0400 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <4CC58981.8030900@dkfz-heidelberg.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> <4CC58981.8030900@dkfz-heidelberg.de> Message-ID: <81AF149475264B54860EAB098536B5FF@Hyoid> Hi Sascha, ctk cant find the include paths to the header files even though I have in cache //No help, variable specified on the command line. DCMTK_DIR:PATH=d:/Developer/Releases/MinGW/SHARED/dcmtk Dean Scanning dependencies of target CTKDICOMCore [ 58%] Building CXX object Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOM. cpp.obj [ 58%] Building CXX object Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMI ndexer.cpp.obj D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:40:36: error: dcmtk /dcmdata/dcfilefo.h: No such file or directory D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:42:36: error: dcmtk /dcmdata/dcdeftag.h: No such file or directory D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:43:36: error: dcmtk /dcmdata/dcdatset.h: No such file or directory D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:44:32: error: dcmtk /ofstd/ofcond.h: No such file or directory D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:45:34: error: dcmtk /ofstd/ofstring.h: No such file or directory D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:46:65: error: dcmtk /ofstd/ofstd.h: No such file or directory D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:47:72: error: dcmtk /dcmdata/dcddirif.h: No such file or directory D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp: In member function 'void ctkDICOMIndexer::addDirectory(QSqlDatabase, const QString&, const QString &)': D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: 'OFList' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: 'OFStrin g' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: 'origina lDcmtkFileNames' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:94: error: 'dcmtkFi leNames' was not declared in this scope ----- Original Message ----- From: "Sascha Zelzer" To: "Dean Inglis" Cc: Sent: Monday, October 25, 2010 9:43 AM Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > Hi Dean, > > you can set DCMTK_DIR to an external DCMTK build tree. Either add the > variable manually in the CMake GUI or start cmake in an empty build > directory like: > > cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree > > That should work... > > - Sascha > > On 10/25/2010 03:15 PM, Dean Inglis wrote: >> Ive been submitting an experimental mingw dashboard for a few weeks >> now, and Id like to have it testing the dcmtk options, however, there is >> no >> cmake cache option for using an external dcmtk (yet there is for vtk). >> Can there either be an intermediate "re-alignment" or a cmake option >> to use an external dcmtk with an appropriate "do so at your own risk!" >> warning message? >> >> ----- Original Message ----- >> From: "OFFIS DICOM Team" >> To: >> Sent: Monday, October 25, 2010 8:49 AM >> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >> >> >> >>> Hi Dean, >>> >>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>> >>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>> >>> No, vice versa: The goal is to finally align CTK's DCMTK repository with >>> the >>> official DCMTK repository from OFFIS so CTK is always based on the >>> latest >>> official DCMTK code available from OFFIS. Both are already very similar, >>> however, that goal is not reached (yet! :-). >>> >>> Best regards, >>> Michael Onken >>> >>> -- >>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> > From s.zelzer at dkfz-heidelberg.de Mon Oct 25 16:14:01 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 25 Oct 2010 18:14:01 +0200 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <81AF149475264B54860EAB098536B5FF@Hyoid> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> <4CC58981.8030900@dkfz-heidelberg.de> <81AF149475264B54860EAB098536B5FF@Hyoid> Message-ID: <4CC5ACC9.9050907@dkfz-heidelberg.de> Well, it seems that the restriction I mentioned in my previous post applies to DCMTK... There is no DCMTKConfig.cmake file in the build tree and the FindDCMTK.cmake file (shipped with CMake) is not able to find the include dirs automatically. However, you should be able to set them manually. Have a look at DCMTK_*_INCLUDE_DIR variables (probably advanced) and set them to the appropriate directories in DCMTKs source tree. - Sascha On 10/25/2010 05:21 PM, Dean Inglis wrote: > Hi Sascha, > > ctk cant find the include paths to the header files even though I have in > cache > > //No help, variable specified on the command line. > DCMTK_DIR:PATH=d:/Developer/Releases/MinGW/SHARED/dcmtk > > Dean > > Scanning dependencies of target CTKDICOMCore > [ 58%] Building CXX object > Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOM. > cpp.obj > [ 58%] Building CXX object > Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMI > ndexer.cpp.obj > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:40:36: error: > dcmtk > /dcmdata/dcfilefo.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:42:36: error: > dcmtk > /dcmdata/dcdeftag.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:43:36: error: > dcmtk > /dcmdata/dcdatset.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:44:32: error: > dcmtk > /ofstd/ofcond.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:45:34: error: > dcmtk > /ofstd/ofstring.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:46:65: error: > dcmtk > /ofstd/ofstd.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:47:72: error: > dcmtk > /dcmdata/dcddirif.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp: In member > function > 'void ctkDICOMIndexer::addDirectory(QSqlDatabase, const QString&, const > QString > &)': > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: > 'OFList' > was not declared in this scope > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: > 'OFStrin > g' was not declared in this scope > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: > 'origina > lDcmtkFileNames' was not declared in this scope > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:94: error: > 'dcmtkFi > leNames' was not declared in this scope > > ----- Original Message ----- > From: "Sascha Zelzer" > To: "Dean Inglis" > Cc: > Sent: Monday, October 25, 2010 9:43 AM > Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > > > >> Hi Dean, >> >> you can set DCMTK_DIR to an external DCMTK build tree. Either add the >> variable manually in the CMake GUI or start cmake in an empty build >> directory like: >> >> cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree >> >> That should work... >> >> - Sascha >> >> On 10/25/2010 03:15 PM, Dean Inglis wrote: >> >>> Ive been submitting an experimental mingw dashboard for a few weeks >>> now, and Id like to have it testing the dcmtk options, however, there is >>> no >>> cmake cache option for using an external dcmtk (yet there is for vtk). >>> Can there either be an intermediate "re-alignment" or a cmake option >>> to use an external dcmtk with an appropriate "do so at your own risk!" >>> warning message? >>> >>> ----- Original Message ----- >>> From: "OFFIS DICOM Team" >>> To: >>> Sent: Monday, October 25, 2010 8:49 AM >>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>> >>> >>> >>> >>>> Hi Dean, >>>> >>>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>>> >>>> >>>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>>> >>>>> >>>> No, vice versa: The goal is to finally align CTK's DCMTK repository with >>>> the >>>> official DCMTK repository from OFFIS so CTK is always based on the >>>> latest >>>> official DCMTK code available from OFFIS. Both are already very similar, >>>> however, that goal is not reached (yet! :-). >>>> >>>> Best regards, >>>> Michael Onken >>>> >>>> -- >>>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>>> _______________________________________________ >>>> Ctk-developers mailing list >>>> Ctk-developers at commontk.org >>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>> >>>> >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>> >>> >> > From jchris.fillionr at kitware.com Mon Oct 25 19:52:48 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Mon, 25 Oct 2010 15:52:48 -0400 Subject: [Ctk-developers] CMake 2.8.2 will be required - Is that Ok ? Message-ID: Hi Folks, Requiring CMake 2.8 which doesn't have native support for GIT and external project, CTK was providing its own ExternalProject module. See http://github.com/commontk/CTK/blob/master/CMake/ExternalProject.cmake In between, the ExternalProject module has been improved. I think it's now time to require CMake 2.8.2 and benefit from the built-in Git support for external project. In addition, a lot of bugs have been fixed in CMake since 2.8 release. See http://www.cmake.org/files/v2.8/CMakeChangeLog-2.8.2 If we ll agree, tomorrow: - ExternalProject.cmake will be removed from CTK repository - CMake 2.8.2 will be the minimum requirements Thks Jc -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From pieper at bwh.harvard.edu Mon Oct 25 20:58:47 2010 From: pieper at bwh.harvard.edu (Steve Pieper) Date: Mon, 25 Oct 2010 16:58:47 -0400 Subject: [Ctk-developers] [slicer-devel] Slicer4 developers - CMake 2.8.2 will be required - Is that okay ? In-Reply-To: References: Message-ID: <4CC5EF87.4080606@bwh.harvard.edu> Sounds very fair to me. -Steve On 10/25/2010 04:01 PM, Jean-Christophe Fillion-Robin wrote: > Hi Folks, > > As of today, external project support is provided by a custom module. > Indeed, since CMake 2.8 doesn't have native support for (GIT+external > project), Slicer was using a custom ExternalProject module. See > http://github.com/commontk/CTK/blob/master/CMake/ExternalProject.cmake > > In between, the official ExternalProject module has been improved. I > think it's now time to require CMake 2.8.2 and benefit from the built-in > Git support for external project. > > In addition, a lot of bugs have been fixed in CMake since 2.8 release. > See http://www.cmake.org/files/v2.8/CMakeChangeLog-2.8.2 > > If we ll agree, by tomorrow CMake 2.8.2 will be the minimum required. > > Thks > Jc > > -- > Phone: 1-518-836-2174 > Ext: 304 > > > > _______________________________________________ > slicer-devel mailing list > slicer-devel at bwh.harvard.edu > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > To unsubscribe: send email to slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the subject From s.zelzer at dkfz-heidelberg.de Mon Oct 25 21:03:28 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 25 Oct 2010 23:03:28 +0200 Subject: [Ctk-developers] CMake 2.8.2 will be required - Is that Ok ? In-Reply-To: References: Message-ID: <4CC5F0A0.3090902@dkfz-heidelberg.de> Sounds good to me, especially since Ubuntu 10.10 ships with CMake 2.8.2 already. So no need for a custom build. Best, Sascha On 10/25/2010 09:52 PM, Jean-Christophe Fillion-Robin wrote: > Hi Folks, > > Requiring CMake 2.8 which doesn't have native support for GIT and > external project, CTK was providing its own ExternalProject module. > See http://github.com/commontk/CTK/blob/master/CMake/ExternalProject.cmake > > In between, the ExternalProject module has been improved. I think it's > now time to require CMake 2.8.2 and benefit from the built-in Git > support for external project. > > In addition, a lot of bugs have been fixed in CMake since 2.8 release. > See http://www.cmake.org/files/v2.8/CMakeChangeLog-2.8.2 > > If we ll agree, tomorrow: > - ExternalProject.cmake will be removed from CTK repository > - CMake 2.8.2 will be the minimum requirements > > Thks > Jc > > -- > Phone: 1-518-836-2174 > Ext: 304 From s.zelzer at dkfz-heidelberg.de Mon Oct 25 21:05:03 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 25 Oct 2010 23:05:03 +0200 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <81AF149475264B54860EAB098536B5FF@Hyoid> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> <4CC58981.8030900@dkfz-heidelberg.de> <81AF149475264B54860EAB098536B5FF@Hyoid> Message-ID: <4CC5F0FF.9030303@dkfz-heidelberg.de> You might also want to try a recent CMake version (> 2.8.0). I think the FindDCMTK.cmake file in those will automatically find the include directories. - Sascha On 10/25/2010 05:21 PM, Dean Inglis wrote: > Hi Sascha, > > ctk cant find the include paths to the header files even though I have in > cache > > //No help, variable specified on the command line. > DCMTK_DIR:PATH=d:/Developer/Releases/MinGW/SHARED/dcmtk > > Dean > > Scanning dependencies of target CTKDICOMCore > [ 58%] Building CXX object > Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOM. > cpp.obj > [ 58%] Building CXX object > Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMI > ndexer.cpp.obj > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:40:36: error: > dcmtk > /dcmdata/dcfilefo.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:42:36: error: > dcmtk > /dcmdata/dcdeftag.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:43:36: error: > dcmtk > /dcmdata/dcdatset.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:44:32: error: > dcmtk > /ofstd/ofcond.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:45:34: error: > dcmtk > /ofstd/ofstring.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:46:65: error: > dcmtk > /ofstd/ofstd.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:47:72: error: > dcmtk > /dcmdata/dcddirif.h: No such file or directory > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp: In member > function > 'void ctkDICOMIndexer::addDirectory(QSqlDatabase, const QString&, const > QString > &)': > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: > 'OFList' > was not declared in this scope > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: > 'OFStrin > g' was not declared in this scope > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: > 'origina > lDcmtkFileNames' was not declared in this scope > D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:94: error: > 'dcmtkFi > leNames' was not declared in this scope > > ----- Original Message ----- > From: "Sascha Zelzer" > To: "Dean Inglis" > Cc: > Sent: Monday, October 25, 2010 9:43 AM > Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > > >> Hi Dean, >> >> you can set DCMTK_DIR to an external DCMTK build tree. Either add the >> variable manually in the CMake GUI or start cmake in an empty build >> directory like: >> >> cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree >> >> That should work... >> >> - Sascha >> >> On 10/25/2010 03:15 PM, Dean Inglis wrote: >>> Ive been submitting an experimental mingw dashboard for a few weeks >>> now, and Id like to have it testing the dcmtk options, however, there is >>> no >>> cmake cache option for using an external dcmtk (yet there is for vtk). >>> Can there either be an intermediate "re-alignment" or a cmake option >>> to use an external dcmtk with an appropriate "do so at your own risk!" >>> warning message? >>> >>> ----- Original Message ----- >>> From: "OFFIS DICOM Team" >>> To: >>> Sent: Monday, October 25, 2010 8:49 AM >>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>> >>> >>> >>>> Hi Dean, >>>> >>>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>>> >>>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>>> >>>> No, vice versa: The goal is to finally align CTK's DCMTK repository with >>>> the >>>> official DCMTK repository from OFFIS so CTK is always based on the >>>> latest >>>> official DCMTK code available from OFFIS. Both are already very similar, >>>> however, that goal is not reached (yet! :-). >>>> >>>> Best regards, >>>> Michael Onken >>>> >>>> -- >>>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>>> _______________________________________________ >>>> Ctk-developers mailing list >>>> Ctk-developers at commontk.org >>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>> >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>> From jchris.fillionr at kitware.com Mon Oct 25 23:28:20 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Mon, 25 Oct 2010 19:28:20 -0400 Subject: [Ctk-developers] CMake 2.8.2 will be required - Is that Ok ? In-Reply-To: <4CC5F0A0.3090902@dkfz-heidelberg.de> References: <4CC5F0A0.3090902@dkfz-heidelberg.de> Message-ID: Hi Folks, Please note that Following commit fe289e3CMake 2.8.2 is now required to successfully build CTK. Thks Jc On Mon, Oct 25, 2010 at 5:03 PM, Sascha Zelzer wrote: > Sounds good to me, especially since Ubuntu 10.10 ships with CMake 2.8.2 > already. So no need for a custom build. > > Best, > Sascha > > > On 10/25/2010 09:52 PM, Jean-Christophe Fillion-Robin wrote: > >> Hi Folks, >> >> Requiring CMake 2.8 which doesn't have native support for GIT and external >> project, CTK was providing its own ExternalProject module. See >> http://github.com/commontk/CTK/blob/master/CMake/ExternalProject.cmake >> >> In between, the ExternalProject module has been improved. I think it's now >> time to require CMake 2.8.2 and benefit from the built-in Git support for >> external project. >> >> In addition, a lot of bugs have been fixed in CMake since 2.8 release. See >> http://www.cmake.org/files/v2.8/CMakeChangeLog-2.8.2 >> >> If we ll agree, tomorrow: >> - ExternalProject.cmake will be removed from CTK repository >> - CMake 2.8.2 will be the minimum requirements >> >> Thks >> Jc >> >> -- >> Phone: 1-518-836-2174 >> Ext: 304 >> > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From dean.inglis at camris.ca Tue Oct 26 01:14:32 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Mon, 25 Oct 2010 21:14:32 -0400 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <4CC5ACC9.9050907@dkfz-heidelberg.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> <4CC58981.8030900@dkfz-heidelberg.de> <81AF149475264B54860EAB098536B5FF@Hyoid> <4CC5ACC9.9050907@dkfz-heidelberg.de> Message-ID: Hi Sascha Ive installed CMake 2.8.2, specified the external build dir in the cmakecache, there are no DCMTK_ vars in the advanced section of my cache to set. It's odd that I can set and external VTK_DIR and the vtk core gets built. Dean > You might also want to try a recent CMake version (> 2.8.0). I think the > FindDCMTK.cmake file in those will automatically find the include > directories. > > - Sascha ----- Original Message ----- From: "Sascha Zelzer" To: "Dean Inglis" Cc: Sent: Monday, October 25, 2010 12:14 PM Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > Well, it seems that the restriction I mentioned in my previous post > applies to DCMTK... > > There is no DCMTKConfig.cmake file in the build tree and the > FindDCMTK.cmake file (shipped with CMake) is not able to find the include > dirs automatically. However, you should be able to set them manually. Have > a look at DCMTK_*_INCLUDE_DIR variables (probably advanced) and set them > to the appropriate directories in DCMTKs source tree. > > - Sascha > > On 10/25/2010 05:21 PM, Dean Inglis wrote: >> Hi Sascha, >> >> ctk cant find the include paths to the header files even though I have in >> cache >> >> //No help, variable specified on the command line. >> DCMTK_DIR:PATH=d:/Developer/Releases/MinGW/SHARED/dcmtk >> >> Dean >> >> Scanning dependencies of target CTKDICOMCore >> [ 58%] Building CXX object >> Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOM. >> cpp.obj >> [ 58%] Building CXX object >> Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMI >> ndexer.cpp.obj >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:40:36: >> error: >> dcmtk >> /dcmdata/dcfilefo.h: No such file or directory >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:42:36: >> error: >> dcmtk >> /dcmdata/dcdeftag.h: No such file or directory >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:43:36: >> error: >> dcmtk >> /dcmdata/dcdatset.h: No such file or directory >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:44:32: >> error: >> dcmtk >> /ofstd/ofcond.h: No such file or directory >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:45:34: >> error: >> dcmtk >> /ofstd/ofstring.h: No such file or directory >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:46:65: >> error: >> dcmtk >> /ofstd/ofstd.h: No such file or directory >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:47:72: >> error: >> dcmtk >> /dcmdata/dcddirif.h: No such file or directory >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp: In member >> function >> 'void ctkDICOMIndexer::addDirectory(QSqlDatabase, const QString&, const >> QString >> &)': >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >> 'OFList' >> was not declared in this scope >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >> 'OFStrin >> g' was not declared in this scope >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >> 'origina >> lDcmtkFileNames' was not declared in this scope >> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:94: error: >> 'dcmtkFi >> leNames' was not declared in this scope >> >> ----- Original Message ----- >> From: "Sascha Zelzer" >> To: "Dean Inglis" >> Cc: >> Sent: Monday, October 25, 2010 9:43 AM >> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >> >> >> >>> Hi Dean, >>> >>> you can set DCMTK_DIR to an external DCMTK build tree. Either add the >>> variable manually in the CMake GUI or start cmake in an empty build >>> directory like: >>> >>> cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree >>> >>> That should work... >>> >>> - Sascha >>> >>> On 10/25/2010 03:15 PM, Dean Inglis wrote: >>> >>>> Ive been submitting an experimental mingw dashboard for a few weeks >>>> now, and Id like to have it testing the dcmtk options, however, there >>>> is >>>> no >>>> cmake cache option for using an external dcmtk (yet there is for vtk). >>>> Can there either be an intermediate "re-alignment" or a cmake option >>>> to use an external dcmtk with an appropriate "do so at your own risk!" >>>> warning message? >>>> >>>> ----- Original Message ----- >>>> From: "OFFIS DICOM Team" >>>> To: >>>> Sent: Monday, October 25, 2010 8:49 AM >>>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>>> >>>> >>>> >>>> >>>>> Hi Dean, >>>>> >>>>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>>>> >>>>> >>>>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>>>> >>>>>> >>>>> No, vice versa: The goal is to finally align CTK's DCMTK repository >>>>> with >>>>> the >>>>> official DCMTK repository from OFFIS so CTK is always based on the >>>>> latest >>>>> official DCMTK code available from OFFIS. Both are already very >>>>> similar, >>>>> however, that goal is not reached (yet! :-). >>>>> >>>>> Best regards, >>>>> Michael Onken >>>>> >>>>> -- >>>>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>>>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>>>> _______________________________________________ >>>>> Ctk-developers mailing list >>>>> Ctk-developers at commontk.org >>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>>> >>>>> >>>> _______________________________________________ >>>> Ctk-developers mailing list >>>> Ctk-developers at commontk.org >>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>> >>>> >>> >> > From s.zelzer at dkfz-heidelberg.de Tue Oct 26 05:51:29 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Tue, 26 Oct 2010 07:51:29 +0200 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> <4CC58981.8030900@dkfz-heidelberg.de> <81AF149475264B54860EAB098536B5FF@Hyoid> <4CC5ACC9.9050907@dkfz-heidelberg.de> Message-ID: <4CC66C61.70003@dkfz-heidelberg.de> Make sure to use the cmake cache in /CTK-build , not , and to enable something in CTK which uses DCMTK. - Sascha On 10/26/2010 03:14 AM, Dean Inglis wrote: > Hi Sascha > > Ive installed CMake 2.8.2, specified the external build dir in the > cmakecache, > there are no DCMTK_ vars in the advanced section of my cache to set. > It's odd that I can set and external VTK_DIR and the vtk core gets built. > > Dean > >> You might also want to try a recent CMake version (> 2.8.0). I think the >> FindDCMTK.cmake file in those will automatically find the include >> directories. >> >> - Sascha > > ----- Original Message ----- > From: "Sascha Zelzer" > To: "Dean Inglis" > Cc: > Sent: Monday, October 25, 2010 12:14 PM > Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > > >> Well, it seems that the restriction I mentioned in my previous post >> applies to DCMTK... >> >> There is no DCMTKConfig.cmake file in the build tree and the >> FindDCMTK.cmake file (shipped with CMake) is not able to find the include >> dirs automatically. However, you should be able to set them manually. Have >> a look at DCMTK_*_INCLUDE_DIR variables (probably advanced) and set them >> to the appropriate directories in DCMTKs source tree. >> >> - Sascha >> >> On 10/25/2010 05:21 PM, Dean Inglis wrote: >>> Hi Sascha, >>> >>> ctk cant find the include paths to the header files even though I have in >>> cache >>> >>> //No help, variable specified on the command line. >>> DCMTK_DIR:PATH=d:/Developer/Releases/MinGW/SHARED/dcmtk >>> >>> Dean >>> >>> Scanning dependencies of target CTKDICOMCore >>> [ 58%] Building CXX object >>> Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOM. >>> cpp.obj >>> [ 58%] Building CXX object >>> Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMI >>> ndexer.cpp.obj >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:40:36: >>> error: >>> dcmtk >>> /dcmdata/dcfilefo.h: No such file or directory >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:42:36: >>> error: >>> dcmtk >>> /dcmdata/dcdeftag.h: No such file or directory >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:43:36: >>> error: >>> dcmtk >>> /dcmdata/dcdatset.h: No such file or directory >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:44:32: >>> error: >>> dcmtk >>> /ofstd/ofcond.h: No such file or directory >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:45:34: >>> error: >>> dcmtk >>> /ofstd/ofstring.h: No such file or directory >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:46:65: >>> error: >>> dcmtk >>> /ofstd/ofstd.h: No such file or directory >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:47:72: >>> error: >>> dcmtk >>> /dcmdata/dcddirif.h: No such file or directory >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp: In member >>> function >>> 'void ctkDICOMIndexer::addDirectory(QSqlDatabase, const QString&, const >>> QString >>> &)': >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >>> 'OFList' >>> was not declared in this scope >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >>> 'OFStrin >>> g' was not declared in this scope >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >>> 'origina >>> lDcmtkFileNames' was not declared in this scope >>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:94: error: >>> 'dcmtkFi >>> leNames' was not declared in this scope >>> >>> ----- Original Message ----- >>> From: "Sascha Zelzer" >>> To: "Dean Inglis" >>> Cc: >>> Sent: Monday, October 25, 2010 9:43 AM >>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>> >>> >>> >>>> Hi Dean, >>>> >>>> you can set DCMTK_DIR to an external DCMTK build tree. Either add the >>>> variable manually in the CMake GUI or start cmake in an empty build >>>> directory like: >>>> >>>> cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree >>>> >>>> That should work... >>>> >>>> - Sascha >>>> >>>> On 10/25/2010 03:15 PM, Dean Inglis wrote: >>>> >>>>> Ive been submitting an experimental mingw dashboard for a few weeks >>>>> now, and Id like to have it testing the dcmtk options, however, there >>>>> is >>>>> no >>>>> cmake cache option for using an external dcmtk (yet there is for vtk). >>>>> Can there either be an intermediate "re-alignment" or a cmake option >>>>> to use an external dcmtk with an appropriate "do so at your own risk!" >>>>> warning message? >>>>> >>>>> ----- Original Message ----- >>>>> From: "OFFIS DICOM Team" >>>>> To: >>>>> Sent: Monday, October 25, 2010 8:49 AM >>>>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>>>> >>>>> >>>>> >>>>> >>>>>> Hi Dean, >>>>>> >>>>>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>>>>> >>>>>> >>>>>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>>>>> >>>>>>> >>>>>> No, vice versa: The goal is to finally align CTK's DCMTK repository >>>>>> with >>>>>> the >>>>>> official DCMTK repository from OFFIS so CTK is always based on the >>>>>> latest >>>>>> official DCMTK code available from OFFIS. Both are already very >>>>>> similar, >>>>>> however, that goal is not reached (yet! :-). >>>>>> >>>>>> Best regards, >>>>>> Michael Onken >>>>>> >>>>>> -- >>>>>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>>>>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>>>>> _______________________________________________ >>>>>> Ctk-developers mailing list >>>>>> Ctk-developers at commontk.org >>>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>>>> >>>>>> >>>>> _______________________________________________ >>>>> Ctk-developers mailing list >>>>> Ctk-developers at commontk.org >>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>>> >>>>> From jchris.fillionr at kitware.com Tue Oct 26 14:55:51 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Tue, 26 Oct 2010 10:55:51 -0400 Subject: [Ctk-developers] [slicer-devel] Superbuild issue git_EXEC vs GIT_EXEC In-Reply-To: <834E1BA7-3672-43A5-9146-BB9090299FBC@bwh.harvard.edu> References: <834E1BA7-3672-43A5-9146-BB9090299FBC@bwh.harvard.edu> Message-ID: Did you started from a clean directory ? Within CTK, removing our custom ExternalProject module (using git_EXECUTABLE) and now relying on the official module provided by CMake (using GIT_EXECUTABLE) may have cause some trouble. Thks Jc On Tue, Oct 26, 2010 at 10:47 AM, Daniel Haehn wrote: > Hi guys, > > SuperBuild did not work for me this morning: > > -- Generated: > /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/DGraphInput-alldep.txt > -- Generated: > /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/DGraphInput-alldep-withext.txt > -- Generated: > /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/DGraphInput.txt > -- Generated: > /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/Project.xml > -- Could NOT find Git (missing: GIT_EXECUTABLE) > CMake Error at /opt/local/share/cmake-2.8/Modules/ExternalProject.cmake:825 > (message): > error: could not find git for clone of Log4Qt > Call Stack (most recent call first): > /opt/local/share/cmake-2.8/Modules/ExternalProject.cmake:1165 > (_ep_add_download_command) > CMakeExternals/Log4Qt.cmake:22 (ExternalProject_Add) > SuperBuild.cmake:131 (INCLUDE) > CMakeLists.txt:509 (INCLUDE) > > I had to add > > SET(GIT_EXECUTABLE ${git_EXECUTABLE} > > to my local Slicer4-Superbuild/CTK/CMakeExternals/Log4Qt.cmake. Then it all > works. > > Seems just some uppercase/lowercase CMake variable issue. > > Daniel > > The information contained in this e-mail message is intended only for the > personal and confidential use of the recipient(s) named above. If the reader > of this message is not the intended recipient or an agent responsible for > delivering it to the intended recipient, you are hereby notified that you > have received this document in error and that any review, dissemination, > distribution, or copying of this message is strictly prohibited. If you have > received this communication in error, please notify us immediately by > e-mail, and delete the original message. > _______________________________________________ > slicer-devel mailing list > slicer-devel at bwh.harvard.edu > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > To unsubscribe: send email to > slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the > subject > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From haehn at bwh.harvard.edu Tue Oct 26 14:47:29 2010 From: haehn at bwh.harvard.edu (Daniel Haehn) Date: Tue, 26 Oct 2010 10:47:29 -0400 Subject: [Ctk-developers] Superbuild issue git_EXEC vs GIT_EXEC Message-ID: <834E1BA7-3672-43A5-9146-BB9090299FBC@bwh.harvard.edu> Hi guys, SuperBuild did not work for me this morning: -- Generated: /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/DGraphInput-alldep.txt -- Generated: /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/DGraphInput-alldep-withext.txt -- Generated: /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/DGraphInput.txt -- Generated: /Users/daniel/SLICER/QT_TRUNK/Slicer4-Superbuild/CTK-build/Project.xml -- Could NOT find Git (missing: GIT_EXECUTABLE) CMake Error at /opt/local/share/cmake-2.8/Modules/ExternalProject.cmake:825 (message): error: could not find git for clone of Log4Qt Call Stack (most recent call first): /opt/local/share/cmake-2.8/Modules/ExternalProject.cmake:1165 (_ep_add_download_command) CMakeExternals/Log4Qt.cmake:22 (ExternalProject_Add) SuperBuild.cmake:131 (INCLUDE) CMakeLists.txt:509 (INCLUDE) I had to add SET(GIT_EXECUTABLE ${git_EXECUTABLE} to my local Slicer4-Superbuild/CTK/CMakeExternals/Log4Qt.cmake. Then it all works. Seems just some uppercase/lowercase CMake variable issue. Daniel The information contained in this e-mail message is intended only for the personal and confidential use of the recipient(s) named above. If the reader of this message is not the intended recipient or an agent responsible for delivering it to the intended recipient, you are hereby notified that you have received this document in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify us immediately by e-mail, and delete the original message. From dean.inglis at camris.ca Sat Oct 30 14:53:49 2010 From: dean.inglis at camris.ca (Dean Inglis) Date: Sat, 30 Oct 2010 10:53:49 -0400 Subject: [Ctk-developers] mingw compiles dcmtk.git In-Reply-To: <4CC66C61.70003@dkfz-heidelberg.de> References: <201010222038.50278.dicom@offis.de> <22F7ECC89CE94D679B63335498288F51@Hyoid> <201010231401.14600.dicom@offis.de> <16F7FCBFC0874EB9BE289E75D233215C@Hyoid> <4CC563A8.2000507@offis.de><587FCAA169584742B84BCD71AC15EC9E@Hyoid> <4CC57CD9.8090404@offis.de> <1762848550A84FF4935A843C34E27F78@Hyoid> <4CC58981.8030900@dkfz-heidelberg.de> <81AF149475264B54860EAB098536B5FF@Hyoid> <4CC5ACC9.9050907@dkfz-heidelberg.de> <4CC66C61.70003@dkfz-heidelberg.de> Message-ID: getting closer! As long as I set DCMTK_DIR:PATH to the root of an install path for dcmtk (ie build dcmtk with "mingw32-make install") all the subsequent CMakeCache entries are set up correctly. However, the latest dcmtk I am using from offis's git repository no longer uses "Patients" but uses "Patient" in the defined dcm tags in dcdeftag.h . D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:168: error: 'DCM_Pa tientsName' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:193: error: 'DCM_Pa tientsBirthDate' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:194: error: 'DCM_Pa tientsBirthTime' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:195: error: 'DCM_Pa tientsSex' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:196: error: 'DCM_Pa tientsAge' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:204: error: 'DCM_Pe rformingPhysiciansName' was not declared in this scope D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:205: error: 'DCM_Re ferringPhysiciansName' was not declared in this scope mingw32-make[5]: *** [Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMIndexe r.cpp.obj] Error 1 mingw32-make[4]: *** [Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/all] Error 2 mingw32-make[3]: *** [all] Error 2 mingw32-make[2]: *** [CMakeExternals/Stamp/CTK-build/CTK-build-build] Error 2 mingw32-make[1]: *** [CMakeFiles/CTK-build.dir/all] Error 2 mingw32-make: *** [all] Error 2 I added the following to ctkDICOMIndexer ctkDICOMQuery and ctkDICOMIndexerBase #ifndef DCM_PatientsName #ifdef DCM_PatientName #define DCM_PatientsName DCM_PatientName #endif #endif #ifndef DCM_PatientsBirthDate #ifdef DCM_PatientBirthDate #define DCM_PatientsBirthDate DCM_PatientBirthDate #endif #endif #ifndef DCM_PatientsBirthTime #ifdef DCM_PatientBirthTime #define DCM_PatientsBirthTime DCM_PatientBirthTime #endif #endif #ifndef DCM_PatientsAge #ifdef DCM_PatientAge #define DCM_PatientsAge DCM_PatientAge #endif #endif #ifndef DCM_PatientsSex #ifdef DCM_PatientSex #define DCM_PatientsSex DCM_PatientSex #endif #endif #ifndef DCM_PerformingPhysiciansName #ifdef DCM_PerformingPhysicianName #define DCM_PerformingPhysiciansName DCM_PerformingPhysicianName #endif #endif #ifndef DCM_ReferringPhysiciansName #ifdef DCM_ReferringPhysicianName #define DCM_ReferringPhysiciansName DCM_ReferringPhysicianName #endif #endif which then finally conks out with D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMQuery.cpp: In member function ' void ctkDICOMQuery::query(QSqlDatabase)': D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMQuery.cpp:333: error: no matchi ng function for call to 'DcmSCU::closeAssociation(const OFCondition&)' d:\Developer\Releases\MinGW\SHARED\dcmtkInstall\include/dcmtk/dcmnet/scu.h:272: note: candidates are: virtual void DcmSCU::closeAssociation(DcmCloseAssociationT ype) mingw32-make[5]: *** [Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMQuery. cpp.obj] Error 1 mingw32-make[4]: *** [Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/all] Error 2 mingw32-make[3]: *** [all] Error 2 mingw32-make[2]: *** [CMakeExternals/Stamp/CTK-build/CTK-build-build] Error 2 mingw32-make[1]: *** [CMakeFiles/CTK-build.dir/all] Error 2 mingw32-make: *** [all] Error 2 which is due to dcmtk.git redefining the signature of closeAssociation: /** Different types of closing an association */ enum DcmCloseAssociationType { /// Release the current association DCMSCU_RELEASE_ASSOCIATION, /// Abort the current association DCMSCU_ABORT_ASSOCIATION, /// Peer requested release (Aborting) DCMSCU_PEER_REQUESTED_RELEASE, /// Peer aborted the association DCMSCU_PEER_ABORTED_ASSOCIATION }; virtual void closeAssociation(const DcmCloseAssociationType closeType); whereas there was in dcmtk 3.5.5 virtual void closeAssociation(const OFCondition& abortOrReleaseRequested); So it appears that there are too many differences between dcmtk.git and that used in ctk to make a go of getting DICOM working in CTK with MinGW. Can the dcmtk repository currently associated with CTK be adapted for MinGW until Offis dcmtk.git is aligned with ctk.git? Dean ----- Original Message ----- From: "Sascha Zelzer" To: "Dean Inglis" Cc: Sent: Tuesday, October 26, 2010 1:51 AM Subject: Re: [Ctk-developers] mingw compiles dcmtk.git > Make sure to use the cmake cache in /CTK-build , not > , and to enable something in CTK which uses DCMTK. > > - Sascha > > On 10/26/2010 03:14 AM, Dean Inglis wrote: >> Hi Sascha >> >> Ive installed CMake 2.8.2, specified the external build dir in the >> cmakecache, >> there are no DCMTK_ vars in the advanced section of my cache to set. >> It's odd that I can set and external VTK_DIR and the vtk core gets built. >> >> Dean >> >>> You might also want to try a recent CMake version (> 2.8.0). I think >>> the >>> FindDCMTK.cmake file in those will automatically find the include >>> directories. >>> >>> - Sascha >> >> ----- Original Message ----- >> From: "Sascha Zelzer" >> To: "Dean Inglis" >> Cc: >> Sent: Monday, October 25, 2010 12:14 PM >> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >> >> >>> Well, it seems that the restriction I mentioned in my previous post >>> applies to DCMTK... >>> >>> There is no DCMTKConfig.cmake file in the build tree and the >>> FindDCMTK.cmake file (shipped with CMake) is not able to find the >>> include >>> dirs automatically. However, you should be able to set them manually. >>> Have >>> a look at DCMTK_*_INCLUDE_DIR variables (probably advanced) and set them >>> to the appropriate directories in DCMTKs source tree. >>> >>> - Sascha >>> >>> On 10/25/2010 05:21 PM, Dean Inglis wrote: >>>> Hi Sascha, >>>> >>>> ctk cant find the include paths to the header files even though I have >>>> in >>>> cache >>>> >>>> //No help, variable specified on the command line. >>>> DCMTK_DIR:PATH=d:/Developer/Releases/MinGW/SHARED/dcmtk >>>> >>>> Dean >>>> >>>> Scanning dependencies of target CTKDICOMCore >>>> [ 58%] Building CXX object >>>> Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOM. >>>> cpp.obj >>>> [ 58%] Building CXX object >>>> Libs/DICOM/Core/CMakeFiles/CTKDICOMCore.dir/ctkDICOMI >>>> ndexer.cpp.obj >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:40:36: >>>> error: >>>> dcmtk >>>> /dcmdata/dcfilefo.h: No such file or directory >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:42:36: >>>> error: >>>> dcmtk >>>> /dcmdata/dcdeftag.h: No such file or directory >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:43:36: >>>> error: >>>> dcmtk >>>> /dcmdata/dcdatset.h: No such file or directory >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:44:32: >>>> error: >>>> dcmtk >>>> /ofstd/ofcond.h: No such file or directory >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:45:34: >>>> error: >>>> dcmtk >>>> /ofstd/ofstring.h: No such file or directory >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:46:65: >>>> error: >>>> dcmtk >>>> /ofstd/ofstd.h: No such file or directory >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:47:72: >>>> error: >>>> dcmtk >>>> /dcmdata/dcddirif.h: No such file or directory >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp: In member >>>> function >>>> 'void ctkDICOMIndexer::addDirectory(QSqlDatabase, const QString&, >>>> const >>>> QString >>>> &)': >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >>>> 'OFList' >>>> was not declared in this scope >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >>>> 'OFStrin >>>> g' was not declared in this scope >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:93: error: >>>> 'origina >>>> lDcmtkFileNames' was not declared in this scope >>>> D:\Developer\Sources\CTK\Libs\DICOM\Core\ctkDICOMIndexer.cpp:94: error: >>>> 'dcmtkFi >>>> leNames' was not declared in this scope >>>> >>>> ----- Original Message ----- >>>> From: "Sascha Zelzer" >>>> To: "Dean Inglis" >>>> Cc: >>>> Sent: Monday, October 25, 2010 9:43 AM >>>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>>> >>>> >>>> >>>>> Hi Dean, >>>>> >>>>> you can set DCMTK_DIR to an external DCMTK build tree. Either add the >>>>> variable manually in the CMake GUI or start cmake in an empty build >>>>> directory like: >>>>> >>>>> cmake -DDCMTK_DIR:PATH=/path/to/dcmtk/build/tree >>>>> >>>>> That should work... >>>>> >>>>> - Sascha >>>>> >>>>> On 10/25/2010 03:15 PM, Dean Inglis wrote: >>>>> >>>>>> Ive been submitting an experimental mingw dashboard for a few weeks >>>>>> now, and Id like to have it testing the dcmtk options, however, there >>>>>> is >>>>>> no >>>>>> cmake cache option for using an external dcmtk (yet there is for >>>>>> vtk). >>>>>> Can there either be an intermediate "re-alignment" or a cmake option >>>>>> to use an external dcmtk with an appropriate "do so at your own >>>>>> risk!" >>>>>> warning message? >>>>>> >>>>>> ----- Original Message ----- >>>>>> From: "OFFIS DICOM Team" >>>>>> To: >>>>>> Sent: Monday, October 25, 2010 8:49 AM >>>>>> Subject: Re: [Ctk-developers] mingw compiles dcmtk.git >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> Hi Dean, >>>>>>> >>>>>>> Am 25.10.2010 14:43, schrieb Dean Inglis: >>>>>>> >>>>>>> >>>>>>>> can the latest OFFIS DCMTK git repository be adopted for CTK? >>>>>>>> >>>>>>>> >>>>>>> No, vice versa: The goal is to finally align CTK's DCMTK repository >>>>>>> with >>>>>>> the >>>>>>> official DCMTK repository from OFFIS so CTK is always based on the >>>>>>> latest >>>>>>> official DCMTK code available from OFFIS. Both are already very >>>>>>> similar, >>>>>>> however, that goal is not reached (yet! :-). >>>>>>> >>>>>>> Best regards, >>>>>>> Michael Onken >>>>>>> >>>>>>> -- >>>>>>> OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany >>>>>>> E-Mail: dicom at offis.de, URL: http://dicom.offis.de >>>>>>> _______________________________________________ >>>>>>> Ctk-developers mailing list >>>>>>> Ctk-developers at commontk.org >>>>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>>>>> >>>>>>> >>>>>> _______________________________________________ >>>>>> Ctk-developers mailing list >>>>>> Ctk-developers at commontk.org >>>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>>>> >>>>>> >