[Ctk-developers] GCC visibility flags?

[Jean-Christophe Fillion-Robin]

Hi Folks,

Is there any dashboard where these error are reported ?

Does that sound like a reasonable option:
  - Add visibility flags to Log4Qt and DCMTK ?

Thks
Jc

On Fri, Jul 9, 2010 at 10:15 AM, Luis Ibanez <luis.ibanez at kitware.com>wrote:

>
> We have seen the same warnings on Mac
> (and not when building on Ubuntu).
>
> I looks like it is a Mac issue...,
>
> but It is annoying enough
> that it will be nice to fix it.       :-)
>
>
>     Luis
>
>
> -----------------------------------------------------
>
> On Thu, Jul 8, 2010 at 10:30 PM, Daniel Blezek <daniel.blezek at gmail.com>wrote:
>
>> Sascha,
>>
>>  I just built on linux and didn't have this problem with linking.  Perhaps
>> the flag isn't doing exactly what we expect?  Or is the Mac just more picky?
>>  Can you easily tell?
>>
>> Cheers,
>> -dan
>>
>>
>>
>> On Jul 7, 2010, at 12:52 AM, Sascha Zelzer wrote:
>>
>> > Hi Dan,
>> >
>> > this is the closed issue for the change:
>> >
>> > http://github.com/pieper/CTK/issues/closed#issue/10
>> >
>> > I have not seen any linker wanings on my Linux machine yet, did you
>> introduce new code (and what system are you running)?
>> >
>> > The flags cannot easily be applied to external libraries, since symbols
>> must be prefixed with the appropriate import/export specifiers in the .h
>> files.
>> >
>> > Best,
>> > Sascha
>> >
>> > On 07/07/2010 04:12 AM, Daniel Blezek wrote:
>> >> Hi all,
>> >>
>> >>   Can someone explain this code from the top level CTK CMakeLists.txt
>> file?
>> >>
>> >>
>> #-----------------------------------------------------------------------------
>> >> # Set symbol visibility Flags
>> >> #
>> >> IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
>> >>   SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden
>> -fvisibility-inlines-hidden")
>> >> ENDIF()
>> >>
>> >>
>> >> This causes all sorts of linker warnings because Log4Qt doesn't include
>> the flag and CTK does.
>> >>
>> >> Is this strictly necessary?  If so, can it be applied to the Externals
>> as well?
>> >>
>> >> Thanks,
>> >> -dan
>> >>
>> >> --
>> >> Daniel Blezek
>> >> daniel.blezek at gmail.com
>> >>
>> >>
>> >>
>> >> _______________________________________________
>> >> Ctk-developers mailing list
>> >> Ctk-developers at commontk.org
>> >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>> >>
>> >
>> > _______________________________________________
>> > Ctk-developers mailing list
>> > Ctk-developers at commontk.org
>> > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>
>> --
>> Daniel Blezek
>> daniel.blezek at gmail.com
>>
>>
>>
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at commontk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>


-- 
Phone: 1-518-836-2174
Ext: 304
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20100709/e001a218/attachment.htm>