From daniel.blezek at gmail.com Wed Jul 7 02:12:26 2010 From: daniel.blezek at gmail.com (Daniel Blezek) Date: Tue, 6 Jul 2010 21:12:26 -0500 Subject: [Ctk-developers] GCC visibility flags? Message-ID: Hi all, Can someone explain this code from the top level CTK CMakeLists.txt file? #----------------------------------------------------------------------------- # Set symbol visibility Flags # IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden -fvisibility-inlines-hidden") ENDIF() This causes all sorts of linker warnings because Log4Qt doesn't include the flag and CTK does. Is this strictly necessary? If so, can it be applied to the Externals as well? Thanks, -dan -- Daniel Blezek daniel.blezek at gmail.com From s.zelzer at dkfz-heidelberg.de Wed Jul 7 05:52:40 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Wed, 07 Jul 2010 07:52:40 +0200 Subject: [Ctk-developers] GCC visibility flags? In-Reply-To: References: Message-ID: <4C341628.6010207@dkfz-heidelberg.de> Hi Dan, this is the closed issue for the change: http://github.com/pieper/CTK/issues/closed#issue/10 I have not seen any linker wanings on my Linux machine yet, did you introduce new code (and what system are you running)? The flags cannot easily be applied to external libraries, since symbols must be prefixed with the appropriate import/export specifiers in the .h files. Best, Sascha On 07/07/2010 04:12 AM, Daniel Blezek wrote: > Hi all, > > Can someone explain this code from the top level CTK CMakeLists.txt file? > > #----------------------------------------------------------------------------- > # Set symbol visibility Flags > # > IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") > SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden -fvisibility-inlines-hidden") > ENDIF() > > > This causes all sorts of linker warnings because Log4Qt doesn't include the flag and CTK does. > > Is this strictly necessary? If so, can it be applied to the Externals as well? > > Thanks, > -dan > > -- > Daniel Blezek > daniel.blezek at gmail.com > > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > From daniel.blezek at gmail.com Fri Jul 9 01:35:42 2010 From: daniel.blezek at gmail.com (Daniel Blezek) Date: Thu, 8 Jul 2010 20:35:42 -0500 Subject: [Ctk-developers] GCC visibility flags? In-Reply-To: <4C341628.6010207@dkfz-heidelberg.de> References: <4C341628.6010207@dkfz-heidelberg.de> Message-ID: Hi Sascha, I have link errors on my Mac. Here's an example: ld: warning: unsigned long const& std::min(unsigned long const&, unsigned long const&)has different visibility (default) in /Users/blezek/Source/Isomics/CTK-make/CMakeExternals/Install/lib/libdcmimgle.a(didislut.cxx.o) and (hidden) in CMakeFiles/CTKDICOMCore.dir/moc_ctkDICOMQuery.cxx.o I think this happens primarily because of templates and seems to be mainly confined to the DCMTK and Log4Qt projects. How should I add this to the Externals? Thanks, -dan On Jul 7, 2010, at 12:52 AM, Sascha Zelzer wrote: > Hi Dan, > > this is the closed issue for the change: > > http://github.com/pieper/CTK/issues/closed#issue/10 > > I have not seen any linker wanings on my Linux machine yet, did you introduce new code (and what system are you running)? > > The flags cannot easily be applied to external libraries, since symbols must be prefixed with the appropriate import/export specifiers in the .h files. > > Best, > Sascha > > On 07/07/2010 04:12 AM, Daniel Blezek wrote: >> Hi all, >> >> Can someone explain this code from the top level CTK CMakeLists.txt file? >> >> #----------------------------------------------------------------------------- >> # Set symbol visibility Flags >> # >> IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") >> SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden -fvisibility-inlines-hidden") >> ENDIF() >> >> >> This causes all sorts of linker warnings because Log4Qt doesn't include the flag and CTK does. >> >> Is this strictly necessary? If so, can it be applied to the Externals as well? >> >> Thanks, >> -dan >> >> -- >> Daniel Blezek >> daniel.blezek at gmail.com >> >> >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- Daniel Blezek daniel.blezek at gmail.com From daniel.blezek at gmail.com Fri Jul 9 02:30:14 2010 From: daniel.blezek at gmail.com (Daniel Blezek) Date: Thu, 8 Jul 2010 21:30:14 -0500 Subject: [Ctk-developers] GCC visibility flags? In-Reply-To: <4C341628.6010207@dkfz-heidelberg.de> References: <4C341628.6010207@dkfz-heidelberg.de> Message-ID: Sascha, I just built on linux and didn't have this problem with linking. Perhaps the flag isn't doing exactly what we expect? Or is the Mac just more picky? Can you easily tell? Cheers, -dan On Jul 7, 2010, at 12:52 AM, Sascha Zelzer wrote: > Hi Dan, > > this is the closed issue for the change: > > http://github.com/pieper/CTK/issues/closed#issue/10 > > I have not seen any linker wanings on my Linux machine yet, did you introduce new code (and what system are you running)? > > The flags cannot easily be applied to external libraries, since symbols must be prefixed with the appropriate import/export specifiers in the .h files. > > Best, > Sascha > > On 07/07/2010 04:12 AM, Daniel Blezek wrote: >> Hi all, >> >> Can someone explain this code from the top level CTK CMakeLists.txt file? >> >> #----------------------------------------------------------------------------- >> # Set symbol visibility Flags >> # >> IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") >> SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden -fvisibility-inlines-hidden") >> ENDIF() >> >> >> This causes all sorts of linker warnings because Log4Qt doesn't include the flag and CTK does. >> >> Is this strictly necessary? If so, can it be applied to the Externals as well? >> >> Thanks, >> -dan >> >> -- >> Daniel Blezek >> daniel.blezek at gmail.com >> >> >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- Daniel Blezek daniel.blezek at gmail.com From luis.ibanez at kitware.com Fri Jul 9 14:15:48 2010 From: luis.ibanez at kitware.com (Luis Ibanez) Date: Fri, 9 Jul 2010 10:15:48 -0400 Subject: [Ctk-developers] GCC visibility flags? In-Reply-To: References: <4C341628.6010207@dkfz-heidelberg.de> Message-ID: We have seen the same warnings on Mac (and not when building on Ubuntu). I looks like it is a Mac issue..., but It is annoying enough that it will be nice to fix it. :-) Luis ----------------------------------------------------- On Thu, Jul 8, 2010 at 10:30 PM, Daniel Blezek wrote: > Sascha, > > I just built on linux and didn't have this problem with linking. Perhaps > the flag isn't doing exactly what we expect? Or is the Mac just more picky? > Can you easily tell? > > Cheers, > -dan > > > > On Jul 7, 2010, at 12:52 AM, Sascha Zelzer wrote: > > > Hi Dan, > > > > this is the closed issue for the change: > > > > http://github.com/pieper/CTK/issues/closed#issue/10 > > > > I have not seen any linker wanings on my Linux machine yet, did you > introduce new code (and what system are you running)? > > > > The flags cannot easily be applied to external libraries, since symbols > must be prefixed with the appropriate import/export specifiers in the .h > files. > > > > Best, > > Sascha > > > > On 07/07/2010 04:12 AM, Daniel Blezek wrote: > >> Hi all, > >> > >> Can someone explain this code from the top level CTK CMakeLists.txt > file? > >> > >> > #----------------------------------------------------------------------------- > >> # Set symbol visibility Flags > >> # > >> IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") > >> SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden > -fvisibility-inlines-hidden") > >> ENDIF() > >> > >> > >> This causes all sorts of linker warnings because Log4Qt doesn't include > the flag and CTK does. > >> > >> Is this strictly necessary? If so, can it be applied to the Externals > as well? > >> > >> Thanks, > >> -dan > >> > >> -- > >> Daniel Blezek > >> daniel.blezek at gmail.com > >> > >> > >> > >> _______________________________________________ > >> Ctk-developers mailing list > >> Ctk-developers at commontk.org > >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > >> > > > > _______________________________________________ > > Ctk-developers mailing list > > Ctk-developers at commontk.org > > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- > Daniel Blezek > daniel.blezek at gmail.com > > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Jul 9 14:47:31 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 9 Jul 2010 10:47:31 -0400 Subject: [Ctk-developers] GCC visibility flags? In-Reply-To: References: <4C341628.6010207@dkfz-heidelberg.de> Message-ID: Hi Folks, Is there any dashboard where these error are reported ? Does that sound like a reasonable option: - Add visibility flags to Log4Qt and DCMTK ? Thks Jc On Fri, Jul 9, 2010 at 10:15 AM, Luis Ibanez wrote: > > We have seen the same warnings on Mac > (and not when building on Ubuntu). > > I looks like it is a Mac issue..., > > but It is annoying enough > that it will be nice to fix it. :-) > > > Luis > > > ----------------------------------------------------- > > On Thu, Jul 8, 2010 at 10:30 PM, Daniel Blezek wrote: > >> Sascha, >> >> I just built on linux and didn't have this problem with linking. Perhaps >> the flag isn't doing exactly what we expect? Or is the Mac just more picky? >> Can you easily tell? >> >> Cheers, >> -dan >> >> >> >> On Jul 7, 2010, at 12:52 AM, Sascha Zelzer wrote: >> >> > Hi Dan, >> > >> > this is the closed issue for the change: >> > >> > http://github.com/pieper/CTK/issues/closed#issue/10 >> > >> > I have not seen any linker wanings on my Linux machine yet, did you >> introduce new code (and what system are you running)? >> > >> > The flags cannot easily be applied to external libraries, since symbols >> must be prefixed with the appropriate import/export specifiers in the .h >> files. >> > >> > Best, >> > Sascha >> > >> > On 07/07/2010 04:12 AM, Daniel Blezek wrote: >> >> Hi all, >> >> >> >> Can someone explain this code from the top level CTK CMakeLists.txt >> file? >> >> >> >> >> #----------------------------------------------------------------------------- >> >> # Set symbol visibility Flags >> >> # >> >> IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") >> >> SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden >> -fvisibility-inlines-hidden") >> >> ENDIF() >> >> >> >> >> >> This causes all sorts of linker warnings because Log4Qt doesn't include >> the flag and CTK does. >> >> >> >> Is this strictly necessary? If so, can it be applied to the Externals >> as well? >> >> >> >> Thanks, >> >> -dan >> >> >> >> -- >> >> Daniel Blezek >> >> daniel.blezek at gmail.com >> >> >> >> >> >> >> >> _______________________________________________ >> >> Ctk-developers mailing list >> >> Ctk-developers at commontk.org >> >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> >> > >> > _______________________________________________ >> > Ctk-developers mailing list >> > Ctk-developers at commontk.org >> > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> -- >> Daniel Blezek >> daniel.blezek at gmail.com >> >> >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From s.zelzer at dkfz-heidelberg.de Mon Jul 12 10:04:11 2010 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 12 Jul 2010 12:04:11 +0200 Subject: [Ctk-developers] GCC visibility flags? In-Reply-To: References: <4C341628.6010207@dkfz-heidelberg.de> Message-ID: <4C3AE89B.8080604@dkfz-heidelberg.de> Hi, I do not fully understand the problem yet, but here are some points to discuss: 1.) Log4Qt is already getting compiled with visibility=hidden (see http://github.com/commontk/Log4Qt/blob/patched/CMakeLists.txt), so the error has to be something else 2.) Log4Qt seems to be a static library only. Is this an inherent "feature" of Log4Qt? I feel that this could potentially lead to quite some increase in object size, if the number of shared libraries (plugins) linking to Log4Qt increases a lot in the future. 3.) A google search revealed that quite a few people get the same warnings on a mac for different projects. However, there has been no clear solution, except for modifying compiler flags of external libraries (for std::min<...> this would obviously not work...). We could just add a compiler flag to suppress the warning, if we are sure that it has no side effects. - Sascha On 07/09/2010 04:47 PM, Jean-Christophe Fillion-Robin wrote: > Hi Folks, > > Is there any dashboard where these error are reported ? > > Does that sound like a reasonable option: > - Add visibility flags to Log4Qt and DCMTK ? > > Thks > Jc > > On Fri, Jul 9, 2010 at 10:15 AM, Luis Ibanez > wrote: > > > We have seen the same warnings on Mac > (and not when building on Ubuntu). > > I looks like it is a Mac issue..., > > but It is annoying enough > that it will be nice to fix it. :-) > > > Luis > > > ----------------------------------------------------- > > On Thu, Jul 8, 2010 at 10:30 PM, Daniel Blezek > > wrote: > > Sascha, > > I just built on linux and didn't have this problem with > linking. Perhaps the flag isn't doing exactly what we expect? > Or is the Mac just more picky? Can you easily tell? > > Cheers, > -dan > > > > On Jul 7, 2010, at 12:52 AM, Sascha Zelzer wrote: > > > Hi Dan, > > > > this is the closed issue for the change: > > > > http://github.com/pieper/CTK/issues/closed#issue/10 > > > > I have not seen any linker wanings on my Linux machine yet, > did you introduce new code (and what system are you running)? > > > > The flags cannot easily be applied to external libraries, > since symbols must be prefixed with the appropriate > import/export specifiers in the .h files. > > > > Best, > > Sascha > > > > On 07/07/2010 04:12 AM, Daniel Blezek wrote: > >> Hi all, > >> > >> Can someone explain this code from the top level CTK > CMakeLists.txt file? > >> > >> > #----------------------------------------------------------------------------- > >> # Set symbol visibility Flags > >> # > >> IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") > >> SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden > -fvisibility-inlines-hidden") > >> ENDIF() > >> > >> > >> This causes all sorts of linker warnings because Log4Qt > doesn't include the flag and CTK does. > >> > >> Is this strictly necessary? If so, can it be applied to > the Externals as well? > >> > >> Thanks, > >> -dan > >> > >> -- > >> Daniel Blezek > >> daniel.blezek at gmail.com > >> > >> > >> > >> _______________________________________________ > >> Ctk-developers mailing list > >> Ctk-developers at commontk.org > > >> > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > >> > > > > _______________________________________________ > > Ctk-developers mailing list > > Ctk-developers at commontk.org > > > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- > Daniel Blezek > daniel.blezek at gmail.com > > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > > > > -- > Phone: 1-518-836-2174 > Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Tue Jul 20 14:14:26 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Tue, 20 Jul 2010 10:14:26 -0400 Subject: [Ctk-developers] Convert commontk github into Organization Message-ID: Hi Folks, Github provide with a very convenient feature: organization See http://github.com/blog/674-introducing-organizations If there is no objection, I plan to convert user "commontk" into an organization. It's very easy and can be done if you "mouse-click" :) Note: ITKv4 and Slice4 github are created as organization. Thks Jc -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Tue Jul 20 23:18:47 2010 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Tue, 20 Jul 2010 19:18:47 -0400 Subject: [Ctk-developers] Convert commontk github into Organization In-Reply-To: References: Message-ID: Hi Folks, Commontk has been successfully converted to an organization :) It means the user 'commontk' doesn't exist anymore. After you click on the Dashboard link on the top, you should see a button named "Switch context" ! If you want to learn more about organization within github, please review the following document: http://github.com/blog/674-introducing-organizations Note that your push access to CTK has been maintained. Nevertheless, if there are any unexpected problems, let me know. Thks Jc On Tue, Jul 20, 2010 at 10:14 AM, Jean-Christophe Fillion-Robin < jchris.fillionr at kitware.com> wrote: > Hi Folks, > > Github provide with a very convenient feature: organization > > See http://github.com/blog/674-introducing-organizations > > If there is no objection, I plan to convert user "commontk" into an > organization. It's very easy and can be done if you "mouse-click" :) > > Note: ITKv4 and Slice4 github are created as organization. > > Thks > Jc > > -- > Phone: 1-518-836-2174 > Ext: 304 > -- Phone: 1-518-836-2174 Ext: 304 -------------- next part -------------- An HTML attachment was scrubbed... URL: