[Ctk-developers] CTK Dashboard: A DICOM data collection for testing ?

Mon Apr 12 17:00:52 UTC 2010

That sound wonderful!

Also, experience tell me that having sample images from multiple scanners (different ages or versions) from multiple vendors is useful.  Even though everyone uses the DICOM standard, sometimes people utilize different combinations of features from the standard.  (This is a nice way of saying not everyone interprets the standard in compatible fashions.)  So having lots of variations is helpful in ferreting out potential problems during testing.  Does anyone have such a collection?  If not, I can ask Steve Moore when he gets back if some of the data collected during the IHE Connectathons could be used.

-----Original Message-----
From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Bill Lorensen
Sent: Monday, April 12, 2010 10:20 AM
To: Steve Pieper
Cc: ctk-developers at commontk.org
Subject: Re: [Ctk-developers] CTK Dashboard: A DICOM data collection for testing ?

Folks,

I have a set of 6 dicom series that scan the same phantom in six
different directions. I'll be happy to contribute these. They were
created a few years ago at GE Research as part of our NA-MIC work.
They are useful to see if your code properly handles the direction
cosines contained in the dicom header.

Bill

On Mon, Apr 12, 2010 at 10:30 AM, Steve Pieper <pieper at bwh.harvard.edu> wrote:
>
> Hi Luis -
>
> Here are some sharable example dicom files that we have been using to test
> the indexer:
>
> http://www.slicer.org/slicerWiki/index.php/File:Dicom-database-examples-2010-03-09.zip
>
> (note this also includes some non-dicom files - but this is good for
> testing!).
>
> It would be great for ctest to automatically grab these files from a URL and
> put them in a local cache for testing purposes.  We could either use the
> existing wiki URL or move them to midas...
>
> -Steve
>
>
>
> p.s.
> There's some discussion of the indexer here for background:
>
> http://www.slicer.org/slicerWiki/index.php/DICOM:Database
>
>
> p.p.s. thanks, Luis, for being the voice of code quality!
>
>
>
> On Apr/9/10 10:45 AM, Luis Ibanez wrote:
>>
>> Hi Marco,
>>
>>
>> Thanks for taking on the task of improving code quality.
>>
>>
>> Here are a couple of ideas:
>>
>> 1) In IGSTK we included a couple of DICOM files in the
>>     source code repository itself in order to provide testing
>>     of basic functionalities.  This is  OK for "Unit-Testing".
>>     (and has to be limited to a couple of slices, since you
>>     don't want a source code repository to carry more than
>>     10% of data.
>>
>>     This simple data, however, insufficient for "Acceptance-Tests"
>>     (that is, tests that verify the code under realistic conditions
>>     from the point of view of a final user).
>>
>> so
>>
>> 2) We could host a set of realistic DICOM series in the MIDAS
>>     server, and setup CMake to download them into testing
>>     machines as part of the superbuild. It will be important to
>>     include in that collection, a set of "bad" datasets that exercise
>>     error conditions in the code.
>>
>>     That is, we want to include DICOM images that are not compliant,
>>     and we want to verify that the code rejects them accordingly.
>>
>>
>>
>> Does DMTK has a data-testing collection that we could use ?
>>
>> and if so, it is redistributable ?
>>
>>
>>
>>     Luis
>>
>>
>> ---------------------------------------------------------------------------
>> On Fri, Apr 9, 2010 at 10:36 AM, Marco Nolden
>> <m.nolden at dkfz-heidelberg.de>  wrote:
>>>
>>> On 04/09/2010 04:21 PM, Luis Ibanez wrote:
>>>
>>> The dubious honor of being the WCFOD:
>>>
>>>                Worst Code-Covered File of the Day
>>>
>>>
>>>
>>>
>>> http://my.cdash.org/viewCoverage.php?buildid=58100
>>>
>>>
>>>
>>>
>>>
>>> Hi,
>>>
>>> 2nd on that list is ./Libs/DICOM/Core/ctkDICOMIndexer.cxx, the one I
>>> would
>>> take care of.. To write a meaningful test the dartclient needs access to
>>> a
>>> directory containing dicom images from several different patients,
>>> studies
>>> and series. Any ideas how we could provide that? Could the superbuild
>>> download and extract the sample archive before running the tests?
>>>
>>> Best
>>> Marco
>>>
>>>
>>>
>>>
>>> Does anyone cares about adopting this file ?
>>>
>>>
>>> Otherwise we will write tests for it today
>>> under the code-welfare program.
>>>
>>>
>>>    Please let me know,
>>>
>>>
>>>           Thanks
>>>
>>>
>>>                Luis
>>> _______________________________________________
>>> Ctk-developers mailing list
>>> Ctk-developers at commontk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>>
>>>
>>> --
>>> ----------------------------------------------------------------------
>>> Dipl.-Inform. Med. Marco Nolden
>>> Deutsches Krebsforschungszentrum       (German Cancer Research Center)
>>> Div. Medical&  Biological Informatics          Tel: (+49) 6221-42 2325
>>> Im Neuenheimer Feld 280                        Fax: (+49) 6221-42 2345
>>> D-69120 Heidelberg                             eMail: M.Nolden at dkfz.de
>>>
>>> _______________________________________________
>>> Ctk-developers mailing list
>>> Ctk-developers at commontk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>>
>>>
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at commontk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
_______________________________________________
Ctk-developers mailing list
Ctk-developers at commontk.org
http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers

The material in this message is private and may contain Protected Healthcare Information (PHI).  If you are not the intended recipient, be advised that any unauthorized use, disclosure, copying or the taking of any action in reliance on the contents of this information is strictly prohibited.  If you have received this email in error, please immediately notify the sender via telephone or return mail.