[Ctk-developers] CTK Dashboard: A DICOM data collection for testing ?
Luis Ibanez
luis.ibanez at kitware.com
Fri Apr 9 14:45:15 UTC 2010
Hi Marco,
Thanks for taking on the task of improving code quality.
Here are a couple of ideas:
1) In IGSTK we included a couple of DICOM files in the
source code repository itself in order to provide testing
of basic functionalities. This is OK for "Unit-Testing".
(and has to be limited to a couple of slices, since you
don't want a source code repository to carry more than
10% of data.
This simple data, however, insufficient for "Acceptance-Tests"
(that is, tests that verify the code under realistic conditions
from the point of view of a final user).
so
2) We could host a set of realistic DICOM series in the MIDAS
server, and setup CMake to download them into testing
machines as part of the superbuild. It will be important to
include in that collection, a set of "bad" datasets that exercise
error conditions in the code.
That is, we want to include DICOM images that are not compliant,
and we want to verify that the code rejects them accordingly.
Does DMTK has a data-testing collection that we could use ?
and if so, it is redistributable ?
Luis
---------------------------------------------------------------------------
On Fri, Apr 9, 2010 at 10:36 AM, Marco Nolden
<m.nolden at dkfz-heidelberg.de> wrote:
> On 04/09/2010 04:21 PM, Luis Ibanez wrote:
>
> The dubious honor of being the WCFOD:
>
> Worst Code-Covered File of the Day
>
>
>
>
> http://my.cdash.org/viewCoverage.php?buildid=58100
>
>
>
>
>
> Hi,
>
> 2nd on that list is ./Libs/DICOM/Core/ctkDICOMIndexer.cxx, the one I would
> take care of.. To write a meaningful test the dartclient needs access to a
> directory containing dicom images from several different patients, studies
> and series. Any ideas how we could provide that? Could the superbuild
> download and extract the sample archive before running the tests?
>
> Best
> Marco
>
>
>
>
> Does anyone cares about adopting this file ?
>
>
> Otherwise we will write tests for it today
> under the code-welfare program.
>
>
> Please let me know,
>
>
> Thanks
>
>
> Luis
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
> --
> ----------------------------------------------------------------------
> Dipl.-Inform. Med. Marco Nolden
> Deutsches Krebsforschungszentrum (German Cancer Research Center)
> Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325
> Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345
> D-69120 Heidelberg eMail: M.Nolden at dkfz.de
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
More information about the Ctk-developers
mailing list