[Ctk-developers] CTK Dashboard: Cleaning up Warnings: DCMTK

[Luis Ibanez]

Excellent,

Here they are:

/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:
In constructor ‘log4cplus::spi::InternalLoggingEvent::InternalLoggingEvent(const
log4cplus::tstring&, log4cplus::LogLevel, const log4cplus::tstring&,
const char*, int)’:
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:56:
warning: declaration of ‘line’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:56:
warning: declaration of ‘message’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:56:
warning: declaration of ‘ll’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:
In constructor ‘log4cplus::spi::InternalLoggingEvent::InternalLoggingEvent(const
log4cplus::tstring&, log4cplus::LogLevel, const log4cplus::tstring&,
const log4cplus::tstring&, const log4cplus::tstring&,
log4cplus::helpers::Time, const log4cplus::tstring&, int)’:
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:79:
warning: declaration of ‘line’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:79:
warning: declaration of ‘file’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:79:
warning: declaration of ‘thread’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:79:
warning: declaration of ‘message’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:79:
warning: declaration of ‘ndc’ shadows a member of 'this'
/home/ibanez/bin/CTK/Debug/CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h:79:
warning: declaration of ‘ll’ shadows a member of 'this'


    Luis




On Thu, Apr 8, 2010 at 5:22 PM, Stephen Aylward
<stephen.aylward at kitware.com> wrote:
> The DCMTK folks are key participants in CTK.
>
> I'm guessing they can fix those...
>
> s
>
> On Thu, Apr 8, 2010 at 5:14 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>> In the process of cleaning up warnings in the Dashboard,
>> we ran into issues with DCMTK:
>>
>> CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h
>>
>>  warning: declaration of ‘message’ shadows a member of 'this'
>>  warning: declaration of ‘ll’ shadows a member of 'this'
>>
>>
>> Given that DCMTK is a third party library, our options for
>> fixing this are:
>>
>>
>> A) Post a patch to the DCMTK developers and wait for
>>     them to push that into a release
>>
>> B) Host a duplicate repository of DCMTK and make the
>>    patches there
>>
>> C) Silence the warning using CTestCustom.cmake
>>     (put the problem under the rug..)
>>
>>
>>
>>  What are your preferences ?
>>
>>
>>      Thanks
>>
>>
>>          Luis
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at commontk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>
>
>
>
> --
> Stephen R. Aylward, Ph.D.
> Director of Medical Imaging Research
> Kitware, Inc. - North Carolina Office
> http://www.kitware.com
> stephen.aylward (Skype)
> (919) 969-6990 x300
>