[ITK] New Bruker module not exposed correctly

[Wood, Tobias]

Thanks guys - I’ve pushed a patch to Gerrit and added you as reviewers.

Toby

On 20/09/2017, 14:25, "Jon Haitz Legarreta" <jhlegarreta at vicomtech.org<mailto:jhlegarreta at vicomtech.org>> wrote:

+1 for Matt's proposal.
JON HAITZ



--

On 20 September 2017 at 15:16, Matt McCormick <matt.mccormick at kitware.com<mailto:matt.mccormick at kitware.com>> wrote:
Hi Toby,

Thanks again for the contribution.

Yes, a small follow-up patch in UseITK.cmake will do the trick. For a
large addition like this, some follow-up effort is expected.

In my opinion, "2dseq" is obscure enough that the addition of "Bruker"
helps identify the class.

Thanks,
Matt

On Wed, Sep 20, 2017 at 8:43 AM, Wood, Tobias <tobias.wood at kcl.ac.uk<mailto:tobias.wood at kcl.ac.uk>> wrote:
> Hello,
>
> I updated my local copy of ITK to master to test my Bruker patch that was merged a couple of weeks ago. Unfortunately my patch did not change the UseITK.cmake to follow the new name of the module (it was suggested to me that the module name be shortened in case of anymore Bruker formats), so the Bruker reader is not correctly registered.
>
> I think I have worked out the required changes to UseITK.cmake, so can submit a patch. However, this raises the question of whether the naming scheme could be rationalized further. Before, both module and class were called “Bruker2DSEQ”. The module is now “Bruker”, and the class is “Bruker2dseq”, which is the correct capitalisation for the format. Should the class/format be shortened to just “2dseq”?
>
> I’m sorry not to catch this before my original patch was merged. Changing the name was one of the last things I did, and because the tests explicitly register the ImageIOFactory, they would not pick this up.
>
> Best wishes,
> Toby
>
> _______________________________________________
> Community mailing list
> Community at itk.org<mailto:Community at itk.org>
> http://public.kitware.com/mailman/listinfo/community<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpublic.kitware.com%2Fmailman%2Flistinfo%2Fcommunity&data=01%7C01%7Ctobias.wood%40kcl.ac.uk%7C94f0e797bf884af63bd708d5002b2c49%7C8370cf1416f34c16b83c724071654356%7C0&sdata=t%2BXOpQcFsw5U20AZmmu8%2B%2B5dgCtavYRRj7%2BBM5nGYIs%3D&reserved=0>
_______________________________________________
Community mailing list
Community at itk.org<mailto:Community at itk.org>
http://public.kitware.com/mailman/listinfo/community<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpublic.kitware.com%2Fmailman%2Flistinfo%2Fcommunity&data=01%7C01%7Ctobias.wood%40kcl.ac.uk%7C94f0e797bf884af63bd708d5002b2c49%7C8370cf1416f34c16b83c724071654356%7C0&sdata=t%2BXOpQcFsw5U20AZmmu8%2B%2B5dgCtavYRRj7%2BBM5nGYIs%3D&reserved=0>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/community/attachments/20170921/1ebf20c9/attachment-0001.html>