[ITK] How to avoid NIFTI header files from being installed?

Niels Dekker niels-xtk at xs4all.nl
Tue Sep 19 15:08:23 EDT 2017


>> However, I wouldn't like to have so much duplicate code. The amount of 
>> code
>> duplication could be reduced by replacing my 'NiftiImageHolder' class 
>> by
>> std::unique_ptr<NiftiImageProxy>. Is it OK to use std::unique_ptr in 
>> the ITK
>> code base? It's basically the most lightweight smart pointer of the 
>> Standard
>> C++ Library but I don't see it being used by ITK.

On 2017-09-19 16:24, Matt McCormick wrote:
> ITK currently supports compilers without C++11 availability, which is
> why std::unique_ptr is not used. itk::AutoPointer could be used an
> alternative

Thanks for the suggestion, Matt! Please have a look:

   STYLE: Replaced NiftiImageHolder by AutoPointer
   http://review.source.kitware.com/#/c/22644/1

And more importantly:

   COMP: Fixed "gifti_io.h" leak into user code
   COMP: No longer installing nifti header files by default

See http://review.source.kitware.com/#/c/22644


Kind regards, Niels
-- 
Niels Dekker
Scientific programmer
LKEB, Leiden University Medical Center, Netherlands


More information about the Community mailing list