[ITK] [ITK-dev] Name mangling for niftilib (Modules/ThirdParty/NIFTI)?

[Niels Dekker]

Thanks for your encouraging reply, Matt! My colleague Floris Berendsen 
has just submitted the patch:

   COMP: add symbol name mangling for niftilib in ITK
   http://review.source.kitware.com/#/c/22450/

Kind regards, Niels

Matt McCormick wrote on 2017-06-15:
> Hi Neils,
> 
> Yes, name mangling for nifti is welcome. Please contribute the patch
> as described here:
> 
>   https://itk.org/Wiki/ITK/Git/Develop
> 
> and let us know if you have any questions.
> 
> Thanks,
> Matt
> 
> On Thu, Jun 15, 2017 at 6:06 AM, Niels Dekker <niels-xtk at xs4all.nl>
> wrote:
> 
>> Our project links to both ITK and the NiftyReg library (*), and
>> thereby indirectly to two different versions of the niftilib library
>> that have the same binary interface. To avoid potential link errors
>> and unexpected run-time behavior, could there be name mangling added
>> to ITK's niftilib version, at
>> Modules/ThirdParty/NIFTI/src/nifty/niftilib?
>> 
>> We would suggest an approach according to the existing ITK third
>> party name mangling practice, e.g., by "itk_png_mangle.h", and
>> "itk_zlib_mangle.h".
>> 
>> We already have a patch for ITK within our project, SuperElastix, at
>> 
> https://raw.githubusercontent.com/SuperElastix/SuperElastix/c94d65bef1b0fe368b194bbf4de8ccd505a873b0/SuperBuild/Patches/itk_nifti_mangle.patch
>> [1]
>> 
>> Kind regards, also on behalf of Floris ,
>> 
>> Niels
>> 
>> (*) The NiftyReg library is from
>> https://cmiclab.cs.ucl.ac.uk/mmodat/niftyreg [2]


-- 
Niels Dekker
Scientific programmer
LKEB, Leiden University Medical Center, Netherlands
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/insight-developers