[ITK] Wrapping warnings (deprecated code)

[Matt McCormick]

Hi Brad,

I agree.  Here is an alternative patch:

  http://review.source.kitware.com/#/c/15685

Thanks,
Matt

On Fri, Jun 6, 2014 at 6:00 PM, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
> Matt,
>
> I think we should only silence these warnings with ITK_LEGACY_SILENCE. And that this should not be forces set when wrapITK is enables, but an intelligent initial value given.
>
> A user of wrap ITK should have the ability to use legacy code and not require them to upgrade. Additionally, I oppose setting such a option and having no way for a user to override it.
>
> -DITK_LEGACY_SILENCE:BOOL=ON should be added to nightly builds.
>
> Brad
>
> On Jun 6, 2014, at 5:31 PM, Matt McCormick <matt.mccormick at kitware.com> wrote:
>
>> Hi Michka,
>>
>> I think we should consider requiring ITK_LEGACY_REMOVE to be ON when
>> wrapping is enabled.
>>
>> Here is a patch:
>>
>>  http://review.source.kitware.com/#/c/15682/
>>
>> Still working on testing it with wrapping ON.
>>
>> Thanks,
>> Matt
>>
>> On Fri, Jun 6, 2014 at 4:57 PM, Michka Popoff <michkapopoff at gmail.com> wrote:
>>> Hi
>>>
>>> I was looking at the warnings on the dashboard for the wrapping build:
>>> http://open.cdash.org/viewBuildError.php?type=1&buildid=3361082
>>>
>>> We got stuff like:
>>> BackTransform(const typename itk::MatrixOffsetTransformBase<TScalar, 3u, 3u>::OutputPointType&) const [with TScalar = double]' is deprecated
>>>
>>> I found this old topic:
>>> http://comments.gmane.org/gmane.comp.lib.itk.devel/402
>>>
>>> What was finally done after this discussion ?
>>> Bradley Lowekamp, what has been your choice in SimpleITK for deprecated code ?
>>> Do you keep the old deprecated methods or do you only provide the newest ones ?
>>>
>>>
>>> Michka
>>> _______________________________________________
>>> Community mailing list
>>> Community at itk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/community
>> _______________________________________________
>> Community mailing list
>> Community at itk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/community
>