[ITK] Wrapping warnings (deprecated code)

Matt McCormick matt.mccormick at kitware.com
Fri Jun 6 18:53:07 EDT 2014


Hi Michka,

Great observation.  I created a patch to get rid of CSWIG here:

http://review.source.kitware.com/#/c/15686/

Thanks,
Matt

On Fri, Jun 6, 2014 at 5:45 PM, Michka Popoff <michkapopoff at gmail.com> wrote:
> Nice changes. I stumbled upon this part of the code and already thought of improving it :)
>
> In this case, we do no more need to pass -DCSwig to gccxml:
> https://github.com/InsightSoftwareConsortium/ITK/blob/master/Wrapping/Generators/GccXML/CMakeLists.txt#L136
> https://github.com/InsightSoftwareConsortium/ITK/blob/master/Wrapping/Generators/GccXML/CMakeLists.txt#L149
>
> which should have triggered the code here (there are more CSWIG in if/defs in this file):
> https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/Common/include/itkMacro.h#L419
>
> Michka
>
> On 6 juin 2014, at 23:31, Matt McCormick <matt.mccormick at kitware.com> wrote:
>
>> Hi Michka,
>>
>> I think we should consider requiring ITK_LEGACY_REMOVE to be ON when
>> wrapping is enabled.
>>
>> Here is a patch:
>>
>>  http://review.source.kitware.com/#/c/15682/
>>
>> Still working on testing it with wrapping ON.
>>
>> Thanks,
>> Matt
>>
>> On Fri, Jun 6, 2014 at 4:57 PM, Michka Popoff <michkapopoff at gmail.com> wrote:
>>> Hi
>>>
>>> I was looking at the warnings on the dashboard for the wrapping build:
>>> http://open.cdash.org/viewBuildError.php?type=1&buildid=3361082
>>>
>>> We got stuff like:
>>> BackTransform(const typename itk::MatrixOffsetTransformBase<TScalar, 3u, 3u>::OutputPointType&) const [with TScalar = double]' is deprecated
>>>
>>> I found this old topic:
>>> http://comments.gmane.org/gmane.comp.lib.itk.devel/402
>>>
>>> What was finally done after this discussion ?
>>> Bradley Lowekamp, what has been your choice in SimpleITK for deprecated code ?
>>> Do you keep the old deprecated methods or do you only provide the newest ones ?
>>>
>>>
>>> Michka
>>> _______________________________________________
>>> Community mailing list
>>> Community at itk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/community
>



More information about the Community mailing list