[ITK] [ITK-dev] New clang warnings: reserved-id-macro

[Brad King]

On 12/11/2014 12:48 PM, Sean McBride wrote:
> C & C++ in fact reserve double underscores:

Yes.

> KWSys, CMake

KWSys and CMake do not use "__" guards AFAIK.  It looks like
there might be a couple in CMake by accident.

> VTK, and ITK all seem to have the same naming scheme
> for header guard #defines, namely "__<project><filename>_h",
> ex: __itkMacro_h, __vtkFooBar_h, etc.

Yes, and this does step on the namespace reserved for the
C and C++ implementations.

> I volunteer to make the changes, but we should agree on a scheme.

Thanks!

> Maybe just drop the __ prefix would be enough.

Yes.

> Could throw another _ at the end too perhaps.

They all end in "_h" or something already, so that should not
be needed.

Thanks,
-Brad K
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/insight-developers