[ITK] [ITK-dev] VtkGlue module -- strange configuration.

[Michka Popoff]

Hi

moving this to the new community mailing list.

I made a patch some days ago fixing a bug for old VTK versions under 5.5, where VTK_VERSION was not defined, but that is another topic I think.
https://github.com/InsightSoftwareConsortium/ITK/commit/1f41404903e50102c2ed5271d9caeec41807d014

This minimal version you see was introduced here:
https://github.com/InsightSoftwareConsortium/ITK/commit/913e2164cca521f791aac6d20bce34cba9831e96

I guess we could just set VERSION_MIN to 5.10.0, and make a fix for ITK 4.6.1.

Michka


On 11 août 2014, at 18:49, Williams, Norman K <norman-k-williams at uiowa.edu> wrote:

> I’ve been messing with making the VtkGlue module use a more specific signature for find_package(VTK)*
> 
> In ITK/Modules/Bridge/VtkGlue/itk-module-init.cmake there’s this:
> 
> set(VERSION_MIN "5.9.20110419")
> 
> … which as far as I can tell is nonsense; I checked out the VTK version from April 19th 2011, and the VTK version is set to be 5.9.0
> 
> I don’t think the VTK_BUILD_VERSION would ever be set to a specific date stamp.
> 
> What is required — in order to use find_package(VTK COMPONENTS …) -- would be the first revision after VTK Modularization was working.  And in fact, given how VTK sets its version numbers — hard coded in the top level CMakeLists.txt — I don’t even know how that would work.
> 
> Any ideas?
> 
> *This is an outgrowth of the work I’m doing on tailoring BRAINSTools’ dependency processing in CMake for Slicer inclusion.  Specifically, rather than use find_package(ITK REQUIRED) use find_package(ITK COMPONENTS … REQUIRED) — this only adds the include paths (to compiles) and libraries (to link commangs) actually used by the specific programs.  There’s no find_package(ITK) at the top level of the build tree; there’s a specific find_package in each subdirectory that only requests the COMPONENTS actually referenced.
> 
> 
> 
> 
> 
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
> _______________________________________________
> Community mailing list
> Community at itk.org
> http://public.kitware.com/mailman/listinfo/community

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/community/attachments/20140811/54a9f8cb/attachment-0002.html>