[ITK Community] [Insight-developers] Is dashboard hackathon still needed?

Bradley Lowekamp blowekamp at mail.nih.gov
Tue Dec 17 19:58:05 EST 2013 

I ran valgrind with just MINCIO module turned on:
http://open.cdash.org/viewDynamicAnalysis.php?buildid=3142879

It looks like there are a couple issue that should be addressed there as well.

Brad

On Dec 17, 2013, at 4:42 PM, Vladimir S. FONOV <vladimir.fonov at gmail.com> wrote:

> 
> So,
> 
> what's the current status ? Is there are warnings on official ITK build dashboard that have to be addressed right now?
> 
> (Apart from M_PI issue on Visual Studio) ?
> 
> On 13-12-17 04:36 PM, Matt McCormick wrote:
>> On Tue, Dec 17, 2013 at 4:15 PM, Vladimir S. FONOV
>> <vladimir.fonov at gmail.com> wrote:
>>> So, this approach actually have nothing to do with the question if feature
>>> is actually needed or not?
>>> 
>> 
>> This feature definitely adds huge value both to ITK and the medical
>> imaging community in general.
>> 
>>> I suggest a new radical solution - remove all the features from ITK, then
>>> you will have a perfectly clean and neat dashboard and nothing to worry
>>> about
>> 
>> That would be very sad.
>> 
>> The objective is get the Nightly dashboard builds all green, then the
>> CDash at Home builds green with this feature enabled.  This way, if
>> something unrelated to MINCIO is added but breaks MINCIO, it is
>> noticed and fixed by the author.  Getting and keeping the dashboard
>> clean is way to prevent everyone from breaking each other's code so
>> that we all benefit from each others work.
>> 
>> Thank you for all the work that has been put into the ITK-MINC
>> integration.  It is highly valued.  With these improvements, your
>> maintenance burden will be reduced.
>> 
>> Thanks,
>> Matt
>> 
>> 
>>> 
>>> 
>>> 
>>> On 13-12-17 03:59 PM, Johnson, Hans J wrote:
>>>> 
>>>> If warnings persist, that feature in ITK will be placed into a deprecated
>>>> status, and will be prime material to remove in future releases.
>>>> 
>>>> It does not necessarily need to be you, but in a community development
>>>> environment, if the there is not sufficient support for removing compiler
>>>> warnings that is a strong statement about the lack of importance for that
>>>> component of the toolkit in future versions.
>>>> 
>>>> I understand the that there are never enough resources.  Please try to
>>>> recruit a fan-base of others who feel this is an important part of ITK and
>>>> that they should address the issues that you can not.
>>>> 
>>>> Hans
>>>> 
>>>> -----Original Message-----
>>>> From: "Vladimir S. FONOV" <vladimir.fonov at gmail.com>
>>>> Date: Tuesday, December 17, 2013 2:55 PM
>>>> To: Bill Lorensen <bill.lorensen at gmail.com>, Hans Johnson
>>>> <hans-johnson at uiowa.edu>
>>>> Cc: Sean McBride <sean at rogue-research.com>, ITK
>>>> <insight-developers at itk.org>
>>>> Subject: Re: [Insight-developers] [ITK Community] Is dashboard hackathon
>>>> still needed?
>>>> 
>>>> OK,
>>>> 
>>>> I personally have a situation when I have to allocate limited resources
>>>> (my time) between different projects, not all of them being software
>>>> development.
>>>> 
>>>> So, convince me why I have to spend any more time on this particular
>>>> project then absolutely necessary.
>>>> 
>>>> By the way, did anybody actually verify that my changes actually solve
>>>> original problem (i.e compilation for Windows) instead of
>>>> procrastinating and fixing compiler warnings ?
>>>> 
>>>> 
>>>> On 13-12-17 03:46 PM, Bill Lorensen wrote:
>>>>> 
>>>>> A few years back at a NA_MIC project Week in SLC, I suggested that
>>>>> warnings are the graffiti of software quality. Here is a summary:
>>>>> 
>>>>> The book, The Tipping Point, analyses trends and how they take hold.
>>>>> As (NAME YOUR SOFTWARE) grows and the number of contributors
>>>>> increases, there needs to be tighter controls on the quality of the
>>>>> system. The larger the code base, number of platforms and developers,
>>>>> the more need there is for attention to quality.
>>>>> 
>>>>> In the Tipping Point, a chapter on increasing crime in New York City
>>>>> in the 1990's describes how the trend was reversed. The city
>>>>> concentrated areas like cleaning graffiti from subway cars. The author
>>>>> claims that this and other seemingly trivial goals may have led to a
>>>>> reversal of the crime trend.
>>>>> 
>>>>> This project hypothesizes that compilation warnings are the graffiti
>>>>> of software quality. A lack of attention to this seemingly trivial
>>>>> goal shows a lack of attention to the overall quality of software.
>>>>> This project will reduce warnings to zero for a popular c++
>>>>> compiler,(NAME YOUR COMPILER).
>>>>> 
>>>>> 
>>>>> On Tue, Dec 17, 2013 at 3:36 PM, Johnson, Hans J
>>>>> <hans-johnson at uiowa.edu> wrote:
>>>>>> 
>>>>>> ABSOLUTELY THEY MUST BE FIXED!
>>>>>> 
>>>>>> A tremendous amount of developer energy used in maintaining code that
>>>>>> has
>>>>>> warnings.  The cost of software maintenance is substantially reduce when
>>>>>> warnings are removed.
>>>>>> 
>>>>>> It is my experience that warnings VERY highly correlated with real bugs.
>>>>>> 
>>>>>> Hans
>>>>>> 
>>>>>> 
>>>>>> -----Original Message-----
>>>>>> From: "Vladimir S. FONOV" <vladimir.fonov at gmail.com>
>>>>>> Date: Tuesday, December 17, 2013 2:28 PM
>>>>>> To: Sean McBride <sean at rogue-research.com>
>>>>>> Cc: ITK <insight-developers at itk.org>
>>>>>> Subject: Re: [Insight-developers] [ITK Community] Is dashboard hackathon
>>>>>> still needed?
>>>>>> 
>>>>>> Hello,
>>>>>> 
>>>>>> 
>>>>>> do we really have to fix warnings at this stage? I.e everything else
>>>>>> actually compiles?
>>>>>> 
>>>>>> On 13-12-17 03:05 PM, Sean McBride wrote:
>>>>>>> 
>>>>>>> Hi all,
>>>>>>> 
>>>>>>> As for the MINC compiler warnings... I've fixed a bunch in my github
>>>>>>> fork, Vlad can you review and merge?
>>>>>>> 
>>>>>>> <https://github.com/seanm/libminc/tree/develop>
>>>>>>> 
>>>>>>> I've also disabled a bunch of others, because they are a long term
>>>>>>> project...
>>>>>>> 
>>>>>>> Cheers,
>>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> Best regards,
>>>>>> 
>>>>>>    Vladimir S. FONOV ~ vladimir.fonov <at> gmail.com
>>>>>> _______________________________________________
>>>>>> Powered by www.kitware.com
>>>>>> 
>>>>>> Visit other Kitware open-source projects at
>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>> 
>>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>>> http://kitware.com/products/protraining.php
>>>>>> 
>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>> 
>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> ________________________________
>>>>>> Notice: This UI Health Care e-mail (including attachments) is covered
>>>>>> by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>>>> confidential and may be legally privileged.  If you are not the intended
>>>>>> recipient, you are hereby notified that any retention, dissemination,
>>>>>> distribution, or copying of this communication is strictly prohibited.
>>>>>> Please reply to the sender that you have received the message in error,
>>>>>> then delete it.  Thank you.
>>>>>> ________________________________
>>>>>> _______________________________________________
>>>>>> Powered by www.kitware.com
>>>>>> 
>>>>>> Visit other Kitware open-source projects at
>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>> 
>>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>>> http://kitware.com/products/protraining.php
>>>>>> 
>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>> 
>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> Best regards,
>>>> 
>>>>   Vladimir S. FONOV ~ vladimir.fonov <at> gmail.com
>>>> 
>>>> 
>>>> 
>>>> ________________________________
>>>> Notice: This UI Health Care e-mail (including attachments) is covered by
>>>> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>> confidential and may be legally privileged.  If you are not the intended
>>>> recipient, you are hereby notified that any retention, dissemination,
>>>> distribution, or copying of this communication is strictly prohibited.
>>>> Please reply to the sender that you have received the message in error, then
>>>> delete it.  Thank you.
>>>> ________________________________
>>>> 
>>> 
>>> 
>>> --
>>> Best regards,
>>> 
>>> Vladimir S. FONOV ~ vladimir.fonov <at> gmail.com
>>> _______________________________________________
>>> Powered by www.kitware.com
>>> 
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>> 
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.php
>>> 
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>> 
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>> _______________________________________________
>>> Community mailing list
>>> Community at itk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/community
> 
> 
> -- 
> Best regards,
> 
> Vladimir S. FONOV ~ vladimir.fonov <at> gmail.com
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-developers

More information about the Community mailing list