[CMake] Volunteering to become maintainer of FindLibLZMA.cmake

Rolf Eike Beer eike at sf-mail.de
Wed May 9 04:00:10 EDT 2012


> Hi Eike,
>
> here a new version with the version support

Looks good. Just a small nitpicks:

-you should document also the LIBLZMA_VERSION_{MAJOR,MINOR,PATCH} variables

-I would move setting LIBLZMA_LIBRARIES and LIBLZMA_INCLUDE_DIRS below the
call to FPHSA and wrap it in an "if (LIBLZMA_FOUND)"

Eike


More information about the CMake mailing list