[CMake] error with FindQt4.cmake (on master)

[David Cole]

On Thu, Feb 24, 2011 at 10:17 AM, Arnaud GELAS
<arnaud_gelas at hms.harvard.edu> wrote:
> On 02/23/2011 07:35 PM, Clinton Stimpson wrote:
>>
>> On Wednesday, February 23, 2011 02:38:38 pm Arnaud GELAS wrote:
>>>
>>> On 02/23/2011 04:35 PM, Clinton Stimpson wrote:
>>>>
>>>> On Wednesday, February 23, 2011 02:27:29 pm Arnaud GELAS wrote:
>>>>>
>>>>> On 02/23/2011 04:26 PM, Clinton Stimpson wrote:
>>>>>>
>>>>>> On Wednesday, February 23, 2011 02:12:12 pm Arnaud GELAS wrote:
>>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>>
>>>>>>> I have just pulled from master, and in my project I can't get the
>>>>>>> QT_VERSION_MINOR
>>>>>>>
>>>>>>>
>>>>>>> Here is what I get when configuring my project:
>>>>>>>
>>>>>>> -- Found Qt4: /usr/bin/qmake-qt4 (found version "4.7.1")
>>>>>>>
>>>>>>> CMake Error at CMakeLists.txt:446 (MESSAGE):
>>>>>>>
>>>>>>> GoFigure2 requires Qt4.5 (or newer version) to be installed
>>>>>>>
>>>>>>>
>>>>>>> QT_VERSION_MAJOR and QT_VERSION_MINOR are empty...
>>>>>>>
>>>>>>>
>>>>>>> It was working before (with previous master version)...
>>>>>>>
>>>>>>>
>>>>>>> Should I track down this error with 'git bisect' or anyone know what
>>>>>>> could be wrong?
>>>>>>
>>>>>> No need for a git bisect.  Now that you mention this, I know which
>>>>>> commit did this (it was merged into master yesterday), and I can look
>>>>>> at it.
>>>>>>
>>>>>> Also, you could change your CMakeLists.txt to use
>>>>>> find_package(Qt4 4.5)
>>>>>> to have it check the minimum version number for you.
>>>>>
>>>>> Is find_package( Qt4 4.5 ) backward compatible?
>>>>> Will it work with cmake 2.8.2 and 2.8.3 ?
>>>>
>>>> Its been there for a while.  2.8.0 supported it.
>>>
>>> Great! thanks!
>>
>> Its been fixed.
>> http://cmake.org/gitweb?p=cmake.git;a=commit;h=6b9bc5
>> Thanks.
>>
> Thanks for fixing it!
>
> Do you know when it is going to be merged on master?
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.cmake.org/mailman/listinfo/cmake
>

Probably next Tuesday. Brad King and I review changes that are in
'next' once a week (usually on Tuesdays) and merge the changes that
are "ready" over to master...

HTH,
David