[CMake] CMake Digest, Vol 77, Issue 104

[Ryan Pavlik]

On Fri, Oct 1, 2010 at 4:23 AM, David Aldrich <David.Aldrich at eu.nec.com> wrote:
> Hi
>
>> if(CMAKE_BUILD_TYPE EQUAL Debug)
>>    set(CMAKE_CXX_FLAGS -Wno-long-long -Wno-comment -Wwrite-strings
>> -std=c++0x -pedantic-errors -pedantic -Wall -W -g -gdwarf-2 -Weffc++
>> -Wmain -Wextra)
>> else(CMAKE_BUILD_TYPE EQUAL Debug)
>>    set(CMAKE_CXX_FLAGS -s etc)
>> endif(CMAKE_BUILD_TYPE EQUAL Debug)
>
> As a total non-expert I don't see how this will work because if build type is "Debug" then CMake will use CMAKE_CXX_FLAGS_DEBUG not CMAKE_CXX_FLAGS.
>
> Am I right?
>
> Best regards
>
> David
>



I believe it would use both, however, if you are checking
CMAKE_BUILD_TYPE, then your build system will not work as expected on
multi-configuration generators like Visual Studio and XCode.  Setting
CMAKE_CXX_FLAGS_DEBUG is the way to go.

Ryan




>> -----Original Message-----
>> From: cmake-bounces at cmake.org [mailto:cmake-bounces at cmake.org] On Behalf Of
>> fatman at crackmonkey.us
>> Sent: 01 October 2010 09:50
>> To: cmake at cmake.org
>> Subject: Re: [CMake] CMake Digest, Vol 77, Issue 104
>>
>>
>> > Date: Wed, 29 Sep 2010 03:14:57 +0200
>> > From: Michael Hertling <mhertling at online.de>
>> > Subject: Re: [CMake] How to set compiler flags?
>> > To: cmake at cmake.org
>> > Message-ID: <4CA29311.1050909 at online.de>
>> > Content-Type: text/plain; charset=ISO-8859-1
>> >
>> > > [...] So I now use add_definitions instead:
>> > >
>> > > add_definitions( "-Wall -m64 -O3" )
>> > >
>> > > Is there a better way of doing this?
>> >
>> > Don't do this at all, and adhere to the flags.
>> >
>>
>> Interesting - I've been doing this:
>>
>> if(CMAKE_BUILD_TYPE EQUAL Debug)
>>    set(CMAKE_CXX_FLAGS -Wno-long-long -Wno-comment -Wwrite-strings
>> -std=c++0x -pedantic-errors -pedantic -Wall -W -g -gdwarf-2 -Weffc++
>> -Wmain -Wextra)
>> else(CMAKE_BUILD_TYPE EQUAL Debug)
>>    set(CMAKE_CXX_FLAGS -s etc)
>> endif(CMAKE_BUILD_TYPE EQUAL Debug)
>>
>> because it never occurred to me to do it another way.
>>
>> Is this wrong too?
>>
>> Regards,
>> Adam J Richardson
-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpavlik at iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik