[CMake] Cannot buils NSIS installer on Windows/Wascana

[David Cole]

You are correct. I assumed CMakeInstall.bmp was still in the source tree
because I know it used to be there.... Looks like it was removed from the
source tree 2 months ago. (I see it in the CVS "Attic" for that
directory...)

That file is still there in the CMake-2-4 branch...

I will ask around to find out the intent behind removing the file.


Thanks for pointing this out,
David



On 9/6/07, Eric Noulard <eric.noulard at gmail.com> wrote:
>
> 2007/9/6, David Cole <david.cole at kitware.com>:
> > Line 402 of "CMake 2.4/share/cmake-2.4/Modules/NSIS.template.in" reads:
> >   !define CPACK_PACKAGE_ICON at CPACK_PACKAGE_ICON@
> >
> > I think there should be a space and double quotes, like this:
> >   !define CPACK_PACKAGE_ICON "@CPACK_PACKAGE_ICON@"
> >
> > In fact, I'm not entirely sure why this appears to work when we build
> the
> > CMake installer... Maybe we are getting lucky with a NSIS bug that was
> > masking this mistake. I notice you are using NSIS v2.29 -- maybe they
> fixed
> > a bug... and now this pops up (correctly) as an error?
>
> Don't know about this.
>
> >
> > Anyhow, if you change that line of NSIS.template.in and then rebuild,
> does
> > the problem go away? If so, I will commit this fix to CVS CMake.
>
> I will try that tomorrow, since the windows box
> stay at work :=)
>
> However,
> regarding the error the trouble seems to come from the fact
> that the file
>
> "CMakeInstall.bmp"
>
> is missing from CMake/Utilities/Release/
> CVS source tree?
>
> Don't you have the file in your tree which may not
> be checked-in CVS?
>
>
> --
> Erk
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://public.kitware.com/pipermail/cmake/attachments/20070906/3acb022e/attachment.html