[CMake] FindPerlLibs.cmake and FindSwig.cmake outdated!

[Axel Roebel]

On Thursday 07 December 2006 20:37, Tristan Carel wrote:
> On 12/7/06, Axel Roebel <Axel.Roebel at ircam.fr> wrote:
> > On Wednesday 06 December 2006 17:36, Axel Roebel wrote:
> > > > I will test the module tomorrow.
> > > > Could you please put a RC2 of the `FindSWIG.cmake' on the bug
> > > > tracker?
> > >
> > > That may take a day or too.
> > >
> > > I'll let you know.
> >
> > There it is, called FindSWIG.cmake-2
> >
> > It should take care of all your comments,
> > please have a look. I would especially be
> > interested to hear if it works on windows.
> > I can only try linux and Mac OS X
>
> Cool!
>
> The version works fine on Windows with 1.3.{29,30,31}!!!!
>
> However I've got several comments

Hi Tristan,


> 2. if the Swig executable version is changed, SWIG_DIR and
> SWIG_VERSION are not updated. But as there are computed thanks to a
> EXECUTE_PROCESS, if SWIG_EXECUTABLE changes, SWIG_DIR and SWIG_VERSION
> must be updated.

ok great


> 2. I'm maybe paranoid, but I guess all internal variables declared by
> a module should be prefixed by the module's name.
>
> 3. in the CMake/Modules/readme.txt, you can read:
> "If the QUIET option is given to the command it will set the variable
> XXX_FIND_QUIETLY to true before loading the FindXXX.cmake module."
>
> but you use: FIND_SWIG_QUIETLY

yes in fact I didn't read that file. 

> 4. Previous version only use SWIG_EXECUTABLE, there is no need to
> introduce a new variable SWIG.
>
>
> I put a third version of the bug tracker.
> http://public.kitware.com/Bug/bug.php?op=show&bugid=4145

Fine - error handling was obviously sub optimal in my code.

The last version works for me, as well.

Thanks for the feedback.

-- 
Axel Roebel    
IRCAM Analysis/Synthesis Team
Phone: ++33-1-4478 4845 | Fax: ++33-1-4478 1540