[CMake] kdevelop3 generator broke

[Brad King]

Alexander Neundorf wrote:
> it seems the new unix makefile generator broke the kdevelop3 project  
> generator. Simple test: just run "cmake . -GKDevelop3" and try to build 
> it (i.e. make). It fails here with   
>  
> -- Build files have been written to: /usr/src/kde3-HEAD/ 
> kdevelop_3_3_branch/tmo/kdevelop  
> make[1]: Leaving directory `/home/src/kde3-HEAD/kdevelop_3_3_branch/tmo/ 
> kdevelop'  
> make  -f cmake.check_depends  
> make[1]: Entering directory `/home/src/kde3-HEAD/kdevelop_3_3_branch/tmo/ 
> kdevelop'  
> make[1]: cmake.check_depends: No such file or directory  
> make[1]: *** No rule to make target `cmake.check_depends'.  Stop.  
> make[1]: Leaving directory `/home/src/kde3-HEAD/kdevelop_3_3_branch/tmo/ 
> kdevelop'  
> make: *** [default_target] Error 2  
>   
> The generated makefile looks quite different to the one generated by the  
> makefile generator.  
> I attached both top level makefiles, the one generated with the KDevelop3  
> generator is Makefile.kdev.  
>   
> Any ideas  what's going wrong ?  

Part of the new generator commit removed support for the old generator 
to build dependencies.  We just have to change the KDevelop3 generator 
to use the new makefile generator.  The old one will probably be removed 
before the next release anyway.  I see that there is a 
cmLocalKdevelopGenerator that just trivially subclasses from 
cmLocalUnixMakefileGenerator.  Changing it to subclass from 
cmLocalUnixMakefileGenerator2 seems to fix the problem.  However, I'm 
wondering why there is a separate local generator at all.  It doesn't 
seem to add any functionality.  Can we just remove it and tell 
cmGlobalKdevelopGenerator to use cmLocalUnixMakefileGenerator2 directly?

-Brad