[Cmake] include external msproject

[Clinton Stimpson]

I've attached a patch file that'll fix this problem.  It changes just 
one line of code in cmGlobalVisualStudio71Generator.cxx and I used the 
VS 6.0 code for comparison.

I can make a simple test case to make sure this command works with VC 
6.0 and 7.1.  Who do I give this test case to?
Are you just looking for a simple set of code, project files, and 
CMakeLists.txt files to build a hello world or something?

Clint

Bill Hoffman wrote:

>Yes, that would be a good way to help.   Try to keep the changes
>down to only ones that affect this part of the code so we can integrate
>it faster.  If you could think of a way to construct a test that tests
>this feature, that would make sure it keeps on working.  
>
>-Bill
>
>
>At 03:52 PM 9/13/2004, you wrote:
>  
>
>>Bill,
>>
>>What can I do to help out here?  It is in my interest to see this working asap.  I have a large project with an existing build system that I need to integrate with this other build system and I need to make it work pretty soon for a bunch of other developers to start using.
>>
>>Do you want me to go through the CMake code and make it work for me and provide the patches?
>>
>>Clint
>>
>>William A. Hoffman wrote:
>>
>>    
>>
>>>It may be none of them do.   The command was added by someone for VS 6, and there
>>>are not test cases for it.  In the last version, I tried to "fix" it for VS 7, but
>>>it seems like it still has a few problems.  It used to just crash cmake, so it is better
>>>than it was. 
>>>-Bill
>>>
>>>
>>>At 02:49 PM 9/13/2004, Clinton Stimpson wrote:
>>>
>>>
>>>      
>>>
>>>>2.0.3.
>>>>
>>>>Anybody know what version of cmake this actually works in for generating 7.1 solution files?
>>>>
>>>>Clint
>>>>
>>>>William A. Hoffman wrote:
>>>>
>>>>  
>>>>
>>>>        
>>>>
>>>>>That command is a bit buggy, what version of cmake are you using?
>>>>>
>>>>>At 02:17 PM 9/13/2004, Clinton Stimpson wrote:
>>>>>
>>>>>
>>>>>
>>>>>    
>>>>>
>>>>>          
>>>>>
>>>>>>How is INCLUDE_EXTERNAL_MSPROJECT supposed to work?
>>>>>>
>>>>>>The docs say you can add two or more dependents, but that doesn't work for me.  I can only add one as cmake will give me an error if I try to give it more than one.  "CMake Error:  Utility targets can only have one output.  ..."
>>>>>>
>>>>>>Also if I have something similar to this...
>>>>>>
>>>>>>PROJECT(MYLIB)
>>>>>>....
>>>>>>
>>>>>>ADD_LIBRARY(mylib ....)
>>>>>>
>>>>>>
>>>>>>IF(WIN32)
>>>>>>
>>>>>>INCLUDE_EXTERNAL_MSPROJECT(depproj path/to/project/depproj)
>>>>>>ADD_DEPENDENCIES(mylib depproj)
>>>>>>
>>>>>>ENDIF(WIN32)
>>>>>>
>>>>>>
>>>>>>Just the existence of INCLUDE_EXTERNAL_MSPROJECT prevents MYLIB from showing up in the solution.  I only have the depproj showing up in my solution.  This is not a problem for generating vc 6.0 workspaces/project files.
>>>>>>
>>>>>>I'm not seeing INCLUDE_EXTERNAL_MSPROJECT working for me at all while generating VC 7.1 projects/solutions.
>>>>>>
>>>>>>Clint
>>>>>>
>>>>>>
>>>>>>_______________________________________________
>>>>>>Cmake mailing list
>>>>>>Cmake at www.cmake.org
>>>>>>http://www.cmake.org/mailman/listinfo/cmake
>>>>>>
>>>>>>      
>>>>>>            
>>>>>>
>>>>>    
>>>>>          
>>>>>
>>>>_______________________________________________
>>>>Cmake mailing list
>>>>Cmake at www.cmake.org
>>>>http://www.cmake.org/mailman/listinfo/cmake
>>>>  
>>>>        
>>>>
>>>      
>>>
>
>
>  
>
-------------- next part --------------
? cmake.vcproj
? cmake.vcproj.cmake
? CMakeLib.vcproj
? CMakeLib.vcproj.cmake
? cmake_install.cmake
? cmConfigure.h
? cmsys
? cmw9xcom.vcproj
? cmw9xcom.vcproj.cmake
? ctest.vcproj
? ctest.vcproj.cmake
? DartTestfile.txt
? DumpDocumentation.vcproj
? DumpDocumentation.vcproj.cmake
? include_external_proj7-1_patch.txt
Index: cmGlobalVisualStudio71Generator.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmGlobalVisualStudio71Generator.cxx,v
retrieving revision 1.12
diff -u -r1.12 cmGlobalVisualStudio71Generator.cxx
--- cmGlobalVisualStudio71Generator.cxx	15 Jun 2004 12:30:22 -0000	1.12
+++ cmGlobalVisualStudio71Generator.cxx	13 Sep 2004 21:53:52 -0000
@@ -128,7 +128,6 @@
         depends.push_back(cc.GetOutput());
         this->WriteExternalProject(fout, stuff[0].c_str(), 
                                    stuff[1].c_str(), depends);
-        ++si;
         }
       else 
         {