[cmake-developers] [PATCH] Add a test for checking that the CPack module produces correct config files

Роман Донченко dpb at corrigendum.ru
Wed Aug 26 18:30:41 EDT 2015


Domen Vrankar <domen.vrankar at gmail.com> писал в своём письме Wed, 26 Aug  
2015 22:27:43 +0300:

> 2015-08-19 21:08 GMT+02:00 Роман Донченко <dpb at corrigendum.ru>:
>> Currently, the only case is for simple variable values (not containing  
>> any
>> CMake-special characters and not determined by CPack itself).
>
> In CPackRPM and CPackDeb both cases that this is testing (CMake list
> variable and a variable containing spaces) are already tested
> implicitly. RunCMake.CPack contains such test. Admittedly both cases
> are not present in same variable.

> Is this test targeting a particular CPack generator or a CMake-CPack
> bug on a particular OS?

My motivation is this. I want to submit a few improvements to the way  
CPack writes config files, starting with that cpack_set_if_not_set change  
I mentioned a while back. This functionality is generator-independent (and  
basically unrelated to actual package generation), so I thought  
RunCMake.CPack was not the appropriate place to test it.

Since there doesn't seem to be a test suite specifically for config file  
writing, I thought I'd create one in a separate patch so that my later  
patches don't have as much boilerplate in them. The Simple test is just  
there to ensure I don't break the simple case while changing the more  
complex ones. Well, and it would be silly to submit a test suite with no  
tests in it.

Roman.


More information about the cmake-developers mailing list