[cmake-developers] [PATCH] Fix error in compiling C++ files generating by protobuf compiler when .proto files are organized in a directory hierarchy
David Cole
dlrdave at aol.com
Mon May 26 16:16:41 EDT 2014
> ... Long story short I think it is safe to assume ...
It is never safe to assume anything. I don't have personal experience
with protobuf....
But in general, inputs to CMake are allowed to be full path or not, and
when not, they're usually treated relative to CMAKE_CURRENT_SOURCE_DIR.
Consult the documentation on individual functions for details. After
this, I'll be quiet on this, but I wouldn't accept the patch as is
without a guarantee that relative paths are the only ones allowed as
input.
Hopefully, Philip Lowman is listening, and he can chime in. He's listed
as the FindProtobuf module maintainer here:
http://www.cmake.org/Wiki/CMake:Module_Maintainers
Cheers,
David C.
More information about the cmake-developers
mailing list