[cmake-developers] Please review FindQt_versioned_tools

[Brad King]

On 05/21/2014 09:18 AM, Stephen Kelly wrote:
> I recall discussion about this kind of thing before, but I think
> relating to qmake-qt4 and other versioned names.

Currently qmake is preferred over qmake-qt4, but I do not know
why.  There is a check to avoid using qmake from Qt5 at least:

 FindQt4: Do not use qmake from Qt5, 2013-03-05
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=21123416

Originally qmake-qt4 was preferred over qmake:

 ENH: Add support for debian having both qt3 and qt4, 2006-02-28
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2251970c
 (qmake-qt4 qmake)

Then the order was reversed without much detail in the commit:

 ENH: -apply the patches by Clinton Stimpson, 2006-04-27
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f59ad1aa
 (qmake qmake-qt4)

The commit message mentions porting some changes from KDE's
module, so perhaps history is there.

Later they were flipped back and forth in one day:

 ENH:  Clarify a doc string.  Fixes #10358, 2010-03-17
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd0b37ea
 (qmake-qt4 qmake)

 Change to use FindX11.cmake.  Should fix #9929, 2010-03-17
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=61ad5242
 (qmake qmake-qt4)

so that was likely an accident followed by a correction.

I think there was discussion too but I also do not remember when
or where.

-Brad