[cmake-developers] Tests with custom launchers and "Not Run"

Rolf Eike Beer eike at sf-mail.de
Fri Sep 21 11:41:50 EDT 2012


Marcel Loose wrote:
> On 19/09/12 08:18, Rolf Eike Beer wrote:
> > David Cole wrote:
> >> I don't like it. Existing tests that run and return, for example, a
> >> number
> >> of errors that occurred, will magically appear as "not run" when that
> >> number just so happens to be 77.
> >> 
> >> If there are enough people who think this is "simple and works" and are
> >> not
> >> concerned about the accidental matching of an intentional return value of
> >> 77 that does NOT mean "not run" ... then I will relent and say, so be it,
> >> and allow it in.
> >> 
> >> But only if there are some people who speak up here or add notes to the
> >> bug.
> >> 
> >> It just seems wrong to me to treat 77 as some special number here.
> > 
> > I would still go and make that a target property where you can set the
> > return code where something is considered skipped. The only question is:
> > how to name the property?

> I already suggested to use a test property three years ago (see issue
> #8466). At that time David was very much against it, fearing to find "a
> ***huuuuuuggggeee*** can of worms right underneath the surface." Seems
> I'm slowly getting more fellow thinkers ;)

When you look at the issue you may notice that I said basically the same as 
above nearly 2 years ago ;)

But this time I have a patch ;) I've attached the test I used, for sure that 
needs to be make a proper testcase. I wonder if we should do stricter checking 
for the arguments passed to the property, e.g. if someone passes a string or 
other junk. But the same would apply to things like PROCESSORS.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-allow-to-mark-a-test-as-Not-Run-with-a-specific-retu.patch
Type: text/x-patch
Size: 3782 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120921/66ecc4d5/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CMakeLists.txt
Type: text/x-cmake
Size: 542 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120921/66ecc4d5/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: retparam.c
Type: text/x-csrc
Size: 150 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120921/66ecc4d5/attachment-0001.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120921/66ecc4d5/attachment.sig>


More information about the cmake-developers mailing list