[cmake-developers] Patch to support SVN externals in CTest update

[Xavier Besseron]

On Fri, Aug 24, 2012 at 5:09 PM, Brad King <brad.king at kitware.com> wrote:
>
> On 08/24/2012 08:50 AM, Xavier Besseron wrote:
> > I have split my changes in a series of small patches. Please find them
> > in attachment.
> > I have made sure that everything is compiling correctly and that the
> > CTest.UpdateSVN test runs successfully between each of them.
>
> Very nice, the series looks good.  Please rewrite the commits to
> wrap all C++ code to 79 columns or less.  This should be blank:
>
>  git log origin/master.. --pickaxe-regex -S'.{80}'
>
> Also do not add a trailing blank line in the first commit to
> cmCTestSVN.cxx.
>


Here is the new set of patches.



> > Some comments about the testing:
> > - Most of the code path added by these patches is executed by the
> > current test. Indeed with this design, the root svn repository and the
> > svn external repositories just use the same SVNInfo structure and the
> > same function calls.
> > - The issue (ie incorrect author and revision number for each modified
> > file) is currently not tested for any of the version control system.
> > Probably this should be added, but this requires some work.
> > - The current organization of the ctest_update() testing uses some
> > common scripts between the different version control system. I don't
> > know yet if it is possible to add tests with svn externals in this
> > organization without breaking the test for the other VC.
> >
> > If I am not too busy, I will try to follow up on the testing part in
> > the coming weeks.
>
> The Git update test has a submodule, so you can look at how that
> works without disrupting the common test code.
>


Thanks. I will look at this.


Xavier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-the-new-SVNInfo-structure.patch
Type: application/octet-stream
Size: 2488 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120903/e824b141/attachment-0014.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Extend-the-SVN-Revision-structure-to-include-info-ab.patch
Type: application/octet-stream
Size: 810 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120903/e824b141/attachment-0015.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-the-Repositories-list-and-the-RootInfo-pointer.patch
Type: application/octet-stream
Size: 994 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120903/e824b141/attachment-0016.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Create-the-SVNInfo-for-the-root-repository.patch
Type: application/octet-stream
Size: 978 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120903/e824b141/attachment-0017.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Use-the-SVNInfo-structure-instead-of-the-fields-URL-.patch
Type: application/octet-stream
Size: 13097 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120903/e824b141/attachment-0018.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Add-a-LoadExternal-function-and-an-ExternalParser-cl.patch
Type: application/octet-stream
Size: 3223 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120903/e824b141/attachment-0019.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Call-LoadExternals-and-perform-operations-on-all-ele.patch
Type: application/octet-stream
Size: 3652 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120903/e824b141/attachment-0020.obj>