[cmake-developers] [PATCH] Tell people that link_directories() is not what they are searching for

[Brad King]

On 10/26/2011 3:17 PM, Rolf Eike Beer wrote:
> Am Mittwoch 26 Oktober 2011, 15:14:22 schrieb Brad King:
>> What command are you using to generate this patch?  It does not apply
>> correctly with "git am" for me.  I end up manually removing the From: Date:
>> and Subject: from the commit message.
>
> git format-patch -1
>
> I copied that into the mail then. Maybe git am got confused when you saved the
> email because those headers were there from both git and the email program? No
> idea.

The command is correct but the file it generates is meant to be sent as
an email, not pasted into one.  Either attach it or send it as a message
using "git send-email".

>> Note that this command is rarely necessary.  Library locations returned
>> by find_package() and find_library() are absolute paths.  Pass these
>> absolute library file paths directly to the target_link_libraries()
>> command.  CMake will ensure the linker finds them.
>
> I wouldn't object that either. Just wanting to get rid of this questions ;)

Please re-submit the patch with the above wording and using one of the
corrected methods described above.

Thanks,
-Brad