[cmake-developers] [PATCH 0/7] Preparation for Ninja generator: refactorings, bug fixes

[Nicolas Desprès]

On Wed, Nov 9, 2011 at 8:11 PM, Alexander Neundorf <neundorf at kde.org> wrote:
> On Wednesday 09 November 2011, Peter Collingbourne wrote:
>> On Tue, Oct 04, 2011 at 11:21:00PM +0200, Peter Kümmel wrote:
>> > On 04.10.2011 23:19, Peter Kümmel wrote:
>> > >On 03.10.2011 15:03, Brad King wrote:
>> > >>On 10/2/2011 1:41 PM, Peter Collingbourne wrote:
>> > >>>I have modified the commit message to include more details, and pushed
>> > >>>a modified branch to github.
>> > >>
>> > >>I've fetched the latest version of the branch.  Thanks for the updates.
>> > >>
>> > >>-Brad
>> > >
>> > >Could you also enable Ninja files for CodeBlock's generators?
>>
>> This doesn't appear to work here.  I ran CMake with the
>> CodeBlocks/Ninja generator over the CMake project, and received the
>> following error in CodeBlocks when I tried to build:
>>
>> Using makefile: Makefile
>> make: Makefile: No such file or directory
>> make: *** No rule to make target `Makefile'.  Stop.
>> Process terminated with status 2 (0 minutes, 0 seconds)
>>   0 errors, 0 warnings
>>
>> This is with CodeBlocks version 10.05.  The fix may be trivial,
>> but I don't know how easy it would be to teach CodeBlocks to use an
>> alternative build tool.
>>
>> > And maybe it is also trivial for 'Eclipse CDT4'.
>>
>> It isn't.  I ran CMake with the Eclipse/Ninja generator over the
>> CMake project, and I received a segmentation fault.  It seems
>> that the Eclipse generator assumes that the underlying generator
>> is the Unix Makefile generator (see the static_cast on line 1038 of
>> cmExtraEclipseCDT4Generator.cxx).
>
> Yes, there may be some dependencies, but there shouldn't be anything serious.
>

I'm probably missing some points here. But in term of design, The
Ninja Generator shouldn't be a sub-class of the Makefile Generator for
this to work smoothly?

-- 
Nicolas Desprès