[cmake-developers] [PATCH] Fixes to ExternalProject and it's tests

Rolf Eike Beer eike at sf-mail.de
Tue Nov 1 13:52:30 EDT 2011


These two patches address some issues I found:

-ExternalProject_Add(... DEPENDS something) does not work if that something is 
not itself created by ExternalProject_Add(). Fixed and testcase added.

-The testcases for ExternalProject fail to detect on my German system my 
Subversion version. We had the issue back in the FindSubversion.cmake some 
time again and fixed it there, no need to duplicate the old wrong code here.

The patches are independent of each other.

Greetings,

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-Subversion-detection-in-ExternalProject-tests.patch
Type: text/x-patch
Size: 1462 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20111101/9d7d9675/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ExternalProject-make-DEPENDS-work-with-normal-target.patch
Type: text/x-patch
Size: 2266 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20111101/9d7d9675/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20111101/9d7d9675/attachment.sig>


More information about the cmake-developers mailing list