[PATCH] fix matching output of "bison --version"

Rolf Eike Beer eike at sf-mail.de
Fri Nov 18 10:14:54 EST 2011


The output may contain semicolons, which will confuse the IF() because of
missing quoting.
---
 Modules/FindBISON.cmake |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Modules/FindBISON.cmake b/Modules/FindBISON.cmake
index 25fd51d..edde9eb 100644
--- a/Modules/FindBISON.cmake
+++ b/Modules/FindBISON.cmake
@@ -68,11 +68,11 @@ IF(BISON_EXECUTABLE)
     MESSAGE(SEND_ERROR "Command \"${BISON_EXECUTABLE} --version\" failed with output:\n${BISON_version_error}")
   ELSE()
     # Bison++
-    IF(${BISON_version_output} MATCHES "^bison\\+\\+")
+    IF("${BISON_version_output}" MATCHES "^bison\\+\\+")
       STRING(REGEX REPLACE "^bison\\+\\+ Version ([^,]+).*" "\\1"
         BISON_VERSION "${BISON_version_output}")
     # GNU Bison
-    ELSEIF(${BISON_version_output} MATCHES "^bison[^+]")
+    ELSEIF("${BISON_version_output}" MATCHES "^bison[^+]")
       STRING(REGEX REPLACE "^bison \\(GNU Bison\\) ([^\n]+)\n.*" "\\1"
         BISON_VERSION "${BISON_version_output}")
     ELSE()
-- 
1.7.7.3


--nextPart2255928.EVG6VgLnFt--



More information about the cmake-developers mailing list