[cmake-developers] module merge mania

Brad King brad.king at kitware.com
Tue Sep 19 14:09:40 EDT 2006


Alexander Neundorf wrote:
> On Tuesday 19 September 2006 18:49, Alexander Neundorf wrote:
>> On Tuesday 19 September 2006 00:03, Alexander Neundorf wrote:
>> ...
>>
>>> These two macros (check_struct_member and check_pointer_member) also both
>>> use CHECK_CXX_SOURCE_COMPILES(), i.e. C++.
>>> Is this a problem ?
>>>
>>> I could rename them a bit:
>>> CHECK_CXX_SOURCE_COMPILES:
>>> check_class_member()
>>> check_class_pointer_member()
>>>
>>> and two new ones with CHECK_C_SOURCE_COMPILES:
>>> check_struct_member()
>>> check_struct_pointer_member()
>>>
>>> Better ?
>> Any comments ?
> 
> I could also build the macro so that you can give the language as parameter:
> check_struct_member(CXX stat st_time STAT_HAS_ST_TIME)

I like the parameter version since "struct" is valid in both C and C++.
 Please make it give an error if the argument is not "C" or "CXX".

Thanks,
-Brad



More information about the cmake-developers mailing list