[Cmake-commits] [cmake-commits] king committed cmVariableWatchCommand.h 1.4 1.5
cmake-commits at cmake.org
cmake-commits at cmake.org
Fri Jul 24 16:53:10 EDT 2009
Update of /cvsroot/CMake/CMake/Source
In directory public:/mounts/ram/cvs-serv482/Source
Modified Files:
cmVariableWatchCommand.h
Log Message:
BUG: Keep variable_watch() commands in memory
The "Keep only FinalPass commands in memory" commit caused instances of
this command to be deleted after the InitialPass. Even though the
variable_watch command does not have a final pass, it does need to stay
alive because it owns the callback information.
Index: cmVariableWatchCommand.h
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmVariableWatchCommand.h,v
retrieving revision 1.4
retrieving revision 1.5
diff -C 2 -d -r1.4 -r1.5
*** cmVariableWatchCommand.h 23 Jan 2008 15:27:59 -0000 1.4
--- cmVariableWatchCommand.h 24 Jul 2009 20:53:07 -0000 1.5
***************
*** 57,60 ****
--- 57,64 ----
virtual bool IsScriptable() { return true; }
+ /** This command does not really have a final pass but it needs to
+ stay alive since it owns variable watch callback information. */
+ virtual bool HasFinalPass() const { return true; }
+
/**
* The name of the command as specified in CMakeList.txt.
More information about the Cmake-commits
mailing list