[Cmake-commits] [cmake-commits] king committed cmake.cxx 1.393 1.394

cmake-commits at cmake.org cmake-commits at cmake.org
Thu Sep 4 13:15:10 EDT 2008


Update of /cvsroot/CMake/CMake/Source
In directory public:/mounts/ram/cvs-serv22432/Source

Modified Files:
	cmake.cxx 
Log Message:
BUG: Fix unsetting of global properties

The set_property command unsets a property if it is given no value.  In
the case of GLOBAL properties, the cmake::SetProperty method would
replace a NULL value with "NOTFOUND".  Instead it should be left as NULL
so that the property is unset as expected.  Once it is unset the
get_cmake_property command will still report NOTFOUND while the
get_property command will return the empty string as documented.


Index: cmake.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmake.cxx,v
retrieving revision 1.393
retrieving revision 1.394
diff -C 2 -d -r1.393 -r1.394
*** cmake.cxx	19 Aug 2008 17:31:21 -0000	1.393
--- cmake.cxx	4 Sep 2008 17:15:08 -0000	1.394
***************
*** 3551,3558 ****
      return;
      }
-   if (!value)
-     {
-     value = "NOTFOUND";
-     }
  
    this->Properties.SetProperty(prop, value, cmProperty::GLOBAL);
--- 3551,3554 ----



More information about the Cmake-commits mailing list