[Cmake-commits] [cmake-commits] king committed cmLocalGenerator.cxx 1.280 1.281 cmTarget.cxx 1.220 1.221

cmake-commits at cmake.org cmake-commits at cmake.org
Mon Aug 18 11:26:53 EDT 2008


Update of /cvsroot/CMake/CMake/Source
In directory public:/mounts/ram/cvs-serv6357/Source

Modified Files:
	cmLocalGenerator.cxx cmTarget.cxx 
Log Message:
STYLE: Convert unused target type cases to default

In switch statements that deal with only a few target types, use a
'default' case for the remaining target types instead of listing them
explicitly.  This will make it easier to add more types in the future.


Index: cmLocalGenerator.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmLocalGenerator.cxx,v
retrieving revision 1.280
retrieving revision 1.281
diff -C 2 -d -r1.280 -r1.281
*** cmLocalGenerator.cxx	5 Aug 2008 17:27:06 -0000	1.280
--- cmLocalGenerator.cxx	18 Aug 2008 15:26:50 -0000	1.281
***************
*** 724,732 ****
          }
          break; 
!       case cmTarget::UTILITY:
!       case cmTarget::GLOBAL_TARGET:
!       case cmTarget::INSTALL_FILES:
!       case cmTarget::INSTALL_PROGRAMS:
!       case cmTarget::INSTALL_DIRECTORY:
          break;
        }
--- 724,728 ----
          }
          break; 
!       default:
          break;
        }
***************
*** 1442,1450 ****
        }
        break; 
!     case cmTarget::UTILITY:
!     case cmTarget::GLOBAL_TARGET:
!     case cmTarget::INSTALL_FILES:
!     case cmTarget::INSTALL_PROGRAMS:
!     case cmTarget::INSTALL_DIRECTORY:
        break;
      }
--- 1438,1442 ----
        }
        break; 
!     default:
        break;
      }

Index: cmTarget.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmTarget.cxx,v
retrieving revision 1.220
retrieving revision 1.221
diff -C 2 -d -r1.220 -r1.221
*** cmTarget.cxx	23 Jul 2008 16:59:14 -0000	1.220
--- cmTarget.cxx	18 Aug 2008 15:26:51 -0000	1.221
***************
*** 2044,2052 ****
      case cmTarget::EXECUTABLE:
        return "_LINK_EXECUTABLE";
!     case cmTarget::UTILITY:
!     case cmTarget::GLOBAL_TARGET:
!     case cmTarget::INSTALL_FILES:
!     case cmTarget::INSTALL_PROGRAMS:
!     case cmTarget::INSTALL_DIRECTORY:
        break;
      }
--- 2044,2048 ----
      case cmTarget::EXECUTABLE:
        return "_LINK_EXECUTABLE";
!     default:
        break;
      }
***************
*** 2074,2082 ****
                ? "CMAKE_IMPORT_LIBRARY_SUFFIX"
                : "CMAKE_EXECUTABLE_SUFFIX");
!     case cmTarget::UTILITY:
!     case cmTarget::GLOBAL_TARGET:
!     case cmTarget::INSTALL_FILES:
!     case cmTarget::INSTALL_PROGRAMS:
!     case cmTarget::INSTALL_DIRECTORY:
        break;
      }
--- 2070,2074 ----
                ? "CMAKE_IMPORT_LIBRARY_SUFFIX"
                : "CMAKE_EXECUTABLE_SUFFIX");
!     default:
        break;
      }
***************
*** 2103,2111 ****
      case cmTarget::EXECUTABLE:
        return (implib? "CMAKE_IMPORT_LIBRARY_PREFIX" : "");
!     case cmTarget::UTILITY:
!     case cmTarget::GLOBAL_TARGET:
!     case cmTarget::INSTALL_FILES:
!     case cmTarget::INSTALL_PROGRAMS:
!     case cmTarget::INSTALL_DIRECTORY:
        break;
      }
--- 2095,2099 ----
      case cmTarget::EXECUTABLE:
        return (implib? "CMAKE_IMPORT_LIBRARY_PREFIX" : "");
!     default:
        break;
      }



More information about the Cmake-commits mailing list