From elvstone at gmail.com  Mon Mar 27 08:56:49 2023
From: elvstone at gmail.com (Elvis Stansvik)
Date: Mon, 27 Mar 2023 10:56:49 +0200
Subject: [CDash] Question about displayImage.php
Message-ID: <CAHms=eaFzcinYKXELz1+aPVKNtNL2yY3Wg7KQAXtF7uUNSoE3A@mail.gmail.com>

Hi folks,

Quite a while ago, I migrated our CDash into Docker and updated to
what was at the time (Jan 2022) the latest version version from Git
master.

Now that I look back, I see that I've left a bunch of local changes in
the source tree. I think I was attempting to fix some issue, but then
was abruptly occupied by something else, and left things in a bit of a
mess.

The changes I made are all of the form

estan at njord:/home/orexplore/cdash-docker$ git diff app/cdash/public/login.xsl
diff --git a/app/cdash/public/login.xsl b/app/cdash/public/login.xsl
index c538db9c9..50866f4c0 100644
--- a/app/cdash/public/login.xsl
+++ b/app/cdash/public/login.xsl
@@ -38,7 +38,7 @@
                  <xsl:attribute name="alt"></xsl:attribute>
                  <xsl:choose>
                    <xsl:when test="cdash/dashboard/logoid>0">
-                      <xsl:attribute
name="src">displayImage.php?imgid=<xsl:value-of
select="cdash/dashboard/logoid"/></xsl:attribute>
+                      <xsl:attribute name="src">image/<xsl:value-of
select="cdash/dashboard/logoid"/></xsl:attribute>
                    </xsl:when>
                    <xsl:otherwise>
                      <xsl:attribute
name="src">img/cdash.png?rev=2019-05-08</xsl:attribute>
estan at njord:/home/orexplore/cdash-docker$

I.e. they switch from using displayImage.php to using image/ when
referring to images to be displayed.

Now this is a strange question: I have no memory of why I had to do
this. Perhaps I was preparing what I thought was some fix and intended
to submit it as a PR.. (?) Before I dig any further, I just thought
I'd ask people familiar with the code base: Can anyone see a reason
for why I would have had to make these changes? I think it must have
been to solve some issue I was having.

I.e. can anyone help me re-jug my memory about this? :P Would changes
like these make sense for upstream CDash?

Cheers,
Elvis