[CDash] Broken links to github.com/<organization>/<project>/pull/CHANGE_ID at cdash.org/index.php
niels_dekker_address_until_2024 at xs4all.nl
Sat Apr 7 20:48:15 UTC 2018
Update: I just found a little drawback of the workaround that I
presented (entering uppercase "HTTPS" in the "Repository Viewer URL"
field). It breaks the link of the "Repository" menu item, in the Project
menu, at http://trunk.cdash.org/?project=SuperElastix
After my workaround, the "Repository" menu item links to:
That's clearly wrong. But I feel it's more important to have correct
links to pull requests.
-------- Original Message --------
Date: 2018-04-07 22:26
From: Niels Dekker
Zack Galbreath wrote on Sat, Apr 7 2018 14:00:
> On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker wrote:
>> Update #2: As a workaround, I entered the "Repository Viewer URL"
>> (CDash Settings, Project, Repository) with uppercase "HTTPS":
> That sounds like a reasonable workaround. Thanks for digging into
> this issue and figuring out what's causing it. I think the right fix
> (as you indicated) is to remove the stripHTTP function and its uses
> altogether. But I want to do some manual testing first to make sure
> this won't cause problems with any of our other external links.
You're welcome, Zack :-) I guess there must have been a reason to do
stripHTTP, that I just don't know... So far, I only saw one side effect
of entering uppercase "HTTPS" in the "Repository Viewer URL" field. When
I entered the URL, a text appeared next to "Test URL:", saying:
That doesn't look good: "http://HTTPS://github.com/...". But does it do
any harm, if it's just the "Test URL"?
By the way, on the first Settings tab page ("Information"), the "Home
URL" is also stripped. I don't know whether this is either buggy or
Kind regards, Niels
LKEB, Leiden University Medical Center
More information about the CDash