[CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code?

[Niels Dekker]

It would be very convenient if each Update page of a project would show 
the corresponding revision tag (Git SHA) of the project, possibly with a 
link to the specific revision (e.g., at GitHub). It seems like this 
functionality was built into CDash, but it just does not work! 
Colleagues of mine at LKEB (www.lkeb.nl) helped me to find some possible 
bugs in the CDash AngularJS code, that seem to cause this issue.

Regarding the SuperElastix project that I am involved with 
(https://github.com/SuperElastix), I would have liked to see the Git SHA 
of SuperElastix at http://trunk.cdash.org/viewUpdate.php?buildid=1238277 
  The HTML source of that page says:

<div ng-if="::cdash.updates.revision">
   <b>Revision: </b>
   <a 
ng-href="::cdash.update.revisionurl">{{::cdash.update.revision}}</a>
   <div ng-if="::cdash.update.priorrevision">
   <br/>
   <b>Prior Revision: </b>
   <a 
ng-href="::cdash.update.revisiondiff">{{::cdash.update.priorrevision}}</a>
   <br/>
   <br/>
</div>

Could it be that "cdash.updates.revision" was misspelled? Shouldn't it 
be "cdash.update.revision" (without the 's')?

Moreover, it seems that some extra "{{" and "}}" might be needed, for 
AngularJS markups inside an ng-href="...". Specifically, it seems that 
"::cdash.update.revisionurl" should be "{{::cdash.update.revisionurl}}". 
What do you think?


Related file (I guess):
https://github.com/Kitware/CDash/blob/4f328cd838d0486901f58c2844fd11415b4abb52/public/views/viewUpdate.html

HTH, Niels

-- 
Niels Dekker
Scientific programmer
LKEB, Leiden University Medical Center